Commit Graph

182 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
2d02a15de3 Add static to closures that don't use $this
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 18:30:57 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-22 02:12:36 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
bb0bc3bb93
Merge #16131 - Unit test suite improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 23:32:11 +02:00
William Desportes
7e81b0b3d7
Merge callProtectedMethod and callPrivateFunction into callFunction
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 22:59:29 +02:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-21 15:29:36 -03:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
5195520883
Coding standard fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:18:05 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
a7490fcb6c
Make AbstractTestCase manage GLOBALS cleanup and config loading
Signed-off-by: William Desportes <williamdes@wdes.fr>
Some minor improvements

Signed-off-by: William Desportes <williamdes@wdes.fr>

Force sql-parser to reload the new language

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-19 11:21:42 -03:00
William Desportes
947f9ad04f
Remove some unused code detected by codacy
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 23:57:22 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
Maurício Meneghini Fauth
4a0bce1d53 Extract db structure bulk actions from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-22 23:13:35 -03:00
Maurício Meneghini Fauth
ca40546bd2 Extract table field actions from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-22 19:41:52 -03:00
Maurício Meneghini Fauth
ae0d7127e0 Extract the drop_db action from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-20 20:00:52 -03:00
William Desportes
54e0250dae
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 12:50:30 +02:00
William Desportes
62a6591d3f
Fix some phpcs issues after latest phpcs 3.5.5 release
I left the false positives unfixed: https://github.com/squizlabs/PHP_CodeSniffer/issues/2937#issuecomment-615498860
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 01:01:38 +02:00
Maurício Meneghini Fauth
afd69b1ab3 Extract HTML from Index::generateIndexChoiceSelector
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-28 19:16:05 -03:00
Maurício Meneghini Fauth
0721fbbc1e Fix Server/Status/AdvisorControllerTest tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 13:27:18 -03:00
Maurício Meneghini Fauth
e656f341ef Redesign the server status advisor page
Uses an accordion instead of a table to show the issues.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 02:56:16 -03:00
Maurício Meneghini Fauth
1a3416da8d Add support for Bootstrap modals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-12 20:33:48 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
59ce2dbd67 Fix MonitorControllerTest
Fixes Server\Status\MonitorControllerTest when runned in isolation.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:46:27 -03:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 15:02:28 -03:00
Maurício Meneghini Fauth
e36f5a1938 Refactor Table\SearchController
Moves the table select entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-28 22:18:29 -03:00
Maurício Meneghini Fauth
98424ec065 Extract class from Table\SearchController
Extracts the buildSqlQuery method from
Controllers\Table\SearchController class to the new Table\Search class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-27 22:01:28 -03:00
Maurício Meneghini Fauth
ee8951ea74 Create Table\FindReplaceController controller
Moves the table find-replace entry point logic to the
FindReplaceController, removes the entry point file and extracts the
find-replace logic from the Table\SearchController class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-27 17:54:19 -03:00
Maurício Meneghini Fauth
3f522e8ae2 Fix some tests when running them in isolation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 21:16:30 -03:00
Maurício Meneghini Fauth
62eecc8f5d Fix Server\Status\MonitorControllerTest tests
Adds missing $response->setAjax(true) calls.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 14:10:08 -03:00
Maurício Meneghini Fauth
ab9d94b2b3 Refactor Table\IndexesController controller
Moves the indexes entry point logic to the controller and removes the
entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 12:28:30 -03:00