Commit Graph

157 Commits

Author SHA1 Message Date
William Desportes
c05387f7d3
Improve retry to connect button style
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-07 16:06:50 +02:00
William Desportes
3f0b7390e2
Fix documentation after removing _ from private methods
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:56:48 +02:00
William Desportes
707d263531
Fix testSetGetPdf and testSetGetPdfTitle
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:54:45 +02:00
charliewindred
7d792e88f6
Removed underscores from unit test methods
Removed underscore prefixes from unit test method calls.

Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 23:52:32 +02:00
Maurício Meneghini Fauth
e29f892d62 Use consts to select the CodeGen handler format
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:36:32 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true}
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
d82eb1b24a
Mark extensions to skip tests on minimal php setups
This will help people packaging phpMyAdmin and also make our test suite runnable by more people.

Tested on alpine with the minimal extensions:
php-dom php-iconv php-mysqli php-json php-mbstring php-iconv php-session

[PHP Modules]
Core
date
dom
filter
hash
iconv
json
libxml
mbstring
mysqli
mysqlnd
openssl
pcre
readline
Reflection
session
SPL
standard
zlib



Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-25 23:20:53 +02:00
William Desportes
a878168e6c
Fix a typo in my last commit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 09:08:26 +02:00
William Desportes
b8e6834058
Rename PmaTestCase to AbstractNetwokTestCase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:49:22 +02:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
5195520883
Coding standard fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:18:05 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest

Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
80a45fa0ae Break too long lines
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-16 18:08:20 -03:00
William Desportes
9bc55b2bc9
Remove some unused variable assignements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 22:44:50 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
86822d7a02
Fix a test after the merge of #15872
Ref: d93bbf3cbb
It was a mistake in d93bbf3cbb
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-03 23:47:29 +02:00
William Desportes
d93bbf3cbb
Fix tests after the merge of #15872
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 13:44:59 +02:00
William Desportes
dbae05fa14
Fix ExportSqlTest a failing assertion after #15416
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-02 02:05:06 +02:00
Maurício Meneghini Fauth
b0a728fea6 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-26 18:29:39 -03:00
Maurício Meneghini Fauth
9d8fda54d2 Fix phpcs false positive test
Related to 62a6591d3f

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-26 18:01:13 -03:00
William Desportes
b411c64adc
Fix testAuthError after merge of #16066
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-05 16:02:29 +02:00
Isaac Bennetch
98f761a245 Merge branch 'QA_5_0' 2020-03-20 23:04:06 -04:00
Isaac Bennetch
8c847c55ca Merge branch 'QA_4_9' into QA_5_0 2020-03-20 23:01:53 -04:00
Isaac Bennetch
2ee7e9840f Fix transformation test
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-20 23:00:57 -04:00
William Desportes
e225229638
Fix testAuthError after merge of #16011
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-10 21:34:18 +01:00
William Desportes
7f90a6172a
Fix some broken tests on Windows CI because of line endings
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:52:00 +01:00
Maurício Meneghini Fauth
cd009f8ede Use Bootstrap list group for the home page lists
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-14 16:27:30 -03:00
William Desportes
517222ff59
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
William Desportes
14edb793b6
Fix test after #15901 - Fix #15795 - Broken link on "MySQL said"
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 22:58:51 +01:00
Hugues Peccatte
57442680fa
Fix #15555 - Add IP2Long input transformation
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2020-01-27 20:52:01 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
William Desportes
d292855d69
Merge branch 'QA_5_0'
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 14:45:43 +01:00
William Desportes
187194b7e6
Merge #15805 - Fix #15802 - removed SET AUTOCOMMIT=0 from export
Fixes: #15802
Pull-request: #15805
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 14:10:35 +01:00
William Desportes
3311c089c4
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 21:25:25 +01:00
William Desportes
af100abddf
Add more tests for testCookieDecrypt
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 19:07:27 +01:00
William Desportes
c1c8e09586
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-06 23:45:16 +01:00