Commit Graph

42 Commits

Author SHA1 Message Date
Deven Bansod
74fd7986eb Remove debugging calls
Fix #12706

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-16 09:23:06 +05:30
Deven Bansod
cb7abad0b5 Remove call to old methods, fix tests
Remove definition of old method. Remove related tests

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-09 10:40:00 +05:30
Deven Bansod
956f3179cb Fix Navigation tests and Export tests
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-11-04 11:55:46 +05:30
Deven Bansod
f14cffdbe7 Properly escape strings in MySQL statement values
Use *_real_escape string functions provided by connectors to escape strings while exporting

Fix #12453

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>

Conflicts:
	libraries/server_privileges.lib.php
2016-10-29 10:45:12 +05:30
Deven Bansod
f8ea67f2bc Fix #12530: Show enabled links for Edit and Execute after proper priv checks
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
2016-09-16 13:51:34 +05:30
Michal Čihař
42d54a938a Remove MySQL version caching
In my testing the session/cache access is slower than fetching single
value from MySQL and calculating the values.

Also the caching would need some logic for invalidation as the server
can be upgraded or configuration changed.

Fixes #11924

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-07 09:28:13 +02:00
Michal Čihař
e01f404804 Remove unused variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-02 14:40:18 +02:00
Michal Čihař
eb3e3b73c3 Simplified handling of connection errors
There is no need to retrigger errors, just let the handler know to
handle them without backtrace.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-02 14:35:36 +02:00
Michal Čihař
ae79ceb3a4 Do not error on unset server port
Fixes #12339

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-02 08:53:06 +02:00
Pavel Rochnyack
c310304712 Restore Overhead column in Server > Databases > Enable Statistics.
(Was removed in 582b02262b)

Signed-off-by: Pavel Rochnyack <pavel2000@ngs.ru>
2016-07-27 19:56:43 +01:00
Michal Čihař
f5e8953356 Share backtrace processing for debugging and error reporting
We want to achieve same thing in both cases - backtrace which is
stripped from sensitive information, has reasonable size and can be
read. Sharing the code will make it easier to fix possible problems and
also will make both cases behave consistent.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 11:18:39 +02:00
Michal Čihař
2ae8b9248e Simplify server port handling
The intval function does return 0 for empty string, so we really do not
have to special case here.

Issue #12279

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-03 15:21:48 +02:00
Michal Čihař
11089cbe41 Use https for links to dev.mysql.com
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-17 10:16:44 +02:00
Michal Čihař
6b8f56dffd Imporove simplification of backtrace for console
Replace only objects, include regular items verbatim.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-11 15:14:12 +02:00
Michal Čihař
d57d4e6e5a Do not include call to _dbgQuery in backtrace
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-11 15:11:37 +02:00
Michal Čihař
d67facb641 Avoid storing objects in session when debugging SQL
When $cfg['DBG']['sql'] is enabled, we used to store full backtrace in
session. This includes DBI objects which then can cause problems on
session start.

Issue #12229

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-11 15:03:15 +02:00
Michal Čihař
cfbc31bfa6 Better reporting of connection errors
We really do not care about traceback or parameters in this case, all we
need is to display the message coming from PHP.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-04-18 13:32:52 +02:00
Michal Čihař
c2c85cd15c Fix class names
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-28 17:15:47 +01:00
Michal Čihař
ed96969ff9 Merge branch 'QA_4_5' 2016-01-28 09:23:27 +01:00
Michal Čihař
cbca7ca202 Show MySQL error messages in user language
Fixes #11789

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-13 08:49:02 +01:00
Marc Delisle
9df4afb256 This one needed a lettered operator
Signed-off-by: Marc Delisle <marc@infomarc.info>
2016-01-05 17:23:41 -05:00
Marc Delisle
68f8adfd84 No letters for logical operators
https://github.com/dseguy/clearPHP/blob/master/rules/no-letter-logical.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2016-01-05 17:17:43 -05:00
Michal Čihař
a74efb0c30 Simplify getting first element of an array
Calling current() after reset() is duplicate as reset() already returns
current index value.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-05 12:37:50 +01:00
Michal Čihař
e1c9dec998 Merge commit '912f96114dc803404e2854ebb5796757a4eeedb6' 2016-01-05 08:21:32 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Marc Delisle
911f8274c7 Clarify class and variable name
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-31 08:09:47 -05:00
Michal Čihař
58ba4b83b8 Merge branch 'QA_4_5' 2015-12-28 11:51:20 +01:00
Marc Delisle
d9bec7f085 HTML line break shown after a MySQL connection error message
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-07 09:02:07 -05:00
Michal Čihař
0d15a96427 Merge branch 'QA_4_5' 2015-12-04 12:14:41 +01:00
Marc Delisle
84f57eaf2f Clarify comment
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-11-26 14:23:57 -05:00
Hugues Peccatte
f9d582bd09 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-11-08 15:58:48 +01:00
Madhura Jayaratne
4c300ff574 Remove unnecessary check
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-11-02 20:51:19 +11:00
Hugues Peccatte
21460a01c0 Merge branch 'master' into useNamespaces_master 2015-09-18 23:17:22 +02:00
Hugues Peccatte
42169e0258 Fix merge.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-10 08:09:51 +02:00
Hugues Peccatte
42c0ebac85 Merge branch 'master' into useNamespaces_master 2015-09-09 22:05:00 +02:00
Hugues Peccatte
b1038cfefa Merge branch 'master' into useNamespaces_master 2015-09-04 22:37:45 +02:00
Hugues Peccatte
1b4b456626 Set namespace on DBI's classes (except DBIDummy).
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 22:18:47 +02:00
Hugues Peccatte
3e5da41078 Move PMA\SystemDatabase to PMA\libraries\SystemDatabase.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
7f8f34e89d Remove classes require_once.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
58b10807c8 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:22 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00