Commit Graph

62 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
af148ad92b Enable strict mode in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
a862add418 Replace static methods with instance methods
Replace PhpMyAdmin\Operations static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-25 12:43:49 -03:00
Maurício Meneghini Fauth
0d11ecc728 Refactor operations functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-08-20 21:28:36 -03:00
Maurício Meneghini Fauth
ca910e8de8 Move classes to PhpMyAdmin namespace
- Move Table to PhpMyAdmin namespace
- Move Template to PhpMyAdmin namespace
- Move ThemeManager to PhpMyAdmin namespace
- Move Theme to PhpMyAdmin namespace
- Move Tracker to PhpMyAdmin namespace
- Move Transformations to PhpMyAdmin namespace
- Move TypesMySQL to PhpMyAdmin namespace
- Move Types to PhpMyAdmin namespace
- Move Util to PhpMyAdmin namespace
- Move VersionInformation to PhpMyAdmin namespace
- Move Url to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-08 10:54:21 -03:00
Maurício Meneghini Fauth
119563b7ea Move classes to PhpMyAdmin namespace
- Move OpenDocument to PhpMyAdmin namespace
- Move OutputBuffering to PhpMyAdmin namespace
- Move Partition to PhpMyAdmin namespace
- Move Pdf class to PhpMyAdmin namespace
- Move RecentFavoriteTable to PhpMyAdmin namespace
- Move Response to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 23:44:10 -03:00
Maurício Meneghini Fauth
54a15dbd9c Move classes to PhpMyAdmin namespace
- Move Logging to PhpMyAdmin namespace
- Move Menu to PhpMyAdmin namespace
- Move Message to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-06-30 13:30:04 -03:00
Michal Čihař
7a139816d1 Remove explicit size attributes from operation inputs
There is really no reason to specify this for every input.

Issue #13145

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-28 16:26:00 +02:00
Michal Čihař
edad6fc2d9 Remove custom layout for operations pages
Using plain layout looks better in most situations. Maybe we should
limit width as well, but I'm not sure about that.

Fixes #13145
Obsoletes #13339
Obsoletes #13369

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-06-28 16:16:37 +02:00
Michal Čihař
9f2773c9c2 Simplify rereading of information
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-03-20 17:55:38 +01:00
Vishal Pandey
5da44ce1a6 Move the tbl_info.inc.php code to Table class
Fixes #12567

Signed-off-by: flash1452 <vishpandey2014@gmail.com>
2017-03-20 17:55:21 +01:00
Michal Čihař
6897a5df53 Fix messages handling
The first two messages were not used at all, now we concatenate them
all.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-17 17:21:31 +02:00
Michal Čihař
a7cd193554 Make it clear whether addMessages expects string or Message object
With this, it's way easier to anaylize code for potential problems with
escaping.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 14:56:41 +02:00
Michal Čihař
a87c164435 Actually get warning messages to display
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-16 14:50:46 +02:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Madhura Jayaratne
25f7f1a6f9 Update to match the namespace usage
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-02-16 20:03:13 +11:00
Madhura Jayaratne
49bfc5b744 Merge branch 'QA_4_5' into QA_4_6 2016-02-16 19:48:38 +11:00
Madhura Jayaratne
7881a461a3 Fix #11969 Missing confirmation while dropping a view in view_operations.php
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-02-16 19:47:12 +11:00
Marc Delisle
66c15daba0 Remove some unnecessary string concatenations
https://github.com/dseguy/clearPHP/blob/master/rules/no-unnecessary-string-concatenation.md

Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-12-06 08:01:07 -05:00
Hugues Peccatte
ffc4422db7 Make PHPCS happy.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-10-19 20:33:21 +02:00
Hugues Peccatte
0761fb1801 Rename classes files.
Rename classes.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:21 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Dan Ungureanu
91b97fadc2 Remove unneeded closing tags.
Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
2015-07-19 00:18:38 +03:00
Hugues Peccatte
37f6b992da Fix typos.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-06-14 13:50:57 +02:00
Marc Delisle
8f2429c053 Remove extraneous argument
Signed-off-by: Marc Delisle <marc@infomarc.info>
2015-04-17 13:16:09 -04:00
Dhananjay Nakrani
bfef3e80df Remove unnecessarily added empty lines.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
9a1fb901d0 Remove included 'common_error_reporting.php' script and its inclusion from all the scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:54 +05:30
Dhananjay Nakrani
e9d5523795 Include error reporting script at the end of all the 'relevant' scripts.
Signed-off-by: Dhananjay Nakrani <dhananjaynakrani@gmail.com>
2014-06-16 11:50:53 +05:30
Michal Čihař
b485c6105c Remove blank lines from the end of PHP files (causing extra output)
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-24 10:57:21 +01:00
Michal Čihař
77caf6151b Correct punctuation for sentences
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-02-02 11:19:15 +01:00
Michal Čihař
6a4e37d300 Make status messages a sentence 2014-01-29 13:33:15 +01:00
Michal Čihař
0ad8a147c5 Coding style: wrap long line 2013-10-02 11:45:45 +02:00
Marc Delisle
7dd3ed7315 Merge branch 'QA_4_0' 2013-09-18 13:07:08 -04:00
Marc Delisle
23d26377bf bug #3988 Rename view is not working 2013-09-18 13:06:44 -04:00
Marc Delisle
a5f20214fe Js confirm for drop view in Operations 2013-09-17 11:03:00 -04:00
Marc Delisle
922c5f4e89 Merge commit '00ce00e' 2013-09-17 10:37:30 -04:00
Marc Delisle
00ce00edfc bug #3986 Missing DROP VIEW button 2013-09-17 10:35:17 -04:00
J.M
f94ff72dfc Add required attribute to table name for rename and move operations 2013-08-18 15:43:43 +02:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
34dce1d3b4 Various coding style improvements 2013-06-11 16:27:31 +02:00
Chanaka Indrajith
6971295e96 Renamed PMA_CommonFunctions::getInstance()-> with PMA_Util:: 2012-09-16 14:41:47 +05:30
Madhura Jayaratne
2095bc3211 Wrap some long lines 2012-09-05 22:13:55 +05:30
Chanaka Indrajith
766466135e Implement class behavior of common.lib.php file 2012-06-22 23:38:33 +05:30
Rouslan Placella
eb98110541 Dropped footer.inc.php 2012-06-11 14:06:04 +01:00
Michal Čihař
ccb9228bce Remove unused parameter 2012-06-04 11:52:14 +02:00
Chanaka Indrajith
bf15800089 Remove HTML rendering inside the functions in display_tbl.lib.php file itselves 2012-05-11 16:05:55 +05:30
Rouslan Placella
28923b496e Renamed tbl_common.php to tbl_common.inc.php for better consistency 2012-05-05 16:44:27 +01:00
Rouslan Placella
2c805ade8b Dropped tbl_links.inc.php 2012-05-05 16:44:27 +01:00