gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,759 Commits 12 Branches 481 Tags 2.4 GiB
525009b2fd
Commit Graph

96 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
342ab3f67a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 14:36:32 -03:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
William Desportes
24ac923632
Fix Internal error in ./libraries/classes/Controllers/HomeController.php#314 
TypeError: mb_strlen(): Argument #1 ($string) must be of type string, bool given

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-02-22 12:47:59 +01:00
Maurício Meneghini Fauth
785f8c1c00
Use constructor property promotion where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 19:39:02 -03:00
Maurício Meneghini Fauth
613678f8f5
Replace assignments with null coalesce equal operator 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-20 17:03:05 -03:00
Kamil Tekiela
8a1d6f1eaa Convert var annotations to typed properties 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-12 21:31:04 +00:00
Maurício Meneghini Fauth
d2809ca096
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-11-21 13:50:30 -03:00
William Desportes
883226c1f7
Ref #17478 - Fix mistake in PHP operators 
Ref: 630f9bf00e
Thank you @MoonE !

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-21 16:37:44 +01:00
William Desportes
630f9bf00e
Ref #17478 - Fix PHP Undefined array key "auth_type" when server does not start at 0 
```
Internal error in ./libraries/classes/Controllers/HomeController.php#235
 ErrorException: Undefined array key "auth_type"
```

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-20 23:02:50 +01:00
Sebastian Walther
d569fe2f05 Use ServerRequestObject to access POST-vars 
Signed-off-by: Sebastian Walther <swalther@complex-it.de>
 2022-10-20 01:23:50 -03:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Maurício Meneghini Fauth
6a9fe03ff2
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 00:45:10 -03:00
Maurício Meneghini Fauth
5d9142674d
Allow longer cookie encryption keys to be used 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:34:18 -03:00
Maurício Meneghini Fauth
0ed04a6c00
Remove trigger_error calls from HomeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit c5611531c0)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:33:38 -03:00
Maurício Meneghini Fauth
3c618c22a9
Add ServerRequest parameter to all controllers 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-28 01:00:08 -03:00
Maurício Meneghini Fauth
e7487227e5
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-06-06 17:07:13 -03:00
Andrija Vučinić
c6bb867787 Revert to old behavior for ShowServerInfo 
Seems we changed the flag behavior here: cd1b8a9b77 (diff-bb8d8aecc2e174245e8b95be9344176aba8971d024f3b2c2311b8e58ddd59b31L149)

I'm not sure whether that was intentional, but it causes the `Database server` panel to always show compared to pre 5.2.0.

Truth be told, it doesn't make sense to have that flag and then the additional checks in the block when we know it's `true`, so I updated the code to take care of that.

Signed-off-by: Andrija Vučinić <andrija.vucinic@gmail.com>
 2022-05-11 22:57:55 +02:00
Maurício Meneghini Fauth
c5611531c0 Remove trigger_error calls from HomeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-30 22:13:54 -03:00
Maurício Meneghini Fauth
5950693fb3
Fix possible undefined globals 
Related to https://github.com/phpmyadmin/phpmyadmin/pull/17427.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-10 18:05:21 -03:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Maurício Meneghini Fauth
411bacf613
Use Sodium for auth cookies encryption 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 18:46:04 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
c4575fd48b
Add methods to check for RelationParameters features 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-11 08:10:40 -03:00
Kamil Tekiela
945d887a10 Fix var annotation for Charset and Collation 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-09 22:25:58 +00:00
Maurício Meneghini Fauth
b2a51c4d84
Create the RelationParameters value object 
Replaces the $cfgRelation array with the RelationParameters value
object.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-14 18:22:36 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
9adce40034
Extract controllers from HomeController 
Extracts CollationConnectionController, GitInfoController and
RecentTablesListController controllers from HomeController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-05 00:40:18 -03:00
Maurício Meneghini Fauth
2de0a7cbd7
Update Psalm baseline 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-28 12:11:52 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00
Maurício Meneghini Fauth
cd1b8a9b77
Fix some errors found by PHPStan and Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-05-22 15:14:24 -03:00
William Desportes
77b5e402c5
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-11 01:20:20 +02:00
William Desportes
ef758ae43d
Merge #16855 - Replace secure.php.net with www.php.net and remove Polish and Persian 
Pull-request: #16855

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-05-10 23:30:25 +02:00
William Desportes
9487604a42
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-28 02:12:17 +02:00
William Desportes
34f8295b94
Fix #16854 - Undefined index: SERVER_SOFTWARE 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-27 23:57:30 +02:00
Liviu-Mihail Concioiu
1c8f9b4d23 Replace secure.php.net with www.php.net and remove Polish and Persian from PHP documentation 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2021-04-26 14:32:03 +02:00
Maurício Meneghini Fauth
f19a3d95c4
Remove LanguageManager::getSelectorDisplay method 
Redesign the language selector to use Bootstrap style.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-04-22 15:51:26 -03:00
William Desportes
187ef65d26
Extract some logic from HomeController::checkRequirements into smaller functions 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-20 22:27:58 +02:00
Maurício Meneghini Fauth
7ba3e3db9e
Fix possible null arg when creating a new Git object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-25 14:18:45 -03:00
Maurício Meneghini Fauth
91bd0df2e5
Rename $err_url global to $errorUrl 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-24 19:39:28 -03:00
William Desportes
84ede575e3
Remove dependency on Config class of Git class 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-24 18:29:52 +01:00
Maurício Meneghini Fauth
33d711215d
Remove the PMA_VERSION constant 
Uses the PhpMyAdmin\Version::VERSION constant instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 22:22:55 -03:00
William Desportes
b5263d44c8
Replace PMA_MAJOR_VERSION by Version::SERIES 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-03-05 21:22:42 +01:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
0b8edc5bde
Use PSR-12 for namespace use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 14:18:35 -03:00
Maurício Meneghini Fauth
12d662baa3
Replace themes preview popup with a modal 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-02-04 23:21:31 -03:00
Maurício Meneghini Fauth
17a01d9d9d
Extract the HTML from ThemeManager::getHtmlSelectBox 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-28 22:34:01 -03:00