gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
125,165 Commits 12 Branches 481 Tags 2.4 GiB
55e95ccd09
Commit Graph

270 Commits

Author SHA1 Message Date
William Desportes
e4b0e6bf81
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-11-25 21:39:21 +01:00
Scott Mcgowan
6fc1401ee2
Fix column names option for CSV Export 
Previously work was done to enable column names in CSV exports by
default. This change actually ended up overwriting the column name value
so that column names were included in all exports regardless of whether
or not the property was disabled. This commit changes the default for
column names to enabled as the original change intended, and removes
the property overwrite.

Signed-off-by: Scott McGowan mcgowanscott16@gmail.com
 2022-11-25 21:15:49 +01:00
William Desportes
ea5a541f7b
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2022-10-29 17:26:44 +02:00
Liviu-Mihail Concioiu
a366032ab9 Fix 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-10-29 16:09:09 +02:00
Liviu-Mihail Concioiu
73f6017f2f Fix 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-10-29 15:33:19 +02:00
Liviu-Mihail Concioiu
e64d7e2661 Fix SCHEMA_NAME links 
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
 2022-10-28 09:49:38 +02:00
Maurício Meneghini Fauth
0216137094
Merge pull request #17799 from kamil-tekiela/js-escaping 
Refactor JS escaping mechanism
 2022-10-17 20:24:33 -03:00
Kamil Tekiela
fd7b043cf3 Use json_encode in addJsValidate 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 21:28:57 +01:00
Kamil Tekiela
270ad693eb Replace uses of escapeJsString with json_encode 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 21:28:56 +01:00
Kamil Tekiela
35a4291d57 Refactor ServerConfigChecks::performConfigChecks 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2022-10-17 21:26:05 +01:00
Maurício Meneghini Fauth
a52f50ad58 Merge branch 'standan-hulk-fix-phpstan-issues' 
Resolves https://github.com/phpmyadmin/phpmyadmin/pull/17782

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-17 16:42:36 -03:00
Maurício Meneghini Fauth
3890d11dd8
Fix some coding style issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-16 17:18:54 -03:00
Daniel Platt
93cc48c33b fix return type errors from phpstan - add more specific array types 
Signed-off-by: Daniel Platt <82732185+standan-hulk@users.noreply.github.com>
 2022-10-13 12:11:11 +02:00
Maurício Meneghini Fauth
8da8d3f8c8 Add types for Config\FormDisplay::save() parameters 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-12 19:19:36 -03:00
Maurício Meneghini Fauth
6a9fe03ff2
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-29 00:45:10 -03:00
Maurício Meneghini Fauth
700db7e72b
Update the docs to reflect the blowfish_secret changes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:34:13 -03:00
Maurício Meneghini Fauth
5d4884d294
Update setup page to generate better blowfish_secret keys 
Instead of generating a printable string, it generates a binary string
and converts it to an hexadecimal string.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-09-26 17:33:38 -03:00
Maurício Meneghini Fauth
d3a267fdfc
Refactor DbiMysqli::connect to use Server value object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-08-29 18:19:38 -03:00
Maurício Meneghini Fauth
a55b8e88f9
Assign config.js globals to the window object 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-07-01 16:23:22 -03:00
Maurício Meneghini Fauth
4891f2dc74
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-21 14:45:17 -03:00
Maurício Meneghini Fauth
2c5143feda Remove ResponseRenderer::getFooter method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-04-09 12:32:14 -03:00
Maurício Meneghini Fauth
c0941401c1
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-11 14:26:19 -03:00
Erol Guven
b20111d63b Allow removing DEFINER clause from exported SQL 
Signed-off-by: Erol Guven <erol.guven@appian.com>
 2022-03-10 13:32:04 +00:00
Maurício Meneghini Fauth
1438cb211e
Replace global keyword with $GLOBALS 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-03-07 17:31:11 -03:00
Jonah Tan
0ea87bc42c Replace html in export description with bb code 
Signed-off-by: Jonah Tan <47470981+jonahtanjz@users.noreply.github.com>
 2022-02-08 00:32:43 +08:00
Maurício Meneghini Fauth
0bee94b27e
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-11 14:31:56 -03:00
Kamil Tekiela
d44578ee04 Refactor flattenArray into getFlatArray in ConfigFile 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-07 19:38:37 +00:00
Kamil Tekiela
5eb3404170 Cache translations for names, comments and descriptions 
This should improve performance of their lookups. It's unlikely that
translations will change during the course of the request.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-12-07 19:38:37 +00:00
Kamil Tekiela
488e7cb5bf Use array_keys whenever only keys are needed in foreach 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2021-11-29 20:37:39 +00:00
Maurício Meneghini Fauth
857a9d3337
Remove unnecessary @var annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-11-18 12:15:30 -03:00
Maurício Meneghini Fauth
3922cb7928
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-10-27 15:04:40 -03:00
Hidayatullah
064f1eb64b
Fix bbcode not rendered for error messages on setup 
Fixes #17090
Closes #17138

Signed-off-by: Hidayatullah <ayat.kyo@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-10-27 14:39:27 -03:00
Maurício Meneghini Fauth
67e96cf40c
Get default config values from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-30 12:04:47 -03:00
Maurício Meneghini Fauth
3e0856c77b
Remove useless string concatenations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-27 21:40:22 -03:00
Maurício Meneghini Fauth
229d8dfb5e
Extract Console, Debug and SqlQueryBox classes from Settings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-19 13:17:32 -03:00
Maurício Meneghini Fauth
73034e43e1
Extract setter methods from Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-18 12:44:48 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
b2aab39003
Extract methods for setting properties 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-24 19:09:34 -03:00
Maurício Meneghini Fauth
5837b691d2
Extract methods for setting properties 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-23 18:03:57 -03:00
Maurício Meneghini Fauth
04d3c83559
Fix some errors found by PHPStan/Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-05 16:09:08 -03:00
Maurício Meneghini Fauth
229767bc30
Add more tests for Config\Settings classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-02 19:29:45 -03:00
Maurício Meneghini Fauth
fa92760002
Add tests for Config\Settings\Export class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-31 15:59:24 -03:00
Maurício Meneghini Fauth
437bd7c974
Create Settings value object for $cfg global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-31 15:59:24 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
cab899d7b5
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-21 15:58:11 -03:00
Maurício Meneghini Fauth
6989d615a5
Fix some errors found by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-09 13:07:40 -03:00
Maurício Meneghini Fauth
1c084de30b
Fix coding standard errors 
Related to 62f142c9fa.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-03 16:50:33 -03:00