Commit Graph

102 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
65d2693d85
Merge pull request #14845 from Tithugues/feature/replace-or-improve-for
Replace or improve use of 'for'
2019-01-12 13:18:05 -03:00
Hugues Peccatte
7685733389 Replace or improve use of 'for'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 09:43:25 +01:00
Hugues Peccatte
68b88d0537 Remove useless variables before return
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:33:22 +01:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Madhura Jayaratne
abb690e536 Escape SQL query in copy query functionality. Thanks to Ashish Kamble for reporting
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-12-14 23:23:55 +11:00
Mohammad Reza Mansouri
95167e6893 Fix missed padding on query results (#14730)
Solves missed paddings on query results.

Fixes #14053 

Signed-off-by: Mohammad Reza Mansouri <beekalam@gmail.com>
2018-11-28 20:52:36 -02:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Lakshay arora
2b065133a2 Adds features discussed in #13023
1. Show ajax errors at the bottom of the page, instead of showing them in a popup.
2. Add copy query button for errors in processing sql queries.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-11-14 23:20:12 -02:00
Maurício Meneghini Fauth
d7affca556 Fix uncaught TypeError in Util::printableBitValue
Fixes #14718

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 21:50:42 -02:00
Maurício Meneghini Fauth
c04982d5c5 Upgrade PHPUnit to v7
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-03 20:47:45 -03:00
Maurício Meneghini Fauth
235dac6667 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 22:13:17 -03:00
Maurício Meneghini Fauth
9fc76f9215 Add secondary tabs for database query
Fixes #13621 QBE selenium tests broken since merge of #13342

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 21:52:54 -03:00
Maurício Meneghini Fauth
8b2336a989 Remove unsed Util method
Removes PhpMyAdmin\Util::containsNonPrintableAscii static method.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-17 21:42:07 -03:00
Jérôme Cognard
5beca256a7 #14452 Remove hash param in edit query URL
Signed-off-by: Jérôme Cognard <jerome.cognard@gmail.com>
(cherry picked from commit 5d0fae07a6)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-22 23:05:37 -03:00
Maurício Meneghini Fauth
f3a7213651
Merge pull request #14454 from cognard/patch-2
Fixes #14452 Remove hash param in edit query URL
2018-08-22 22:44:38 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Isaac Bennetch
0a254c6989 Fix many Uncaught TypeErrors on a database operations page.
Fixes #14574

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-08-18 00:54:31 -04:00
Lakshay arora
75af21cff6
Merge branch 'master' into enh_1 2018-08-06 17:39:48 +05:30
Maurício Meneghini Fauth
465c443488 Fix docblock comment spacing in Util::linkToVarDocumentation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-07-27 18:29:13 -03:00
William Desportes
38009efb65
Add support for MySQL/MariaDB variables documentation
- Uses preferential mode MySQL docs for MySQL users and MariaDB docs for MariaDB users
- Unit tests now use data that only exists for tests
- Added package williamdes/mariadb-mysql-kbs

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-07-26 17:12:35 +02:00
Lakshay arora
a16959071c Apply suggested changes.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-07-12 12:53:13 +05:30
Lakshay arora
5fd4a006ee Login modal after session expiration
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-07-12 12:53:13 +05:30
Lakshay arora
568bc133cb Some other bug fixes
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-07-12 12:53:13 +05:30
Jérôme Cognard
5d0fae07a6
#14452 Remove hash param in edit query URL
Signed-off-by: Jérôme Cognard <jerome.cognard@gmail.com>
2018-07-04 11:47:58 +02:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
5edbdf2063 Remove Template::get() method
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 19:46:36 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 18:18:24 -03:00
Leonardo Strozzi
0d26cfb5f1 Finish db designer refactor
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-11 19:37:07 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 03:54:28 -03:00
Lakshay arora
9231620c2d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-05-12 03:44:58 -03:00
Maurício Meneghini Fauth
aa32ace0dc Refactor FileListing methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-09 22:07:45 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp()
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:39:53 -03:00
Lakshay arora
3bd97cef53 Fixes error 404 on creating views, issue #14082
Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>

(cherry picked from commit 29c45385ec)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-29 16:10:51 -03:00
Maurício Meneghini Fauth
3d8eafd68a Extract HTTP requests related methods
Move HTTP requests related methods from Util class to
PhpMyAdmin\Utils\HttpRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-01-22 17:31:57 -02:00
Michal Čihař
1ebf6c4953 Remove references to sourceforge.net issue trackers
We do not use it for years and all issues have been migrated.

Signed-off-by: Michal Čihař <michal@cihar.com>
2018-01-02 13:24:05 +01:00
Maurício Meneghini Fauth
e7003167ff Use template for Util::getFKCheckbox method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-27 23:44:23 -02:00
Michal Čihař
0b5b287049 Merge branch 'QA_4_7' 2017-12-15 11:10:00 +01:00