gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
115,985 Commits 12 Branches 481 Tags 2.4 GiB
5b67d2189c
Commit Graph

71 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
0291c48114 Remove Charsets::getCharsetDropdownBox method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-25 01:45:32 -03:00
Maurício Meneghini Fauth
b409c83224 Extract HTML from Rte\Routines::getParameterRow 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-24 18:36:59 -03:00
Maurício Meneghini Fauth
ee3791a119 Rename rte.js variables to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-29 19:47:30 -03:00
Maurício Meneghini Fauth
ce71901de5 Refactor js/functions.js to use a module 
Adds Functions module in js/functions.js to reduce the number of global variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-22 17:44:21 -03:00
Hugues Peccatte
91e9acb263 Update PHPDoc 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-14 21:59:57 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables 
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-11 00:34:57 +02:00
Hugues Peccatte
69895e4bb1 Use "strpos" instead of "strstr" to improve performances 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-07 23:58:05 +02:00
Maurício Meneghini Fauth
a9115725b2 Create database RTE controllers 
- Create PhpMyAdmin\Controllers\Database\RoutinesController
- Create PhpMyAdmin\Controllers\Database\TriggersController
- Create PhpMyAdmin\Controllers\Database\EventsController
- Remove libraries/rte/rte_main.inc.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-22 02:35:45 -03:00
Vincent Milum Jr
3f6e360a4e Fix for SYSTEM VERSIONED tables #14514, #14515, and #14516 (#14536) 
Fixes #14514
Fixes #14515
Possible fix for #14516

#14514 Tables which enable the new MariaDB 10.3 versioning show up as "SYSTEM VERSIONED" instead of "BASE TABLE" inside of information schema. This patch now checks for both, so these new table types don't incorrectly display as views.

#14515 MariaDB 10.3 also supports INVISIBLE columns, which is optionally paired with SYSTEM VERSIONED tabled (or implemented separately). This patch helps handle this new column attribute.

#14516 This patch cannot be fully tested and verified with current MariaDB builds. Version 10.3.9 (currently unreleased) corrects an issue with column information for SYSTEM VERSIONED columns that this patch relies on. https://jira.mariadb.org/browse/MDEV-16804 - the reason for checking with preg_match instead of adding to the list is because there are now combined "extra" information for columns, such as INVISIBLE columns. Just matching entire strings also has a bug with these other "extra" parameters.

Signed-off-by: Vincent Milum Jr <git@darkain.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-15 14:16:13 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-20 01:23:53 +01:00
Madhura Jayaratne
643c74797d Merge branch 'QA_4_8' 2019-01-09 22:39:00 +11:00
Madhura Jayaratne
8b836fc919 Fix #14787 Cannot execute stored procedure 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2019-01-09 22:37:25 +11:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors 
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
129086398f Remove unnecessary superglobals declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:17:06 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-12 21:04:19 -02:00
William Desportes
ca072c96d9
fix #14749 - Uncaught TypeError in routines 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-11-27 11:57:38 +01:00
Madhura Jayaratne
d0eede7c56 Retrieve parameters from $_POST in triggers 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-11-10 20:48:58 -02:00
Madhura Jayaratne
faced0a344 Retrieve parameters from $_POST in events 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-11-10 20:48:58 -02:00
Madhura Jayaratne
d9279982a9 Retrieve parameters from $_POST in routines 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2018-11-10 20:48:58 -02:00
victorffarias
be41ca5125 Issue #12262 - Removing inline styles (#14638) 
Signed-off-by: Victor Farias <victor.f.farias@gmail.com>
 2018-09-29 17:42:10 -03:00
Isaac Bennetch
1d39152af2 Merge branch 'QA_4_8' 2018-08-07 13:13:39 -04:00
Isaac Bennetch
0294bcc5f2 Fix #14554 Icon missing for creating a new routine, trigger, and event 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2018-08-07 13:05:37 -04:00
Andy Baugh
c55755d0ca Fix merge conflicts in QA_4_8 from this pull request 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

Fix bad callers to getError where null was being passed.

Fixes #14552: Considering how function signatures work in PHP, this should
be a reltatively 'safe' change, as the mysqli lib currently would still
do a check for cases where the passed in $link was either null or false.
Otherwise the bug's source appears to be a common mistake in PHP:
null != undefined

Signed-off-by: Andy Baugh <thomas.baugh@cpanel.net>
 2018-08-06 13:45:45 -04:00
Andy Baugh
793b062d57 Fix bad callers to getError where null was being passed. 
Fixes #14552: Considering how function signatures work in PHP, this should
be a reltatively 'safe' change, as the mysqli lib currently would still
do a check for cases where the passed in $link was either null or false.
Otherwise the bug's source appears to be a common mistake in PHP:
null != undefined

Signed-off-by: Andy Baugh <thomas.baugh@cpanel.net>
 2018-08-06 09:57:37 -05:00
William Desportes
e816e45c18 phpstan level 0 (#14405) 
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
0912a1f178 Fix missing parameter comment on RTE classes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-20 23:20:25 -03:00
Maurício Meneghini Fauth
3516f4d410 Remove $GLOBALS['dbi'] from Rte\General 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 21:53:08 -03:00
Maurício Meneghini Fauth
96dc767efb Remove $GLOBALS['dbi'] from Rte\Footer 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 21:46:35 -03:00
Maurício Meneghini Fauth
19476eab73 Remove $GLOBALS['dbi'] from Rte\Export 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 21:32:33 -03:00
Maurício Meneghini Fauth
bc2d5ea0d2 Remove $GLOBALS['dbi'] from Rte\RteList 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 21:05:36 -03:00
Maurício Meneghini Fauth
43d5c5db66 Remove $GLOBALS['dbi'] from Rte\Triggers 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 20:27:21 -03:00
Maurício Meneghini Fauth
510c11b039 Remove $GLOBALS['dbi'] from Rte\Routines 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 20:14:48 -03:00
Maurício Meneghini Fauth
66bd8b4a86 Remove $GLOBALS['dbi'] from Rte\Events 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 12:44:02 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes 
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
56ce176752 Enable strict mode in Rte classes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 03:20:45 -03:00
Maurício Meneghini Fauth
374b2379ad
Merge pull request #14179 from rijaspk/master 
Remove Inline Styles from Ruotines.php
 2018-04-24 00:47:33 -03:00
“Rijas
01692acc72 Remove Inline Styles from Ruotines.php 
Signed-off-by: Rijas Ahammed PK <rijaspk5195@gmail.com>
 2018-04-19 14:25:31 +05:30
Maurício Meneghini Fauth
f6bf0dba3c Refactor PhpMyAdmin\Rte\General methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
f078ed6b9f Refactor PhpMyAdmin\Rte\Words methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
604441575a Refactor PhpMyAdmin\Rte\RteList methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
67313b5e9d Refactor PhpMyAdmin\Rte\Footer static methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
9775d43b35 Refactor PhpMyAdmin\Rte\Export static methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
c0ed262b11 Refactor PhpMyAdmin\Rte\Triggers static methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00
Maurício Meneghini Fauth
7adffc0bc6 Refactor PhpMyAdmin\Rte\Events static methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-04-11 06:15:07 -03:00