Commit Graph

78 Commits

Author SHA1 Message Date
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c9129e9bd8 Remove unnecessary string concatenation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 17:47:33 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Hugues Peccatte
3470dd4918 Remove useless "i" modifier on non-character selection
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:27:18 +02:00
William Desportes
2ec96f829c
Use [] instead of array()
See: b851f9d1fc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:43:02 +02:00
William Desportes
b851f9d1fc
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:41:45 +02:00
William Desportes
3027f0ef49
Fix #13726 - Can not copy user on Percona Server 5.7 (password copy)
Fixes: #13726
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 11:03:39 +02:00
William Desportes
1f0e34ad07
Add ; at the end of SET old_passwords
Why ? : because all other queries have ; at the end.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 09:54:42 +02:00
William Desportes
49874c4e28
Fix #13726 - Can not copy user on Percona Server 5.7
Fixes: #13726
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 09:53:57 +02:00
William Desportes
e453ad1320
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:15:57 +02:00
William Desportes
91c758aae4
Fix #15229 - Notice - Undefined index: strPrivDescDelete versioning rowsTbl
Fixes: #15229
Adds support for delete versioning rows privilege
See: https://mariadb.com/kb/en/library/grant/#table-privileges
The privilege is named 'Delete versioning rows' in SHOW GRANTS and 'Delete_history_priv' in mysql.user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 18:42:02 +02:00
Maurício Meneghini Fauth
28dc7c2680 Fix type error in setup pages
DatabaseInterface can be null sometimes

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-11 16:52:57 -03:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
f3ccef50c6
Merge pull request #14860 from Tithugues/feature/use-real-names-not-aliases
Use real function names, not their aliases
2019-01-14 22:55:37 -03:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Hugues Peccatte
a8d801f176 Use real function names, not their aliases
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:37:52 +01:00
Hugues Peccatte
68b88d0537 Remove useless variables before return
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 01:33:22 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
a04a596829
Merge pull request #14792 from mauriciofauth/bootstrap-buttons
Use Bootstrap buttons component
2018-12-21 02:01:10 -02:00
Maurício Meneghini Fauth
2edd97a62b Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:55:50 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
12f898d871 Fix issue when adding user on MySQL 8.0.11
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 22:23:46 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
77bbfec0a9 Remove debug line
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 22:47:10 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Madhura Jayaratne
35d87e6072 Retrieve parameters from $_POST in user/Privileges pages
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
aeba92f982 Refactor Server/Privileges
Use dependency injection

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-16 17:00:10 -03:00
Maurício Meneghini Fauth
f4a68b0402 Remove $GLOBALS['dbi'] from Server/Privileges class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-16 13:21:51 -03:00
Maurício Meneghini Fauth
4bd3523768 Fix uncaught TypeError when adding databases to a user
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-09 23:04:00 -03:00
Maurício Meneghini Fauth
ddd43a25e1 Remove $GLOBALS['dbi'] from RelationCleanup class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-09-02 12:53:47 -03:00
Maurício Meneghini Fauth
c5cda26fa8 Refactor RelationCleanup methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-31 00:44:03 -03:00
Maurício Meneghini Fauth
d4b4124a5e Remove $GLOBALS['dbi'] from Relation class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-30 19:05:09 -03:00
William Desportes
3dce65d913 phpstan level 1 (#14472)
* level +1
* Install sami/sami globaly to avoid dependency clash

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-08-18 14:37:41 -03:00
Maurício Meneghini Fauth
bfc4dab5de
Merge pull request #14528 from laps15/refactor_server
Refactor server privileges templates
2018-08-02 20:04:59 -03:00
William Desportes
38009efb65
Add support for MySQL/MariaDB variables documentation
- Uses preferential mode MySQL docs for MySQL users and MariaDB docs for MariaDB users
- Unit tests now use data that only exists for tests
- Added package williamdes/mariadb-mysql-kbs

Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-07-26 17:12:35 +02:00
Leonardo Strozzi
685ccaf680 Move privileges' template dir to server's
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-07-24 22:31:06 -03:00
Maurício Meneghini Fauth
a2c4827e0b
Merge pull request #14408 from ibennetch/14407
Fix Uncaught TypeError in privilege editor
2018-06-25 20:41:55 -03:00
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Isaac Bennetch
bd311a89a1 Fix Uncaught TypeError in privilege editor
Fixes #14407

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2018-06-19 12:17:32 -04:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
2f99429917 Fix coding style errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-09 16:57:05 -03:00