Commit Graph

763 Commits

Author SHA1 Message Date
Marc Delisle
119049f7b3 Remove unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-14 10:32:47 -04:00
Marc Delisle
d731bf53aa Merge pull request #1282 from ashutoshdhundhara/unit_tests
Unit tests for new code upto mid term.
2014-07-12 15:53:00 -04:00
Ashutosh Dhundhara
3fd300e04b Unit tests for new code upto mid term.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fix coding style and code duplication.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Code refactor.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Remove unused code.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-07-13 00:17:03 +05:30
Isaac Bennetch
175c1a786a Merge pull request #1276 from D-storm/FR-637
RFE-637: Custom field handlers (input transformations)
2014-07-12 09:45:35 -04:00
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Chirayu Chiripal
0d70b314e7 test file for messages.inc.php
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-11 14:14:06 +05:30
Marc Delisle
9403921e4e Temporarily deactivate these tests (almost always fail on ci.phpmyadmin.net)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-07-06 06:58:20 -04:00
Bimal Yashodha
adf0d2e4b7 Remove old relational schema edit/export page and related code
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-07-01 17:51:45 +05:30
Bimal Yashodha
0b58c22afb Test for exporting functionality
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-07-01 11:42:42 +05:30
Chirayu Chiripal
32511719b1 RFE-1490 Dynamic process list
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-24 19:13:21 +05:30
Madhura Jayaratne
5697fecf81 Merge pull request #1241 from kb-yashodha/ut
Unit tests
2014-06-20 22:49:36 +05:30
Bimal Yashodha
0bd6b5bf89 Resolve issues reported by Scrutinizer
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-20 22:26:36 +05:30
Bimal Yashodha
6b52d4c68d Test for PMA_getFirstPage
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-20 00:40:15 +05:30
Bimal Yashodha
f470b2fbc3 Test for PMA_getPageName()
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-20 00:24:24 +05:30
Bimal Yashodha
6f7040f809 Tests for PMA_getHtmlForPageSaveAs()
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-20 00:12:26 +05:30
Bimal Yashodha
6e6090cf82 Tests for PMA_getHtmlForPageSaveAs()
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-19 23:39:07 +05:30
Bimal Yashodha
685f6dcc77 Unit tests for PMA_getPageIdsAndNames() and PMA_getHtmlForEditOrDeletePages()
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-19 23:26:58 +05:30
Isaac Bennetch
ff913e2855 Merge pull request #1238 from D-storm/export-back-link
fix: error in export with option view output as text
2014-06-19 12:51:08 -04:00
Chirayu Chiripal
1dd8d8c28c fix: error in export with option view output as text
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-19 17:30:50 +05:30
Chirayu Chiripal
c8a6ea0467 scrutinizer issues fix
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-19 17:10:55 +05:30
Marc Delisle
ebd19293c6 Merge pull request #1233 from smita786/gsoc_central_columns_list
add user defined column to central list
2014-06-17 14:09:29 -04:00
Smita Kumari
e373a5a029 add user defined column to central list
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

using functions from tbl_columns_definition_form.lib.php to create the add column form

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fix Coding styl

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added unit test for new function PMA_getHTMLforAddNewColumn

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

bug fix: added function to get columns count in central list

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

using functions from tbl_columns_definition_form.lib.php to edit columns in central list

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

improved test

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Bug/coding style fix

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Fix delete issue

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added missing doc element

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-06-17 22:45:23 +05:30
Chirayu Chiripal
3ea7d2b52d rfe-755: export with table/column name changes
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-16 22:41:50 +05:30
Madhura Jayaratne
521a77d8bd Merge pull request #1232 from kb-yashodha/multipages1
Complete multipages functionality in designer
2014-06-16 15:22:13 +05:30
Bimal Yashodha
48dd4f354d Remove references to designer_coords and designerwork
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-06-16 11:39:39 +05:30
Marc Delisle
f6c44d8ccb Merge pull request #1230 from smita786/gsoc_central_columns_list
PHPUnit test case for central_columns.lib.php
2014-06-14 14:27:08 -04:00
Smita Kumari
b663334c5b PHPUnit test case
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Fix coding style

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Fix coding styl

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-06-14 22:06:37 +05:30
Chirayu Chiripal
33dfef377f RFE-759 Use aliases in SQL export for tables and columns
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-06-09 22:44:07 +05:30
Marc Delisle
efde179705 Fix test
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-07 15:45:35 -04:00
Marc Delisle
060fb03afb Merge pull request #1206 from smita786/gsoc_central_columns_list
Using central list of columns : pick a column from central list
2014-06-07 15:37:42 -04:00
Smita Kumari
294e36bdb6 pick a column from central list
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

small bug fix

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added own style

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

not display column name that already exist in tabl

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added search to the pick column dialog

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Fix coding style

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

check for central columns configuration relation

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

pagination in pick coulumn dialog

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

code cleanup

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

Fix coding style

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-06-07 22:06:05 +05:30
Marc Delisle
de6ad93d24 Merge pull request #1209 from ashutoshdhundhara/rfe_1145
RFE#1145: Preview SQL instead of executing it.
2014-06-07 06:39:32 -04:00
Ashutosh Dhundhara
99b9e8d83c RFE#1145: Preview SQL instead of executing it.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-06-07 00:27:39 +05:30
Michal Čihař
21c6c2e79f Pass correct types in testsuite
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:13:48 +02:00
Michal Čihař
83073fe53c Remove duplicate variable initialization
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:12:51 +02:00
Michal Čihař
1cc4620d65 Pass correct types in testsuite
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:12:26 +02:00
Michal Čihař
666e302564 Fix indefined variables in test
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:08:40 +02:00
Michal Čihař
3e4ef11ba1 Pass correct parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:07:48 +02:00
Michal Čihař
bfadec2f2b Pass correct parameter values
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:05:26 +02:00
Michal Čihař
3e4da830ee Correctly set static properties in testsuite
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 13:01:14 +02:00
Michal Čihař
dc825e82be Correctly document parameter types
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-06-06 12:58:50 +02:00
Marc Delisle
c8e33b2a96 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:59:55 -04:00
Marc Delisle
84f135d048 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:40:21 -04:00
Marc Delisle
bd762244ec Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:27:02 -04:00
Marc Delisle
93ce1a69de Merge pull request #1195 from smita786/gsoc_central_columns_list
Gsoc central columns list
2014-05-26 15:14:04 -04:00
Smita Kumari
200737bcce gsoc:central list of columns, added sync and remove column list on db_structure page
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixing indentation in mult_submits.inc.php

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

naming convention,typos, indentaion fix and removed unnecessory file db_sync_central_columns.php

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

check if central columns storage is configured, if not configured don't show the option to sync/remove

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

add/remove columns to central list of columns from tbl_structure page

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added icon image for central columns add/delete

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

add/remove of columns option in tbl_structure page in columns rows depending upon if column is already present in central columns or not

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixed php notices, apporiprate message when a non existing column is removed and when a existing column is added to cenral list

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

documentation added for central_columns configuration

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

regenerated sprite

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

changed central_columns table structure + modified functions to add to central column as per new tbl def

updated delete and other function as per new db structure

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

remove notices

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

sprintf for variable message

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fix unit test failure errors

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixed whitespace issues plus function definition

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

refactoring code plus fixing coding style issues

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-05-26 23:13:03 +05:30
Marc Delisle
95ab00dd76 Remove unused parameter
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-26 10:18:34 -04:00
Ashutosh Dhundhara
d8134c9116 RFE#706: Multi-db privileges adding.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-05-25 19:25:36 +05:30
Marc Delisle
1a32869ba1 Merge commit 'ec29a0c' 2014-05-23 10:29:13 -04:00
Marc Delisle
20b2a3a707 Merge commit '28074d2' 2014-05-23 10:22:51 -04:00