gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
113,572 Commits 12 Branches 481 Tags 2.4 GiB
61e97801d4
Commit Graph

4058 Commits

Author SHA1 Message Date
Leonardo Strozzi
3b8746547d Fix php code sniffer errors 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-07-08 18:31:04 -03:00
Leonardo Strozzi
e95505239d Adapt table tracking main tests 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-07-08 17:55:38 -03:00
Leonardo Strozzi
7dc44b2ea9 Fix tests for server_engine 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 22:27:37 -03:00
Leonardo Strozzi
15ae8d7fe5 Refactor server_databases templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-29 16:36:36 -03:00
William Desportes
e816e45c18 phpstan level 0 (#14405) 
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
4d8310432f Fix coc comment for parameter "$include" 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-25 16:09:57 -03:00
Maurício Meneghini Fauth
2cea709661 Fix EnvironmentTest namespace issue 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-25 15:08:20 -03:00
Maurício Meneghini Fauth
ec4911d20c
Merge pull request #14415 from laps15/refactor 
Refactor database templates
 2018-06-21 18:45:37 -03:00
Isaac Bennetch
dcf434b635 Fixup from merge 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2018-06-21 14:00:03 -04:00
Isaac Bennetch
d1360f46ce Merge branch 'QA_4_8' 
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
 2018-06-21 13:54:08 -04:00
Michal Čihař
7662d02939 Avoid looking for ? when checking for file to be included 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2018-06-21 13:31:00 +02:00
Maurício Meneghini Fauth
44862584b7 Update test/ci-lint 
Now, PHP_CodeSniffer will exit with a non-zero code if any errors or warnings are found.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-21 00:55:25 -03:00
Leonardo Strozzi
414c1979c1 Change search test 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-20 22:12:13 -03:00
Maurício Meneghini Fauth
43d5c5db66 Remove $GLOBALS['dbi'] from Rte\Triggers 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 20:27:21 -03:00
Maurício Meneghini Fauth
510c11b039 Remove $GLOBALS['dbi'] from Rte\Routines 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 20:14:48 -03:00
Maurício Meneghini Fauth
66bd8b4a86 Remove $GLOBALS['dbi'] from Rte\Events 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-19 12:44:02 -03:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
5edbdf2063 Remove Template::get() method 
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 19:46:36 -03:00
Maurício Meneghini Fauth
244d4e8e81 Replace Template::get calls in libraries/classes 
Uses Template::render() instead of Template::get().

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-18 18:18:24 -03:00
Maurício Meneghini Fauth
d6cfb361b3
Merge pull request #14347 from williamdes/phpstan 
Add phpstan / finding errors in php code
 2018-06-16 02:09:17 -03:00
William Desportes
7b13da98cd
Added phpstan 
- Added phpstan/phpstan
- Added bootstrap file
- Added phpstan config
- Added ci file
- Added to CI matrix

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-15 23:18:01 +02:00
William Desportes
2f82c9c29c
Add --verbose to help debug CI failure 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-15 21:40:41 +02:00
Maurício Meneghini Fauth
2f99429917 Fix coding style errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-09 16:57:05 -03:00
Maurício Meneghini Fauth
307f3d1278 Fix test/ci-lint exit codes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-09 16:28:00 -03:00
Maurício Meneghini Fauth
f24545e633 Refactor Config/FormDisplayTemplate 
Replaces $GLOBALS['PMA_Config'] with DI

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-06 15:47:00 -03:00
Maurício Meneghini Fauth
8cad698ead Refactor FormDisplayTemplate 
Uses a class member instead of a global.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-05 23:07:16 -03:00
Maurício Meneghini Fauth
b25be9ee75 Refactor Config/FormDisplayTemplate methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-05 22:47:17 -03:00
Maurício Meneghini Fauth
cece77d831 Refactor Server/Privileges 
Replaces Template::get() with $this->template->render()

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-05 02:26:08 -03:00
Maurício Meneghini Fauth
628d27b69a Refactor Template class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-05 01:08:08 -03:00
Maurício Meneghini Fauth
463cc03f44
Merge pull request #14353 from laps15/refactor 
Refactor db central columns templates
 2018-06-04 19:10:38 -03:00
William Desportes
ffc40cc517
Replace apigen with Sami in CI 
- Removed apigen/apigen
- Added sami/sami
- Generated a configuration and added it in /test/ as config-sami.php
- Removed "apidocs" from matrix in .travis.yml

Closes: #14345
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2018-06-03 18:20:05 +02:00
Leonardo Strozzi
be673f908d Refactor db central columns templates 
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
 2018-06-03 00:34:12 -03:00
Maurício Meneghini Fauth
b101167220 Refactor libraries/config.values.php 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-06-01 01:56:25 -03:00
Maurício Meneghini Fauth
2005cca77f Fix methods and properties visibility issues 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax 
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
61a8593c7e Remove libraries/dbi/dbi_dummy.inc.php 
Move libraries/dbi/dbi_dummy.inc.php to PhpMyAdmin\Dbi\DbiDummy::init()

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-29 03:23:13 -03:00
Maurício Meneghini Fauth
66f2e4a2dc Remove $dbi global from Database classes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-22 22:46:41 -03:00
Maurício Meneghini Fauth
633f9732eb Fix some namespace errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-18 02:08:44 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
1c2b458a01 Merge branch 'QA_4_8' 2018-05-12 04:20:28 -03:00
Maurício Meneghini Fauth
b5cac84182 Fix TableSearchController::_generateWhereClause() test 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-12 04:17:45 -03:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125) 
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-12 03:54:28 -03:00
Lakshay arora
9231620c2d Fix for issues with spatial fields (#14125) 
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
 2018-05-12 03:44:58 -03:00
Maurício Meneghini Fauth
8bd91ffdaa Automatic phpcs fixes 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-12 03:14:00 -03:00
Maurício Meneghini Fauth
150888a2d6 Add type declarations to Font 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-09 22:59:09 -03:00
Maurício Meneghini Fauth
ec3583944b Refactor Font methods 
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-09 22:42:56 -03:00
Maurício Meneghini Fauth
dc72341b75 Merge branch 'QA_4_8' 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-08 07:44:19 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp() 
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-05-08 07:39:53 -03:00