Commit Graph

283 Commits

Author SHA1 Message Date
Jayati Shrivastava
f428e4eeb7
Fixes #15717 - Warning popup not dissapearing
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-02 15:44:37 +01:00
William Desportes
8033c15fe6
Fix #15722 - Get Database structure fails with PHP error on replicated server
Fixes: #15722
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-30 17:37:49 +01:00
William Desportes
ff812e9366
Fix a merge mistake
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 18:05:59 +01:00
William Desportes
3ebcf62e78
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:43:06 +01:00
William Desportes
b6e1ea68f3
Fix issue reported by Scrutinizer
It seems like ... can also be of type null; however, parameter $existrel_foreign of PhpMyAdmin\Table::updateForeignKeys does only seem to accept array

Link: https://scrutinizer-ci.com/g/phpmyadmin/phpmyadmin/inspections/72ec4952-c554-485c-b2f9-0898330b9368/issues/files/libraries/classes/Controllers/Table/RelationController.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=42062672

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:56:54 +01:00
William Desportes
dcc934b98a
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 15:26:41 +01:00
William Desportes
28d76482b8
Fix #15591 - Undefined index: foreign_keys_data
Fixes: #15591

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 14:53:21 +01:00
William Desportes
bf8939add6
Merge branch 'QA_4_9' into QA_5_0
Fixes the merge mitake done in df0543694c
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:02:57 +01:00
William Desportes
a11f0f22c8
Fix a minor error found while reviewing diffs
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:57:28 +01:00
William Desportes
df0543694c
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:54:15 +01:00
William Desportes
8aad190ae0
Fix #14951 - Moving Columns with DEFAULT NULL doesn't work on MariaDB 10.2+
Ref: 98a7479174
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:54 +01:00
William Desportes
e9ad2bc153
Fix #14951 - Moving Columns with type INT and default CURRENT_TIMESTAMP
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 23:08:08 +01:00
Maurício Meneghini Fauth
08696bc55e Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 12:51:04 -03:00
Isaac Bennetch
0de99c89e1 Merge remote-tracking branch 'security/security/279' into QA_4_9 2019-09-20 17:42:30 -04:00
William Desportes
2f2c942282
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-29 22:42:33 +02:00
R. Gurung
9d2eeb9378 Update libraries/classes/Controllers/Table/TableStructureController.php
Co-Authored-By: William Desportes <williamdes@wdes.fr>
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-29 13:25:57 +05:30
Rahul Gurung
517b47e0a0 fixed error in change button for column names with backslash
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2019-08-22 21:17:32 +05:30
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:08:28 +02:00
William Desportes
bef259c510
Fix NULL wrongly checked on field change
Pull-request: #15445

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 10:04:42 +02:00
Hugues Peccatte
98a7479174 Fix NULL wrongly checked on field change
When a field was requested to be changed, the "null" field was compared to its previous value. Unfortunately, both fields don't have the same value, so a change was always identified.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-19 18:00:18 +02:00
William Desportes
b4d3b07476
Fix #15363 - Remove unexpected quotes on text fields
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-15 22:13:17 +02:00
Maurício Meneghini Fauth
6e1bbc54c2 Retrieve dbstats from POST in server databases page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-23 16:14:14 -03:00
Maurício Meneghini Fauth
34a63c6a77 Add toArray method to Server\Plugin class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:57:53 -03:00
Maurício Meneghini Fauth
b9ec5071fe Add Server\Plugin value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:40:54 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
Maurício Meneghini Fauth
711ef54eca Add Charsets::findCollationByName method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
4fe624fa93 Remove Charsets::getCollationDropdownBox method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-25 03:32:01 -03:00
Maurício Meneghini Fauth
02766cf370 Add Charset and Collation value types
And refactor Charset class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-23 05:19:53 -03:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
William Desportes
418b50dd4e
Merge branch 'QA_4_9'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:28:19 +02:00
William Desportes
aab50ab37a
Replace $_REQUEST by $_GET and $_POST for GIS visualisation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:16:42 +02:00
William Desportes
bbac072fb5
Fix #15334 - export of GIS visualisation not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:14:52 +02:00
Maurício Meneghini Fauth
f96c41f1ab Move Template dependency as a parameter in LanguageManager
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 16:10:05 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
0feae32056 Rename Sanitize::sanitize to Sanitize::sanitizeMessage
...to avoid the PHP 4 constructor format

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 15:21:48 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
efe77cdf06 Rename js/tbl_*.js to js/table/*.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 04:09:05 -03:00
Maurício Meneghini Fauth
05ce6ffed4 Rename js/server_*.js to js/server/*.js
Rename js/server_status_*.js to js/server/status/*.js

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 03:56:22 -03:00
William Desportes
96fc4d45af
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-03 21:29:07 +02:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
2019-05-31 18:21:30 +02:00
Maurício Meneghini Fauth
dfd49d16b8 Fix ESLint warnings in js/functions.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-30 17:30:16 -03:00
William Desportes
de4bc0751b
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:20:57 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:10:57 +02:00
Maurício Meneghini Fauth
1a846baa0f
Merge pull request #15266 from Tithugues/feature/DI
External dependency injection system
2019-05-19 11:55:56 -03:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
2019-05-19 14:10:52 +02:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00