Commit Graph

134 Commits

Author SHA1 Message Date
William Desportes
aa2f369bf3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 20:27:25 +01:00
William Desportes
313da618bd
Fix redirection form secure.php.net to www.php.net
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 11:03:10 +01:00
William Desportes
293d273632
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:06:39 +01:00
William Desportes
3f9ac1dc98
Fix engine can be null
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:05:55 +01:00
William Desportes
68cfb777a5
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:37:58 +01:00
William Desportes
97ccafa06a
Add a message for misconfigured designer (displaywork)
- When adding a column as display column in designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:30:14 +01:00
William Desportes
770f30aa86
Fix display field in Designer
Introduced by: a23f2ba51a

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:29:07 +01:00
William Desportes
5a83a289d8
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 12:02:54 +01:00
William Desportes
c16891cb40
Merge branch 'QA_4_9' into QA_5_0 2019-11-09 15:41:21 +01:00
William Desportes
4ae14a3da9
Improve l10n context for translators and fix a typo
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-09 15:35:59 +01:00
Maurício Meneghini Fauth
dca01a5f77 Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 10:11:34 -03:00
Maurício Meneghini Fauth
1a2cef1ae1 Fix some coding standard issues detected by PHPCS
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 09:57:06 -03:00
William Desportes
5698fb221f
Merge branch 'QA_4_9' into QA_5_0 2019-10-18 00:13:07 +02:00
Sergi L
602cf50e52
Text-area-overflows-parent-element
Signed-off-by: Sergi Linares <sergi_linares@outlook.com>
2019-10-17 23:21:24 +02:00
Maurício Meneghini Fauth
3e330fd403 Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 17:30:44 -03:00
Maurício Meneghini Fauth
0a8fc4446b Fix some invalid array accesses with PHP 7.4
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-21 17:22:52 -03:00
William Desportes
8343320841
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 16:02:41 +02:00
William Desportes
58f56111df
Fix reloading a designer page
- Added cast to be sure pageNumber is an int -1 or postitive

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-08 11:40:13 +02:00
William Desportes
b8527d90dd
Fix typo introduced by 1af61f88b3
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 13:49:25 +02:00
William Desportes
1af61f88b3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:34:24 +02:00
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
6d0f3083ca
Fix display field can return a boolean
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:15:21 +02:00
William Desportes
a23f2ba51a
Fix some bugs with strange table and database names
- Fix export
- Fix split on . to have db and table
- Replace some $_REQUEST occurences
- Add translations to "add tables from another database" : "None" > strNone
- Refactor the ugly code that used globals to use an object "DesignerTable"
- Fix save a new added table
- Fix delete page items
- Fix more bugs

Fixes: #15446
Fixes: #13370
Fixes: #14945
Closes: #15438

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 00:55:41 +02:00
Hugues Peccatte
de57539fb7 Build "tables list" in JS
This will allow to have the list generation in only one place, as the tables can now be added on the fly. So JS also needs to add items to this list.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-21 00:01:17 +02:00
Hugues Peccatte
14ba5a1b24 Retrieve DB instead of relying on current one
When adding a table to the designer, it is useful to know the DB of this table to be able to jump to its structure.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-08-20 22:23:35 +02:00
Hugues Peccatte
04616ff7fe Import instead of using FQN
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-05 23:21:14 +02:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c9129e9bd8 Remove unnecessary string concatenation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 17:47:33 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Hugues Peccatte
ff3325870f Remove unused variables
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
422cd3ade2
Merge pull request #15258 from Tithugues/feature/use-strpos-instead-of-strstr
Use "strpos" instead of "strstr" to improve performances
2019-05-08 14:20:45 -03:00
Hugues Peccatte
69895e4bb1 Use "strpos" instead of "strstr" to improve performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:58:05 +02:00
Hugues Peccatte
4b628b6553 Replace class name as string by ":class"
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 22:56:59 +02:00
William Desportes
40cc2dc813
Fix @var comments to match the phpdoc reference
See: http://docs.phpdoc.org/references/phpdoc/tags/var.html

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 10:54:43 +02:00
William Desportes
e453ad1320
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-27 19:15:57 +02:00
William Desportes
5566aa6976
Fix #15228 - Notice - Undefined index: foreign_keys_data
Fixes: #15228
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-26 23:45:20 +02:00
William Desportes
292d2db727
Merge branch 'QA_4_8' 2019-04-01 20:46:54 +02:00
William Desportes
b6b9926a08
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:27:24 +02:00
William Desportes
a80785198d
Fix #15141 - php notice Undefined index: designer_settings
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 16:12:24 +02:00
Maurício Meneghini Fauth
21e2ca4c4c Fix some PHPStan and phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 15:17:41 -03:00
Maurício Meneghini Fauth
e49d46b277 Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-28 14:51:43 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Hugues Peccatte
9406e922cc Update PHPDoc
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 09:52:46 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00