Commit Graph

47 Commits

Author SHA1 Message Date
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:08:28 +02:00
Hugues Peccatte
0aeb0963ae Fix #15388 Allow rollback if empty statement
When statement finishes with spaces, there is an "empty" statement. An empty statement is rollbackable.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-28 21:16:50 +02:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
Maurício Meneghini Fauth
391102088f Merge branch 'QA_4_9' 2019-06-19 15:44:30 -03:00
Maurício Meneghini Fauth
1b6c564ee2 Fix a TypeError in Import class with PHP 8
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-19 15:43:52 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Hugues Peccatte
ff3325870f Remove unused variables
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Hugues Peccatte
158a13828f Remove useless unset
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
45e923d9bd
Merge pull request #15259 from Tithugues/fix/remove-unexisting-or-useless-variables
Remove use of unexisting / useless variables
2019-05-10 20:51:24 -03:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:34:57 +02:00
William Desportes
bccfdb1407
Merge branch 'QA_4_8'
- Fixed code style issues
- Merged QA_4_8 branch

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-04 22:52:49 +02:00
William Desportes
2609bff627
Merge branch 'QA_4_8' 2019-04-04 21:49:27 +02:00
Maurício Meneghini Fauth
be936acd3b Add ChangeLog entry for #13424
Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-25 17:14:44 -03:00
Joan Vega
1ea4548cd0 fix detectType: now considers cells with values like 0000123 (leading zeros) as varchar types
Signed-off-by: Joan Vega <joan@inte.es>
2019-02-08 21:45:13 +01:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-22 18:18:21 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
a1d3d334b4
Merge pull request #14855 from Tithugues/feature/reduce-nested-ifs
Reduce nested ifs
2019-01-16 02:16:38 -03:00
Hugues Peccatte
46077c33f8 Remove useless casts
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-13 01:04:59 +01:00
Hugues Peccatte
f1e140be05 Reduce nested ifs
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 23:06:04 +01:00
Hugues Peccatte
7685733389 Replace or improve use of 'for'
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-12 09:43:25 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Maurício Meneghini Fauth
b5c9c63789 Fix some uncaught type errors
Fixes #14394

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 23:14:05 -02:00
Maurício Meneghini Fauth
bf3e6c3a77 Retrieve parameters from $_POST in import
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Aswani Prakash
9274c69693 #13893 issue fix Simulating queries produce unexpected results
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
(cherry picked from commit 594cb7b1f2)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 19:33:39 -03:00
Aswani Prakash
594cb7b1f2 #13893 issue fix Simulating queries produce unexpected results
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
2018-05-16 19:29:24 -03:00
Maurício Meneghini Fauth
6cf8ee0831 Enable strict mode in some classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
000dfdf735 Add type declarations to Import
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-10 03:13:04 -03:00
Maurício Meneghini Fauth
822e04a22d Add constant visibility to Import
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-10 01:27:23 -03:00
Maurício Meneghini Fauth
1a82d6f0d2 Refactor PhpMyAdmin\Import static methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-31 21:32:18 -03:00
Gabriel Caruso
6ff73257e2 Simplify returns
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Gabriel Caruso
a8bd364e02 Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-14 22:02:17 -02:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Michal Čihař
98964e2f59 Remove is_superuser superglobal
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 12:28:00 +02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
a2b08bae7b Refactor check_user_privileges to static methods
Refactor check_user_privileges.lib.php functions to static methods and move logic to check_user_privileges.inc.php.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-11 22:09:05 -03:00
Maurício Meneghini Fauth
19e0199a36 Refactor import functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-04 22:35:55 -03:00