Commit Graph

42 Commits

Author SHA1 Message Date
William Desportes
027f39057a
Merge branch 'QA_4_9' into QA_5_0
- Fixed css img urls for designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 12:22:37 +02:00
William Desportes
9c5195d438
Fix Unit tests broken by a23f2ba51a
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-23 01:07:24 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString()
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
76d8bfdafa Merge branch 'QA_4_8'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-12 21:04:19 -02:00
Maurício Meneghini Fauth
0be9a53fcf Retrieve parameters from $_POST in db_search.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Leonardo Strozzi
414c1979c1 Change search test
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
2018-06-20 22:12:13 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
66f2e4a2dc Remove $dbi global from Database classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-22 22:46:41 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
f21bc9668d Replace static methods with instance methods
Replace PhpMyAdmin\Database\Designer\Common static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 16:39:53 -03:00
Maurício Meneghini Fauth
7f62eef8a7 Rename PmdCommon to Database\Designer\Common
Rename PhpMyAdmin\PmdCommon to PhpMyAdmin\Database\Designer\Common.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-24 16:14:44 -03:00
Maurício Meneghini Fauth
ce42c68823 Fix some coding styles issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-23 12:06:54 -03:00
Maurício Meneghini Fauth
92beb1a4f4 Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-22 23:58:41 -03:00
Maurício Meneghini Fauth
f9e4a1c6af Use template for getSearchResults method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-17 03:49:55 -02:00
Maurício Meneghini Fauth
fe91ba10f8 Remove underscores from methods and properties names
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-17 03:49:55 -02:00
Maurício Meneghini Fauth
0e82a5e83e Use template for getResultDivs method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-15 15:44:36 -02:00
Maurício Meneghini Fauth
3010b27bab Use template for _getResultsRow method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-15 11:43:35 -02:00
Michal Čihař
3b6a994dcd Move collation connection setting to user preferences
It is now handled same way as other user settings.

Issue #11688
Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 14:16:31 +01:00
Maurício Meneghini Fauth
3eed95aba0 Use template for _getFootersOptions
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-11 22:39:03 -02:00
Maurício Meneghini Fauth
6c90b384f7 Refactor _getSortSelectCell
Move 'selected' html to template.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-11 12:48:17 -02:00
Maurício Meneghini Fauth
7586c2904a Use template for _getSortSelectCell
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-11 12:35:32 -02:00
Gabriel Caruso
45828153b6 Use PSR-1 for PHPUnit TestCase
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-11-06 06:29:04 -02:00
Michal Čihař
4fe87fb592 Remove usage of $GLOBALS['controllink']
This is now stored internally inside DatabaseInterface instance.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-25 10:21:18 +02:00
Michal Čihař
56eee83f39 Remove cell_align_right superglobal
It can be replaced by proper CSS.

Issue #11731
Issue #12262

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-10 13:15:41 +02:00
Maurício Meneghini Fauth
c00245fa0a Move PMATestCase to PhpMyAdmin\Tests\PmaTestCase
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-30 16:34:53 -03:00
Maurício Meneghini Fauth
8e5885bd35 Move DbQbe to Database/Qbe
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-26 21:47:40 -03:00
Maurício Meneghini Fauth
32d6e81d52 Move DbSearch to Database/Search
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-26 20:18:23 -03:00
Maurício Meneghini Fauth
df30240015 Add namespace to test classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-20 13:03:50 -03:00
Maurício Meneghini Fauth
700e081833 Refactor plugin_interface functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-12 17:36:39 -03:00
Michal Čihař
a82f8fc768 Move databaase interface load to static method
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 14:46:56 +02:00
Maurício Meneghini Fauth
8079fd7009 Refactor db_designer functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-05 16:41:48 -03:00