Commit Graph

423 Commits

Author SHA1 Message Date
Michal Čihař
3546bed47e Avoid using mb_strlen for checking whether string is empty
Using strlen produces same results here, just way faster.

Fixes #12397

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-09-16 10:29:21 +02:00
Michal Čihař
b23dcfb456 Remove no longer used bigints javascript
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-06-09 14:33:48 +02:00
Madhura Jayaratne
7f082b0d6b This is an inc file
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2016-03-10 19:31:16 +11:00
Michal Čihař
f5393eff61 Remove code mentioning register_globals
This was removed in PHP 5.4.0 so we really do not have to care anymore.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-03-08 15:30:24 +01:00
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990
Signed-off-by: Durgesh <007durgesh219@gmail.com>
2016-02-22 14:36:41 +05:30
Piyush
1d3f8ed037 remove_msie9 (fix_11987)
Signed-off-by: Piyush Agrawal <poush12@gmail.com>
2016-02-20 12:26:54 +05:30
Marc Delisle
3c919fd63d Fix #11866 Direct calling of functions.js #11866
Signed-off-by: Marc Delisle <marc@infomarc.info>
2016-01-18 07:31:29 -05:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Hugues Peccatte
e6c142bc56 Add missing require.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-06 12:44:03 +02:00
Hugues Peccatte
6f84933a00 Add missing require.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-06 01:20:11 +02:00
Hugues Peccatte
e5e447e937 Set namespace on config classes.
Update config classes.
Add @noinspection tag.
Update documentation and script.
Set ConfigGenerator in a namespace.
Rename ConfigGenerator filename.
Remove ConfigGenerator requires.
Fix namespaces of mock objects.
Remove useless require.
Add missing 'use'.
Add missing require.
Update PHPDoc.
Fix class test typo.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:30:23 +02:00
Hugues Peccatte
f0ba28fc1d Set namespace on Advisor, Config, Console and Util classes.
Set namespace on DbQbe.
Set namespace to 'DbSearch'.
Split Advisor.class.php file.
Change Advisor namespace.
Rename DbQbe class and file.
Set namespace on DisplayResults.
Set namespace on Error.
Use namespace for ErrorHandler.
Add class autoloader.
Change ErrorHandler filename.
Remove some require.
Update Config namespace path.
Update PMA_Util to PMA\libraries\Util.
Rename Font and File classes files.
Use namespace for Footer.
Set namespace in all libraries classes.
Namespace OutputBuffering.
Export SubPartition.
Rename Partition file.
Namespace PDF.
Namespace RecentFavoriteTable.
Replace PMA_Response by Response and PMA_Message by Message.
Update uses and calls.
Fix unit tests.
Fix SqlParser autoload.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2015-09-01 21:22:52 +02:00
Madhura Jayaratne
a3217f4335 Move GIS editor out of insert form so it wont be affected by input validations
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-08-18 16:21:39 +05:30
Madhura Jayaratne
758ec7b5ae Performance improvements: Avoid expensive PMA_Table::analyzeStructure() call
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-06-05 20:20:02 +05:30
Nisarg Jhaveri
e115adb533 Page-related settings, rfe#1559
Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
2015-05-18 20:38:07 +05:30
Aayush Anand
30ba4c3cd7 Feature 763 jquery validation feature squashed
Signed-off-by: Aayush Anand <aayushism12@gmail.com>
2015-04-04 21:10:06 +05:30
Rahul Kadyan
4d308ba364 Remove unneeded closing tags
Closing tags at the end of file are not mandatory. It is often
suggested to omit to closing tags at the end of file to prevent
unwanted effects as PHP will start output buffering if there is
any character after closing tag.

Reference: http://php.net/manual/en/language.basic-syntax.phptags.php

Signed-off-by: Rahul Kadyan <hi@znck.me>
2015-03-06 23:37:35 +05:30
Hugues Peccatte
74f0beda8f Fix syntax error.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-20 20:56:12 +02:00
Marc Delisle
9d187c0df6 Refactor code duplication
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-10 08:03:25 -04:00
Hugues Peccatte
70a21ec25c Merge from master.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-10-08 21:49:37 +02:00
Marc Delisle
03debd0a6e Refactor: we had three similar functions, refactored into just one.
Also, these functions returned false, or a string containing the type,
but the string was only used to indirectly mean a true value; now
we explicitely return true in this case.

Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-10-04 08:27:50 -04:00
Hugues Peccatte
3de88162ff Replace PMA_String uses by mb_* calls.
Remove part of unused  variables.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-28 20:53:01 +02:00
Hugues Peccatte
9b77d746ab Mass modifications to use PMA_String.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-09-06 10:44:03 +02:00
Chirayu Chiripal
1be86d1062 fix parameter types
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-07 19:20:02 +05:30
Chirayu Chiripal
11ae13f177 Improve validation on insert page
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-08-04 02:19:25 +05:30
Chirayu Chiripal
1f324be4b1 RFE-637: Custom field handlers (input transformations)
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-07-12 01:52:32 +05:30
Chirayu Chiripal
c3f2abe873 FR #1487: Browse Foreign Values should be modal dialog
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-14 17:30:11 +05:30
Marc Delisle
704107c3b7 bug #3579 NOW() function incorrectly selected (regression)
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-01-22 13:28:34 -05:00
Madhura Jayaratne
ca16959719 Remove trailing white spaces 2013-10-20 10:21:34 +05:30
Dieter Adriaenssens
ad6f253869 coding style : fix indenting 2013-09-17 11:45:21 +02:00
Spun Nakandala
17ce188db4 value tab offset error corrected 2013-09-14 19:35:37 +05:30
Spun Nakandala
e60f53599d extracted methods to insert_edit.lib.php 2013-09-14 18:40:51 +05:30
Marc Delisle
a3f15a34d8 Browse foreigners did not work since commit b2e1f81c0c 2013-08-26 13:26:42 -04:00
J.M
8b110f0fea Fix minor comment typos in tbl_change.php 2013-08-18 15:42:48 +02:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Marc Delisle
0cefa33f5c The SQL term is column 2013-07-31 14:24:48 -04:00
Spun Nakandala
d828a1333b error corrected 2013-07-31 19:02:30 +05:30
Spun Nakandala
b8867ec83d added back mistakenly removed require_once statement. 2013-07-31 10:09:34 +05:30
Spun Nakandala
c0d842906c updated the comment. 2013-07-30 21:50:44 +05:30
Spun Nakandala
ccc2c840b7 can be done only once 2013-07-30 21:41:19 +05:30
Spun Nakandala
0a89da92c0 added method PMA_getUrlParameters 2013-07-30 21:38:35 +05:30
Spun Nakandala
c7604bb00e can be done in a single place 2013-07-30 21:18:01 +05:30
Spun Nakandala
783477c3da added method PMA_getCommentsMap 2013-07-30 20:59:10 +05:30
Spun Nakandala
edc2d289be transfered to PMA_determineInsertOrEdit 2013-07-30 20:51:50 +05:30
Spun Nakandala
6197aa18a8 added method PMA_determineInsertOrEdit 2013-07-30 20:29:46 +05:30
Spun Nakandala
fa23a9b14f unwanted require_once statement removed 2013-07-30 19:58:16 +05:30
Spun Nakandala
7d17bd34d7 added method PMA_getTableFields 2013-07-30 19:14:02 +05:30
Spun Nakandala
721a44f0b4 new variable used only once. So removed 2013-07-30 19:06:25 +05:30
Spun Nakandala
edfe03671f unused code segment 2013-07-30 18:43:19 +05:30
Spun Nakandala
57d1a0df73 the variable is never used. 2013-07-30 18:25:22 +05:30