Commit Graph

62 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
William Desportes
ae0577ab1e
Merge #15820 - Fix #15797 - Relation view broken
Fixes: #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa fixes url.
fixes #15797

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-19 20:06:03 +05:30
William Desportes
fd036d7f4a
Merge #15808 - Fix #15312 - added LOCK=NONE to ALGORITHM=INPLACE
Fixes: #15312
Pull-request: #15808
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 13:53:25 +01:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-17 19:44:00 -03:00
Kartik Kathuria
9054d1f673 Added LOCK=NONE
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 20:42:09 +05:30
Kartik Kathuria
a439082dba Change ALTER ONLINE to ALGORITHM=INPLACE at required position
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-01-17 13:36:06 +05:30
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
Jayati Shrivastava
f14d675308
revert change introduced by pr #15718 and fix #15718
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-12 18:46:23 +01:00
Maurício Meneghini Fauth
d0f28cef30 Refactor table pages common code
Extracts tbl_common.inc.php code to the Common::table() method and
removes the include file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:49:24 -03:00
Maurício Meneghini Fauth
cbce3a66e3 Remove the sql entry point file
Directly calls the controller instead of including the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-06 23:15:26 -03:00
Maurício Meneghini Fauth
4fcc1466d8 Refactor Table\StructureController controller
Extracts the table structure entry point logic to the controller.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-04 15:02:28 -03:00
William Desportes
c14500f323
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-02 15:50:55 +01:00
Jayati Shrivastava
f428e4eeb7
Fixes #15717 - Warning popup not dissapearing
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-02 15:44:37 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
7ac1d21c70 Fix some PHPStan level 2 errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-05 19:50:24 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
acba81e091
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:06:25 +01:00
William Desportes
bf8939add6
Merge branch 'QA_4_9' into QA_5_0
Fixes the merge mitake done in df0543694c
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:02:57 +01:00
William Desportes
df0543694c
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 20:54:15 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
William Desportes
f3bdd3521d
Merge branch 'QA_5_0' into master
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-29 22:43:40 +02:00
William Desportes
2f2c942282
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-29 22:42:33 +02:00
Maurício Meneghini Fauth
d01e1c26b9 Fix active page on navigation bar
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 15:14:17 -03:00
Maurício Meneghini Fauth
ba6bad9533 Use the router for view_create.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 00:11:04 -03:00
William Desportes
40ed155775
Merge branch 'QA_5_0' into 'master'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:09:55 +02:00
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-08-20 11:08:28 +02:00
Maurício Meneghini Fauth
71a5c660df Move sql entry points to libraries/entry_points
- sql.php -> libraries/entry_points/sql.php
- server_sql.php -> libraries/entry_points/server/sql.php
- db_sql.php -> libraries/entry_points/database/sql.php
- tbl_sql.php -> libraries/entry_points/table/sql.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-05 15:34:50 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
aec0402679 Use the router for table structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-19 20:18:06 -03:00
Hugues Peccatte
598a4db588 Use short calculation/assignation syntax when possible
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Hugues Peccatte
0d8f6a3a93 Merge isset and unset calls
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
Maurício Meneghini Fauth
0a5f24052a Use the router for the tracking pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-15 01:38:18 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
64c1b26bac
Use strict compare for booleans
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
efe77cdf06 Rename js/tbl_*.js to js/table/*.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-07 04:09:05 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
William Desportes
de4bc0751b
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:20:57 +02:00
Maurício Meneghini Fauth
1a846baa0f
Merge pull request #15266 from Tithugues/feature/DI
External dependency injection system
2019-05-19 11:55:56 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00