Commit Graph

19 Commits

Author SHA1 Message Date
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149)
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
ef385e2259
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-01 22:04:27 -03:00
Maurício Meneghini Fauth
b5a0c10687
Fix coding standard issue
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-02-01 21:28:02 -03:00
William Desportes
97edddf1ce
Add TEST_PATH for out of source tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2023-01-31 23:48:31 +01:00
Maximilian Krög
b3498a2a5e
Simpler PHPUnit 8 compatibility
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2022-11-07 01:57:59 +01:00
Maurício Meneghini Fauth
0062ce6b01
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-23 14:26:00 -03:00
Maurício Meneghini Fauth
21c36a0c06
Fix PHPUnit deprecation in RoutingTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-07-23 14:23:55 -03:00
Maurício Meneghini Fauth
eb3703882b
Move Routing::getCurrentRoute to ServerRequest
The route is retrieved from the request, so it makes sense to move the
method to the Http\ServerRequest class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-06 23:36:57 -03:00
Maurício Meneghini Fauth
9fafdbd082
Fixes Tests\RoutingTest::testGetDispatcher test
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17532.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-19 18:12:50 -03:00
Maurício Meneghini Fauth
680e59eb5f
Ignore invalid routes cache file
If the `libraries/cache/routes.cache.php` file is invalid (usually from
5.1), ignores it and try to write a new one instead of failing.

Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17522.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-05-13 21:46:17 -03:00
Maurício Meneghini Fauth
9adce40034
Extract controllers from HomeController
Extracts CollationConnectionController, GitInfoController and
RecentTablesListController controllers from HomeController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-05 00:40:18 -03:00
Maurício Meneghini Fauth
f3b79d83c0
Add PHPUnit's Covers annotation on test classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-04 23:39:26 -03:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e81146e4b3 Remove useless return annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
Maurício Meneghini Fauth
a64393e7f5 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-13 00:23:28 -03:00
William Desportes
d439fb76a7
Add RoutingTest class
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-28 10:38:11 +01:00