Commit Graph

46 Commits

Author SHA1 Message Date
William Desportes
01df1001e9
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 13:33:32 +01:00
William Desportes
379dd368c9
Fix #15986 - fatal error: Uncaught TypeError: array_flip() expects parameter 1 to be array, null given
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 13:30:54 +01:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
5e0f539d2f Fix invalid @var php doc annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
689c6567bb Fix notice in table structure
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-24 18:57:33 -03:00
Hugues Peccatte
0d8f6a3a93 Merge isset and unset calls
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
ea2d5a0d87 Rename PMA_messages JS global variable to Messages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-20 23:58:23 -03:00
William Desportes
40cc2dc813
Fix @var comments to match the phpdoc reference
See: http://docs.phpdoc.org/references/phpdoc/tags/var.html

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-01 10:54:43 +02:00
Isaac Bennetch
704f96fc31 Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-03-20 11:24:31 -04:00
Isaac Bennetch
5445d51a64 Improve grammar for a message from the validator.
Thanks mostly to Si Jie sijie123@gmail.com for raising pull request

This modifies the po files as well to prevent the string from being
marked as fuzzy.

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-03-20 11:20:08 -04:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:25:08 -02:00
Tomas Votruba
637fe6de06 [cs] remove unused brackets, clean unused property assign
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-26 17:54:40 +01:00
Tomas Votruba
bf720bad29 remove unused and fix @param, @var and @return annotation values
Signed-off-by: Tomas Votruba <tomas.vot@gmail.com>
2018-11-24 21:47:26 +01:00
Maurício Meneghini Fauth
619f9813b0 Fix uncaught TypeError in setup script
Fixes #14580

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-20 01:47:23 -03:00
Jack Cherng
d0233a047a Fix PHP 7.3 warning: "continue" in "switch" is equal to "break"
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
(cherry picked from commit 9a7a1e35b0)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-06 20:55:07 -03:00
Jack Cherng
9a7a1e35b0
Fix PHP 7.3 warning: "continue" in "switch" is equal to "break"
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
2018-08-06 02:47:26 +08:00
Maurício Meneghini Fauth
f24545e633 Refactor Config/FormDisplayTemplate
Replaces $GLOBALS['PMA_Config'] with DI

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-06 15:47:00 -03:00
Maurício Meneghini Fauth
b25be9ee75 Refactor Config/FormDisplayTemplate methods
Replaces static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-05 22:47:17 -03:00
Maurício Meneghini Fauth
010a72dc00 Use camelCase for variable names
PhpMyAdmin\Config\* classes

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-04 21:25:24 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
b6435e9ed2 Enable strict mode in Config classes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-15 01:03:57 -03:00
Maurício Meneghini Fauth
01fd301003 Use 'elseif' keyword istead of 'else if'
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:31:25 -02:00
Maurício Meneghini Fauth
1d4125f15c Add array type declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-24 23:49:59 -03:00
Maurício Meneghini Fauth
695f51034d Refactor FormDisplay.tpl functions to static methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-09-14 11:53:56 -03:00
Michal Čihař
df7f328f79 Rewrite User preferences forms as clases
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-06 11:02:07 +02:00
Michal Čihař
0b81218a10 Refactor configuration descriptions into class
This avoids loading them all into global namespace on every request.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-09-05 14:44:05 +02:00
Michal Čihař
0983378e29 Replace PMA_SETUP define by configuration variable
This way we don't need runkit for testing and it's anyway a bit cleaner
approach.

Issue #13484

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-07-12 17:35:09 +02:00
Maurício Meneghini Fauth
5e7f6a1bab Move config classes to PhpMyAdmin namespace
- Move ConfigFile to PhpMyAdmin namespace
- Move FormDisplay to PhpMyAdmin namespace
- Move Form to PhpMyAdmin namespace
- Move PageSettings to PhpMyAdmin namespace
- Move ServerConfigChecks to PhpMyAdmin namespace
- Move Validator to PhpMyAdmin namespace

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-07-09 15:16:37 -03:00