Commit Graph

193 Commits

Author SHA1 Message Date
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:18:59 +02:00
Maurício Meneghini Fauth
fc968a200d Extract method to get event scheduler status
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 22:32:01 -03:00
Maurício Meneghini Fauth
603c357d05 Refactor Database\EventsController::index method
Moves Database\Events::main into index method.
Uses DI for Events instance.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-16 19:38:50 -03:00
Maurício Meneghini Fauth
e9eff7bd25 Extract HTML from Database\Events::getEditorForm
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-14 19:51:16 -03:00
Maurício Meneghini Fauth
ec3047e627 Merge database events templates
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-14 00:35:30 -03:00
Maurício Meneghini Fauth
367df7b0a1 Remove Database\Routines::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 21:53:51 -03:00
Maurício Meneghini Fauth
bc8ca12027 Remove Database\Triggers::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 20:37:45 -03:00
Maurício Meneghini Fauth
f2c8257ab1 Remove Database\Events::setGlobals method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 20:08:43 -03:00
Maurício Meneghini Fauth
1102bdfdb7 Move Rte classes to the Database namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-13 18:26:47 -03:00
Maurício Meneghini Fauth
f4fda0cf2f Extract HTML from QBE table header
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-03 00:30:26 -03:00
Maurício Meneghini Fauth
3127eff3af Extract HTML from Qbe::_getTableFooters method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 22:56:30 -03:00
Maurício Meneghini Fauth
3381f385a9 Extract HTML from Qbe::getTablesList method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 22:15:30 -03:00
Maurício Meneghini Fauth
250d598181 Extract HTML from Qbe::getSelectionForm method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 20:28:03 -03:00
Maurício Meneghini Fauth
e9f9c27d7e Extract HTML from Qbe::_getInsDelAndOrCell method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-02 18:33:54 -03:00
Maurício Meneghini Fauth
da815fbbcc Remove radio fields HTML generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-30 16:44:46 -03:00
Maurício Meneghini Fauth
4c77d033c9 Remove secondary_tabs template
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-15 01:30:26 -03:00
Maurício Meneghini Fauth
64723d90da Rename the multi-table query route
Renames the route name from /database/multi_table_query to
/database/multi-table-query.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:04:59 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
William Desportes
74da874164
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-23 12:44:00 +01:00
William Desportes
8a0f006775
Fix php notice "Trying to access array offset on value of type bool"
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-23 12:40:11 +01:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-17 19:44:00 -03:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
Tabraiz
c6206a301d
Fix for page name already existing in designer page names
Signed-off-by: Tabraiz Malik <tabraizmalik96@gmail.com>
2020-01-12 21:35:05 +01:00
William Desportes
4512ada9eb
Fix php error when creating a relation between a table and a view in Designer
Yes, that does not make sense but it should not throw and error
"Uncaught TypeError: mb_strtoupper() expects parameter 1 to be string"

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-12 18:29:34 +01:00
William Desportes
51f292beab
Improve some params and return types marked as mixed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:33:49 +01:00
William Desportes
aa2f369bf3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 20:27:25 +01:00
William Desportes
313da618bd
Fix redirection form secure.php.net to www.php.net
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 11:03:10 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
William Desportes
5f13152857
Fix some PHPStan level 3 errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-06 09:02:41 +01:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
4e4670e9c2
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:08:27 +01:00
William Desportes
293d273632
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:06:39 +01:00
William Desportes
3f9ac1dc98
Fix engine can be null
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-23 00:05:55 +01:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
9965009cce
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:52:11 +01:00
William Desportes
68cfb777a5
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:37:58 +01:00
William Desportes
97ccafa06a
Add a message for misconfigured designer (displaywork)
- When adding a column as display column in designer

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:30:14 +01:00
William Desportes
770f30aa86
Fix display field in Designer
Introduced by: a23f2ba51a

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-20 12:29:07 +01:00