gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
118,314 Commits 12 Branches 481 Tags 2.4 GiB
697a8ca99d
Commit Graph

71 Commits

Author SHA1 Message Date
William Desportes
13b699e04a
Fix 2 phpstan errors in libraries/classes/Import.php 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-03-18 12:18:53 +01:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues 
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-01-16 18:39:42 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
William Desportes
5f13152857
Fix some PHPStan level 3 errors 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-06 09:02:41 +01:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567) 
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
William Desportes
40ed155775
Merge branch 'QA_5_0' into 'master' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 11:09:55 +02:00
William Desportes
f428277bad
Merge branch 'QA_4_9' into 'QA_5_0' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-08-20 11:08:28 +02:00
Maurício Meneghini Fauth
ea3599194e Use the router for table operations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-14 13:57:33 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
4bc08bb098 Fix some errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-31 20:59:24 -03:00
Hugues Peccatte
0aeb0963ae Fix #15388 Allow rollback if empty statement 
When statement finishes with spaces, there is an "empty" statement. An empty statement is rollbackable.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-07-28 21:16:50 +02:00
Maurício Meneghini Fauth
469fd5c05c Use the router for the database operations page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-24 02:12:15 -03:00
Maurício Meneghini Fauth
aec0402679 Use the router for table structure page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-19 20:18:06 -03:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-18 14:33:43 -03:00
William Desportes
a2268169ae
Use strict compare for count function 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-06-22 17:44:49 +02:00
Maurício Meneghini Fauth
391102088f Merge branch 'QA_4_9' 2019-06-19 15:44:30 -03:00
Maurício Meneghini Fauth
1b6c564ee2 Fix a TypeError in Import class with PHP 8 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-19 15:43:52 -03:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 13:28:22 -03:00
Hugues Peccatte
ff3325870f Remove unused variables 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-14 21:59:57 +02:00
Hugues Peccatte
158a13828f Remove useless unset 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
45e923d9bd
Merge pull request #15259 from Tithugues/fix/remove-unexisting-or-useless-variables 
Remove use of unexisting / useless variables
 2019-05-10 20:51:24 -03:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-05-11 00:53:57 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables 
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-05-11 00:34:57 +02:00
William Desportes
bccfdb1407
Merge branch 'QA_4_8' 
- Fixed code style issues
- Merged QA_4_8 branch

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-04-04 22:52:49 +02:00
William Desportes
2609bff627
Merge branch 'QA_4_8' 2019-04-04 21:49:27 +02:00
Maurício Meneghini Fauth
be936acd3b Add ChangeLog entry for #13424 
Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-03-25 17:14:44 -03:00
Joan Vega
1ea4548cd0 fix detectType: now considers cells with values like 0000123 (leading zeros) as varchar types 
Signed-off-by: Joan Vega <joan@inte.es>
 2019-02-08 21:45:13 +01:00
Maurício Meneghini Fauth
7eb2bbc102 Remove libraries/check_user_privileges.inc.php 
Replaces with CheckUserPrivileges::getPrivileges

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-22 18:18:21 -02:00
Hugues Peccatte
f06883d2a7 Remove useless parenthesis 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-20 01:23:53 +01:00
Maurício Meneghini Fauth
a1d3d334b4
Merge pull request #14855 from Tithugues/feature/reduce-nested-ifs 
Reduce nested ifs
 2019-01-16 02:16:38 -03:00
Hugues Peccatte
46077c33f8 Remove useless casts 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-13 01:04:59 +01:00
Hugues Peccatte
f1e140be05 Reduce nested ifs 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 23:06:04 +01:00
Hugues Peccatte
7685733389 Replace or improve use of 'for' 
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
 2019-01-12 09:43:25 +01:00
Maurício Meneghini Fauth
ae20364830 Upgrade phpmyadmin/coding-standard to v1.0 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-08 01:26:26 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
999b4d14f0 Fix some coding standard errors 
- Fixes array identation
- Removes empty statements

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-01-05 21:25:08 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements 
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2018-12-22 14:37:31 -02:00