Commit Graph

131 Commits

Author SHA1 Message Date
Yash Bothra
40665b1f35
Fix #15893 - broken urls in navigation
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-03-08 00:48:52 +01:00
William Desportes
18b7622b6f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-06 08:27:45 +01:00
Simon Vikstrom
e472b8bbc4
Fix "Uncaught TypeError: urlencode() expects parameter 1 to be string, int given in"
If a user creates two tables prefixed with number__... like
2020__abc
2020__cde

then phpmyadmin will group then, the key will end up being an integer instead of a string and  PHP will error out on it.

Signed-off-by: Simon Vikstrom <pullreq@devsn.se>
2020-03-06 08:18:11 +01:00
William Desportes
cd9dd3ab92
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 20:29:02 +01:00
Rahul Gurung
ac358d45ae
Fix #15810 - the modal heading
Co-Authored-by: William Desportes <williamdes@wdes.fr>
In respect for the PR owner I am only co-autor but re-did all the work.
Signed-off-by: Rahul Gurung <gurungrahul2@gmail.com>
2020-02-22 20:04:48 +01:00
Jayati Shrivastava
4186865b75 Documentation link
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-02-05 09:55:29 +05:30
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
William Desportes
95eb48fc8e
Merge #15823 - Ref #15792 - Fixed deprecated jquery selectors
Ref: #15792
Pull-request: #15823
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-22 19:10:05 +01:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Yash Bothra
98dc941ce5 #15792 Fixed deprecated :eq selector
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-01-21 01:17:01 +05:30
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
3f7204beb7 Add coding standard rule for self reference
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 23:31:20 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
851d524cf4
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-12 18:15:33 +01:00
William Desportes
502ded328e
Merge #15778 - Fix - #15773 a view named 'views' adds an expand button
Pull-request: #15778
Fixes: #15773
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-12 17:55:50 +01:00
Yash Bothra
6cac79b867 #15773 fixed unexpected grouping
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-01-12 13:13:41 +05:30
William Desportes
6650498f2e
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-10 22:00:08 +01:00
William Desportes
6981910c8c
Fix #15772 - Error code 500 during pagination in table overview
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-10 21:40:03 +01:00
William Desportes
fa01cea3f2
Add phpdoc blocks for phpstan
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 15:28:18 +01:00
William Desportes
d018fd999a
Add className to getInstanceForNewNode
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:49:47 +01:00
William Desportes
761e37eeaa
Reduce code duplication around NodeFactory calls
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:48:07 +01:00
William Desportes
51f292beab
Improve some params and return types marked as mixed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:33:49 +01:00
William Desportes
ba1e22c92b
Fix some primitive types not in lower case and add some return type hints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 13:49:03 +01:00
Maurício Meneghini Fauth
10395f9ea8 Create Table\AddFieldController controller
Moves the add field entry point logic the controller and removes the
entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-23 20:51:40 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
7ac1d21c70 Fix some PHPStan level 2 errors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-05 19:50:24 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
7f0949ad00
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:54:26 +01:00
William Desportes
5a83a289d8
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 20:31:34 +01:00
William Desportes
e070256fe4
Fix #13912 and #15123 - Tables of phpMyAdmin storage are not accessible
Fixes: #13912
Fixes: #15123

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 12:02:54 +01:00
William Desportes
1f472fb58d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-30 23:57:12 +01:00
William Desportes
cbdc5c0e83
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-30 23:52:18 +01:00
William Desportes
128d3a09a0
Fix #15540 - Uncaught TypeError: htmlspecialchars() in NavigationTree
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-30 23:47:45 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
ba6bad9533 Use the router for view_create.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 00:11:04 -03:00
Maurício Meneghini Fauth
74ac30fa55 Use the router for navigation.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-19 23:04:55 -03:00
Maurício Meneghini Fauth
13fe20c00d Use the router for the table indexes page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 23:19:01 -03:00
Maurício Meneghini Fauth
a862694bc8 Use the router for the table create page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 22:37:51 -03:00
Maurício Meneghini Fauth
3c6c087c40 Use the router for the table addfield page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-15 21:18:40 -03:00
Maurício Meneghini Fauth
616cc8d901 Use the router for the triggers page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-07 16:08:46 -03:00
Maurício Meneghini Fauth
74f8246fd5 Use the router for the database routines page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-07 01:53:31 -03:00
Maurício Meneghini Fauth
1b39e5e346 Use the router for the database events page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-06 00:57:08 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
df48b1dab4 Fix some errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-01 03:26:28 -03:00