Commit Graph

225 Commits

Author SHA1 Message Date
William Desportes
cc82f092ce
Fix MissingClosureParamType errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-29 01:08:40 +02:00
William Desportes
b8b5c026a9
Remove MissingReturnType psalm ignore
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:30:00 +02:00
William Desportes
54e0250dae
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 12:50:30 +02:00
William Desportes
62a6591d3f
Fix some phpcs issues after latest phpcs 3.5.5 release
I left the false positives unfixed: https://github.com/squizlabs/PHP_CodeSniffer/issues/2937#issuecomment-615498860
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-18 01:01:38 +02:00
William Desportes
a612229b99
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-14 23:42:06 +02:00
long76
bde460019c
fix #16078 - get unix timestamp for monitor
Signed-off-by: Gleb Borkov <long76.git@mail.ru>
2020-04-14 21:40:29 +02:00
Maurício Meneghini Fauth
d612215aab Remove dropdown field generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-30 01:59:03 -03:00
Isaac Bennetch
6efdd77483 Merge branch 'QA_5_0' 2020-03-20 22:50:16 -04:00
Isaac Bennetch
0d4c7c66a5 Merge branch 'QA_4_9' into QA_5_0 2020-03-20 22:01:14 -04:00
Isaac Bennetch
3258978c38 More escaping of username and password.
Improves upon 89fbcd7c39

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-03-18 22:16:53 -04:00
Maurício Meneghini Fauth
89fbcd7c39 Escape user and hostname when getting auth plugin
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-05 20:10:13 -03:00
William Desportes
d95e8ca4a1
Fix PHP Fatal error: Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, int given
Uncaught TypeError: htmlspecialchars() expects parameter 1 to be string, int given in libraries/classes/Server/Privileges.php:2777

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 14:00:46 +01:00
William Desportes
966e9277a6
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 00:47:55 +01:00
William Desportes
e671ee3ebb
Fix #15282 - MySQL 8.0 password syntax error when creating a replication user
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-23 00:39:06 +01:00
Maurício Meneghini Fauth
a63dbfb051 Move SysInfo classes to the Server\SysInfo namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-16 17:22:44 -03:00
Maurício Meneghini Fauth
a95d9c3e65 Extract the HTML from the subnav of Users page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-16 16:05:51 -03:00
Maurício Meneghini Fauth
fe98bf7b5c Convert submenu to the Bootstrap nav-pills
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-15 04:18:24 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
5e0f539d2f Fix invalid @var php doc annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-16 18:39:42 +01:00
William Desportes
13c3a18df7
Use more strict code after #15796
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-16 18:16:41 +01:00
Signed-off-by: Tabraiz Malik
a3fec80dfe
User Groups table to twig
Signed-off-by: Tabraiz Malik <tabraizmalik96@gmail.com>
2020-01-16 14:04:34 +01:00
William Desportes
d1e38545f3
Fix #15761 - Fix uncaught TypeError when using $cfg['ServerDefault'] = 0; on 5.1
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-15 13:57:38 +01:00
Maurício Meneghini Fauth
c5481acebf Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-14 18:54:02 -03:00
William Desportes
aa95fff919
Fix #15776 - privileges page return http 500
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-12 22:18:44 +01:00
William Desportes
6e6c3e0363
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-10 12:45:47 +01:00
Yash Bothra
7c862e5c30 #15767 fixed by changing === to !==
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-01-10 15:34:41 +05:30
Isaac Bennetch
a89f3fe750 Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-01-08 15:18:01 -05:00
Isaac Bennetch
dc1e81e6b2 Fix merge conflicts from QA_4_9 and prepare for 5.0.1
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2020-01-07 20:56:25 -05:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
William Desportes
c86acbf3ed
Fix sql injection in user exists request
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-01 13:55:06 +01:00
William Desportes
51f292beab
Improve some params and return types marked as mixed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:33:49 +01:00
Maurício Meneghini Fauth
b1328c7ad6 Create Server\UserGroupsController controller
Moves the user groups entry point logic to the controller and removes
the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-22 11:54:34 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
12db01bfc3
Merge pull request #15604 from mauriciofauth/double-quote-usage
Defines rules for double quote usage
2019-12-03 13:04:28 -03:00
Maurício Meneghini Fauth
acf37d7921 Move user password entry point to a controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-02 17:45:23 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00