Commit Graph

116 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
db642ab19e Extract HTML from Index:getHtmlFromIndexes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-29 23:43:18 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
William Desportes
8040e0367e
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-22 22:52:03 +01:00
William Desportes
3116e91498
Fix #15833 - TypeError when submitting unchanged data
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-22 22:50:02 +01:00
Maurício Meneghini Fauth
42166cac37 Remove use statements within the same namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 19:47:56 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
0b7a83dd2b Extract action from SqlController::index
Extracts the set-column-preferences action from the SqlController index
method to a new route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 17:59:55 -03:00
Maurício Meneghini Fauth
1c5cff42d3 Extract action from SqlController::index
Extracts the get-set-values action from the SqlController index method
to a new route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 16:24:54 -03:00
Maurício Meneghini Fauth
670b5ccd24 Extract action from SqlController::index
Extracts the get-enum-values action from the SqlController index method
to a new route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 15:58:04 -03:00
Maurício Meneghini Fauth
4c5b794931 Extract an action from SqlController
Extracts the get-relational-values action from the SqlController to a
new route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-18 14:33:11 -03:00
Maurício Meneghini Fauth
77d5b1d8d8 Remove extract functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-17 19:44:00 -03:00
William Desportes
51f292beab
Improve some params and return types marked as mixed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 14:33:49 +01:00
Maurício Meneghini Fauth
48e6e22d58 Create Table\RowActionController controller
Moves the table row action entry point logic to the controller and
removes the entry point file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-24 17:28:58 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
f6a17433a2 Use null coalesce operator when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:16:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
William Desportes
4534c4b519
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:44:27 +01:00
William Desportes
3ebcf62e78
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:43:06 +01:00
William Desportes
99a8b4ea4d
Fix php notice "undefined index table_create_time" when setting displayed columns on results of a view
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-24 17:35:32 +01:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
21a53cf36f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-18 23:49:52 +01:00
William Desportes
bee6f1c476
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-18 23:48:39 +01:00
William Desportes
52c17a34d2
Display the chart for no rows profiling results
Ref: #15465

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-18 23:12:43 +01:00
Shailesh Jain
f5f751f869
Fix #15465 - profiling output when the result has no rows
Fixes: #15465

Signed-off-by: Shailesh Jain <jainshailesh91@gmail.com>
2019-11-18 23:12:06 +01:00
William Desportes
9f4626eb96
Minor code improvement
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-11 21:40:19 +01:00
Hugues Peccatte
bb94bdeb2e Use is_* functions instead of gettype
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-01 22:55:56 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
2e88ed0888 Fix issue when copying a table row
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-23 19:23:59 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
4bc08bb098 Fix some errors detected by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-31 20:59:24 -03:00
Hugues Peccatte
0d8f6a3a93 Merge isset and unset calls
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-07-16 23:21:25 -03:00
William Desportes
b9217146ab
Fix multi server setup number of results selector
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 20:51:30 +02:00
William Desportes
3c74f22e89
Minor code improvements
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 18:27:36 +02:00
William Desportes
a2268169ae
Use strict compare for count function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:44:49 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
21 errors left

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
c8f84fc748 Replace is_null with identical comparison with null
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 13:28:22 -03:00
Hugues Peccatte
158a13828f Remove useless unset
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-14 21:59:57 +02:00
Maurício Meneghini Fauth
45e923d9bd
Merge pull request #15259 from Tithugues/fix/remove-unexisting-or-useless-variables
Remove use of unexisting / useless variables
2019-05-10 20:51:24 -03:00
William Desportes
42d36a75f2
Use exit; instead of exit(); because exit; is most common in codebase
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-11 00:53:57 +02:00
Hugues Peccatte
3243a9158d Remove use of unexisting variables
Remove useless variables

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-11 00:34:57 +02:00
Hugues Peccatte
69895e4bb1 Use "strpos" instead of "strstr" to improve performances
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-07 23:58:05 +02:00
William Desportes
fbd89fb882
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 17:53:24 +02:00
William Desportes
9178602e6c
Fix #14614 - "# 2014 - Commands out of sync; you can't run this command now" returned when stored procedure does not return any result set
Fixes: #14614
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-29 23:08:23 +02:00
William Desportes
aa5a18659b
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-23 09:08:01 +01:00