Commit Graph

245 Commits

Author SHA1 Message Date
William Desportes
b7af1364c6
Psalm auto fixes manualy reviewed and edited
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-28 23:18:59 +02:00
William Desportes
783381ced1
Use camel case for Util::convertBitDefaultValue
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:31:49 +02:00
William Desportes
cfb791c3be
Allow null for Util::convertBitDefaultValue function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:31:08 +02:00
William Desportes
986f639210
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:06:08 +02:00
Peter Kroon
ae640ebcce
Fix #16048 - Allow NULL as default bit value.
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 08:56:48 +02:00
Maurício Meneghini Fauth
27accdf5cc Remove BrowseUploadFileBlock HTML generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-31 22:25:24 -03:00
Maurício Meneghini Fauth
10f880bd8f Fix type error with Util::backquote
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-10 13:30:25 -03:00
CommanderRoot
ce2dd25202
Fix typo in Util.php
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-02-23 13:31:37 +01:00
CommanderRoot
8485c3e09f
Fix typo
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2020-02-23 01:24:52 +01:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:06:52 +01:00
William Desportes
9ed31d6fa1
Fix #15830 - strftime issue on windows for Japanese users
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 14:50:38 +01:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
Jayati Shrivastava
aadade55ce
Fix #15795 - Broken link on "MySQL said"
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-02-12 22:35:34 +01:00
William Desportes
349a2f17bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-11 23:43:04 +01:00
William Desportes
71a02a92d4
Fix edge cases on #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Ref: 6729c89b17 (r37198800)
Ref: 6729c89b17 (r37198800)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-11 23:42:15 +01:00
William Desportes
504af564ab
Merge #15916 - Improve documentation URLs
Pull-request: #15916
Fixes: #14947
Fixes: #15790
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-09 18:21:34 +01:00
William Desportes
954abc9d6e
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-07 16:17:30 +01:00
William Desportes
6729c89b17
Fix php notices on #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Ref: 3db8949ad3 (commitcomment-37079212)
Fixes: 3db8949ad3

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-07 16:12:12 +01:00
Jayati Shrivastava
4186865b75 Documentation link
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-02-05 09:55:29 +05:30
William Desportes
c0ef2b8a4d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-25 21:12:00 +01:00
corey buckley
fcb451d70b
Tests added for convertBitDefaultValue. Consider valid database names with single quotes. Change regex to only replace if digits between b'..'
Signed-off-by: Corey Buckley <coreybuckley13@gmail.com>
2020-01-25 21:00:53 +01:00
Corey Buckley
07c4a73eb0
Changes trim to regex in convertBitDefaultValue
Fixes the issue described in #15831.

Signed-off-by: Corey Buckley <coreybuckley13@gmail.com>
2020-01-25 20:59:16 +01:00
William Desportes
d042b6e2bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:25:07 +01:00
William Desportes
3db8949ad3
Fix #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Fixes: #15200
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:56:55 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
249ee4dbd2
Improve JS and phpdoc by removing useless spaces
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-16 18:39:42 +01:00
Yash Bothra
4d4cb09037
#15780 fixed action links UI
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-01-15 00:18:41 +01:00
Jayati Shrivastava
9cae108c11
Fix #15693 - tab focus using refresh button
Fixes #15693
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-02 16:12:10 +01:00
William Desportes
cd7504b2a2
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-31 12:03:51 +01:00
William Desportes
609cd722e9
Fix #15725 - error 500 when exporting - set time limit
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-31 12:00:25 +01:00
William Desportes
9799dfc643
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 15:46:26 +01:00
William Desportes
de652cd95a
Add some typecasts to fix #15719 and other possible issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 15:39:04 +01:00
William Desportes
ba1e22c92b
Fix some primitive types not in lower case and add some return type hints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-29 13:49:03 +01:00
William Desportes
28e2814ee9
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 21:04:39 +01:00
William Desportes
aa2f369bf3
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 20:27:25 +01:00
William Desportes
313da618bd
Fix redirection form secure.php.net to www.php.net
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-12-21 11:03:10 +01:00
Maurício Meneghini Fauth
04b72cf560 Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-17 22:39:13 -03:00
Maurício Meneghini Fauth
4cbcf4889b Fix TypeError in Util class
TypeError: str_replace() expects parameter 3 to be string or array, int given

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-17 22:37:14 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
e8c5ba4f80 Convert Messages to Bootstrap Alerts
Replaces Messages custom styles with a Bootstrap Alerts theme

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 15:28:47 -03:00
William Desportes
a845d2fbe5
Fix phpcs issue introduced by PR #15556
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-10 21:11:17 +01:00