Commit Graph

103 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
ae0d7127e0 Extract the drop_db action from mult_submits
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-04-20 20:00:52 -03:00
Maurício Meneghini Fauth
0721fbbc1e Fix Server/Status/AdvisorControllerTest tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 13:27:18 -03:00
Maurício Meneghini Fauth
e656f341ef Redesign the server status advisor page
Uses an accordion instead of a table to show the issues.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-13 02:56:16 -03:00
Maurício Meneghini Fauth
1a3416da8d Add support for Bootstrap modals
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-12 20:33:48 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
59ce2dbd67 Fix MonitorControllerTest
Fixes Server\Status\MonitorControllerTest when runned in isolation.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 22:46:27 -03:00
Maurício Meneghini Fauth
08afb43653 Remove replication.inc.php file
Extracts the replication.inc.php code to the ReplicationInfo class and
removes the file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-07 14:31:46 -03:00
Maurício Meneghini Fauth
3f522e8ae2 Fix some tests when running them in isolation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 21:16:30 -03:00
Maurício Meneghini Fauth
62eecc8f5d Fix Server\Status\MonitorControllerTest tests
Adds missing $response->setAjax(true) calls.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-26 14:10:08 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
Maurício Meneghini Fauth
8a0aa251fe Replace some custom CSS utilities with Bootstrap equivalents
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 19:35:37 -03:00
Maurício Meneghini Fauth
e8c5ba4f80 Convert Messages to Bootstrap Alerts
Replaces Messages custom styles with a Bootstrap Alerts theme

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 15:28:47 -03:00
Maurício Meneghini Fauth
bad2b8eca9 Move server variables entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-27 15:21:59 -03:00
Maurício Meneghini Fauth
ed6d079f25 Move server status entry point logic to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 14:54:26 -03:00
Maurício Meneghini Fauth
6dd961c8f3 Refactor server engines entry point
Moves server engines entry point logic to the routes files and moves the
request parameters to the route parameter.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:55:54 -03:00
Maurício Meneghini Fauth
9372bae319 Move server collation entry point to routes.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-26 12:15:29 -03:00
Maurício Meneghini Fauth
3814d88e2c Refactor server binlog entry point
Moves entry point logic to the routes file.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-21 11:05:12 -03:00
Maurício Meneghini Fauth
87c1133fb1
Merge pull request #15466 from mauriciofauth/entry-points-refactor
Refactor the server databases entry point
2019-10-13 13:34:35 -03:00
Maurício Meneghini Fauth
441a33d1fc Merge branch 'QA_5_0' 2019-10-05 12:10:02 -03:00
Maurício Meneghini Fauth
4bb1a2d80e Fix missing version key on AdvisorControllerTest
Related to 88821f8248

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-10-05 12:07:04 -03:00
William Desportes
d33122867f
Merge branch 'QA_5_0' into master 2019-09-22 20:14:45 +02:00
William Desportes
bbf94a7f40
Merge branch 'QA_4_9' into QA_5_0
Pull-request: #15457
Closes: #15457
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-09-22 20:13:09 +02:00
Maurício Meneghini Fauth
0c99e03a1e Refactor the server databases entry point
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-09 22:45:56 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
59f411639f Use the router for the server status variables page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 17:06:16 -03:00
Maurício Meneghini Fauth
31db3b7e42 Use the router for the server status processes page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-12 14:26:06 -03:00
Maurício Meneghini Fauth
5500f9b170 Use the router for the server binlog page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-08 02:39:15 -03:00
Maurício Meneghini Fauth
4537dcc774 Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-20 18:16:08 -03:00
Maurício Meneghini Fauth
e8c51f936d Use the router for the server_variables.php page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-12 21:10:24 -03:00
Maurício Meneghini Fauth
cda99ea57f Use the router for the server_engines.php page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-09 21:51:49 -03:00
Maurício Meneghini Fauth
b9ec5071fe Add Server\Plugin value object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-02 00:40:54 -03:00
Maurício Meneghini Fauth
064e5eef0a Use Collation value object when possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 23:01:30 -03:00
Maurício Meneghini Fauth
711ef54eca Add Charsets::findCollationByName method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-28 02:17:57 -03:00
Maurício Meneghini Fauth
02766cf370 Add Charset and Collation value types
And refactor Charset class

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-23 05:19:53 -03:00
Maurício Meneghini Fauth
d74fca7cad Remove old DI container in VariablesControllerTest
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-15 22:22:35 -03:00
Maurício Meneghini Fauth
2033507ce4 Remove old DI container in db structure controller
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-15 22:09:51 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Hugues Peccatte
9abd308837 Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-06-01 15:13:41 -03:00
Hugues Peccatte
380707fbcd Define controllers as services in an external configuration file
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-05-19 01:54:44 +02:00