Commit Graph

57 Commits

Author SHA1 Message Date
William Desportes
b411c64adc
Fix testAuthError after merge of #16066
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-05 16:02:29 +02:00
William Desportes
e225229638
Fix testAuthError after merge of #16011
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-03-10 21:34:18 +01:00
Maurício Meneghini Fauth
cd009f8ede Use Bootstrap list group for the home page lists
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-14 16:27:30 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 20:22:37 -03:00
William Desportes
3311c089c4
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 21:25:25 +01:00
William Desportes
af100abddf
Add more tests for testCookieDecrypt
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-07 19:07:27 +01:00
Maurício Meneghini Fauth
73c1ff9875 Fix Plugins/Auth/AuthenticationCookieTest.php
Related to commit 9f32a895b5.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
(cherry picked from commit 39770eec88)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-17 22:52:34 -03:00
Maurício Meneghini Fauth
39770eec88 Fix Plugins/Auth/AuthenticationCookieTest.php
Related to commit 9f32a895b5.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-17 20:16:20 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
e8c5ba4f80 Convert Messages to Bootstrap Alerts
Replaces Messages custom styles with a Bootstrap Alerts theme

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 15:28:47 -03:00
William Desportes
519aeadbc8
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-03 15:58:13 +01:00
William Desportes
c7f7f9c6c0
Merge branch 'QA_4_9' into QA_5_0
Revert: 45d46a6316

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-03 15:52:51 +01:00
William Desportes
09464ba8f5
Fix unit tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-30 00:06:12 +01:00
William Desportes
89feb6ecc3
Fix setUp function not in camel case
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-19 21:17:06 +02:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dd95a34b3a Add route parameter to index.php links
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 17:37:53 -03:00
Maurício Meneghini Fauth
4077c61b2e Remove support for target URL param for FAQ 1.34
Use the route parameter instead.

https://docs.phpmyadmin.net/en/latest/faq.html#faq1-34

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-26 12:23:01 -03:00
Maurício Meneghini Fauth
a2308ee965 Extract HTML from login form
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-21 21:10:47 -03:00
Maurício Meneghini Fauth
4537dcc774 Fix failing tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-20 18:16:08 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Isaac Bennetch
e73c92d92d Fix merge conflicts
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
2019-06-04 11:47:25 -04:00
Maurício Meneghini Fauth
015c404038 Retrieve parameters from $_POST in AuthenticationCookie plugin
Retrieves pma_username and pma_password parameters from $_POST instead of $_REQUEST

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-01 15:50:33 -03:00
Maurício Meneghini Fauth
ce71901de5 Refactor js/functions.js to use a module
Adds Functions module in js/functions.js to reduce the number of global variables.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-22 17:44:21 -03:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-24 02:25:48 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString()
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
38e5b12c1c Define an absolute path to use for require statements
Fixes #6167

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-22 14:37:31 -02:00
Maurício Meneghini Fauth
ef5d7dd66b Use Bootstrap buttons component
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 01:01:12 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
12dfaafa31 Fix Plugins/Auth/AuthenticationCookieTest tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-08-15 23:27:45 -03:00
Lakshay arora
9d2ebe7b79 Fix tests, remove use of cookie pmaUserHashed.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-08-06 16:39:33 +05:30
Maurício Meneghini Fauth
2d58411bee Some coding style fixes
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-06-18 21:30:06 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
baf0985e5f Fix phpcs errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8 Enable strict mode in test files
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Gabriel Caruso
d0b3ca5d48 Refactoring tests
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2017-12-12 06:46:53 -02:00
Maurício Meneghini Fauth
c930c7a030 Fix coding standard errors
Automatic fixes by phpcbf.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-04 13:40:36 -02:00
Michal Čihař
3b6a994dcd Move collation connection setting to user preferences
It is now handled same way as other user settings.

Issue #11688
Issue #13466

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 14:16:31 +01:00
Michal Čihař
0ccaf0ac91 Use templates for rendering header and footer of login page
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-30 14:40:44 +01:00
Scrutinizer Auto-Fixer
40f56c0a95 Remove not needed use statements
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-23 18:49:37 +02:00
Michal Čihař
6619fe9196 Check return value from cookieDecrypt
This can return false and we should fail early once this happens.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-10-20 19:44:28 +02:00