Commit Graph

121 Commits

Author SHA1 Message Date
William Desportes
986f639210
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:06:08 +02:00
William Desportes
aab8c19731
Fix #16048 - Add a test case for NULL as default bit value.
Ref: #16063

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-03 09:00:57 +02:00
William Desportes
9a8e311a76
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:06:52 +01:00
William Desportes
9ed31d6fa1
Fix #15830 - strftime issue on windows for Japanese users
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 14:50:38 +01:00
William Desportes
0455dab6bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 11:40:12 +01:00
William Desportes
1e384979ad
Fix ja translation detection for data depending on translations
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-15 11:06:29 +01:00
William Desportes
517222ff59
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
William Desportes
796e24cc9c
Fix tests for #15830 - set back locale to 'en' and add test case
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:46:08 +01:00
William Desportes
e0074f053a
Improve tests for #15830 and fix coding standard errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:32:05 +01:00
William Desportes
190ad754bc
Improve tests for #15830
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:29:47 +01:00
William Desportes
349a2f17bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-11 23:43:04 +01:00
William Desportes
71a02a92d4
Fix edge cases on #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Ref: 6729c89b17 (r37198800)
Ref: 6729c89b17 (r37198800)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-11 23:42:15 +01:00
William Desportes
954abc9d6e
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-07 16:17:30 +01:00
William Desportes
6729c89b17
Fix php notices on #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Ref: 3db8949ad3 (commitcomment-37079212)
Fixes: 3db8949ad3

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-07 16:12:12 +01:00
William Desportes
c0ef2b8a4d
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-25 21:12:00 +01:00
corey buckley
fcb451d70b
Tests added for convertBitDefaultValue. Consider valid database names with single quotes. Change regex to only replace if digits between b'..'
Signed-off-by: Corey Buckley <coreybuckley13@gmail.com>
2020-01-25 21:00:53 +01:00
William Desportes
d042b6e2bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:25:07 +01:00
William Desportes
3db8949ad3
Fix #15200 - server-side HTTPS detection misses support for Forwarded HTTP Extension (RFC 7239)
Fixes: #15200
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:56:55 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Hugues Peccatte
3255e4ad7b Split Util class regarding the responsabilities (#15567)
PhpMyAdmin\Util is a very huge class with a lot of responsabilities.

There is a lot of work to split it, but this may be just a small start, waiting for a more normalized code.

* Split Util class regarding the responsabilities
* Split the buttonOrImage function

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-21 20:20:05 -03:00
William Desportes
a9df8a4dbb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-05 23:15:34 +01:00
William Desportes
9e90099ffa
Merge branch 'QA_4_9' into QA_5_0
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-11-05 23:10:52 +01:00
Hugues Peccatte
164c15854d Add unit tests for Util::isInteger
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-03 20:51:54 +01:00
Hugues Peccatte
69a4061441 Refactor duplicated methods
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2019-11-01 19:20:15 +01:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dc7372fb99 Fix URL query issues with Util::getScriptNameForOption
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-22 17:30:18 -03:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-18 14:33:43 -03:00
Maurício Meneghini Fauth
e1f9ae00cd Add a trailing comma in multi-line arrays
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-14 14:09:26 -03:00
Maurício Meneghini Fauth
c9129e9bd8 Remove unnecessary string concatenation
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 17:47:33 -03:00
Maurício Meneghini Fauth
c049dfa7a6 Replace alias functions with their respective functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 14:49:47 -03:00
William Desportes
fbd89fb882
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 17:53:24 +02:00
William Desportes
3399e5babd
Fix spatial functions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 11:11:28 +02:00
William Desportes
252aebef48
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 23:37:53 +01:00
William Desportes
c1c22ff32f
Fix style issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 22:48:08 +01:00
William Desportes
76cbe9f961
Merge branch 'QA_4_8'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-26 21:05:09 +01:00
William Desportes
9dd940c58a
Fix whitespace
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-24 18:35:37 +01:00
Anton Mokrousov
e41af9d6df Fixed issue #15077
Signed-off-by: Anton Mokrousov <settingx@mail.ru>
2019-03-24 21:36:25 +07:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString()
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
1532675036 Fix Util::formatNumber tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-15 16:01:21 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
9eba565bf4 Remove unnecessary HTML closing tags
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-19 00:12:54 -02:00
Maurício Meneghini Fauth
d7affca556 Fix uncaught TypeError in Util::printableBitValue
Fixes #14718

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-12 21:50:42 -02:00
Maurício Meneghini Fauth
c04982d5c5 Upgrade PHPUnit to v7
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-03 20:47:45 -03:00