Commit Graph

221 Commits

Author SHA1 Message Date
William Desportes
3a7e20b825
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-29 00:30:35 +01:00
William Desportes
4c5fe772b9
Mark tests as passed on BrowserStack
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 23:52:39 +01:00
William Desportes
0d3e6c1603
Fix phpdoc block
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 23:19:48 +01:00
William Desportes
26d315b5e5
Find an alternative to make scrolling work on testDropTable
Ref: https://github.com/php-webdriver/php-webdriver/issues/773
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:08 +01:00
William Desportes
5e43765058
Add access to console logs from chromedriver
Add logging for chrome driver https://stackoverflow.com/a/53305034/5155484

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:08 +01:00
William Desportes
3e6326a4be
Stop webdriver session when the test failed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:07 +01:00
William Desportes
29306ee18b
Add scrollToElement function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-27 22:59:06 +01:00
Maurício Meneghini Fauth
922cd6bd69 Fix some Selenium tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-19 10:25:02 -03:00
William Desportes
9d595f8d0b
Fix some issues reported by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 23:28:20 +01:00
William Desportes
ca5a54d3f1
Rename CAPABILITY to CAPABILITY_W3C because it is deprecated
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 23:36:49 +01:00
William Desportes
d042b6e2bb
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:25:07 +01:00
William Desportes
fb134b0380
Catch MySQL connection error on unit tests
Fixes: https://github.com/phpmyadmin/scripts/issues/22
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 23:08:54 +01:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
585fdaea5a Fix PHP doc spacing and order
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 18:07:37 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
80a3c50bf5 Remove some useless if conditions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 20:43:57 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
055087c063 Convert serverinfo bar to Bootstrap's breadcrumbs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-30 13:43:42 -03:00
Maurício Meneghini Fauth
fdeb75b6cb Move WebDriver Maximize method to TestBase setUp
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 17:03:43 -03:00
Maurício Meneghini Fauth
1c9062ccd3 Move check relations entry point to routes file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-06 21:11:21 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dd3753b8f1 Remove namespace in Selenium tests
To improve readability.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-25 17:48:56 -03:00
Maurício Meneghini Fauth
277bf0715f Use the router for check relations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-19 20:28:08 -03:00
William Desportes
d9f2428032
Remove unused imports and fix an error reported by Scrutinizer 2019-06-22 17:55:58 +02:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
a6e53e2022 Replace get_class($this) and __CLASS__
with static::class and class name

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-11 22:54:10 -03:00
Maurício Meneghini Fauth
0b3014207d Use camel case for most of the js/functions.js variables
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-27 00:55:10 -03:00
Maurício Meneghini Fauth
6bd2dbd5f2 Add support for PHPUnit 8
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
25e480666e Fix doc comments alignment
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804 Format array declarations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12 Adds space after not (!) and type cast
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac Fix some coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
William Desportes
f0b51c144f
Remove unused code in tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Lakshay arora
2a07cee164 Automatically add index while editing an existing row and setting auto increment (#14417)
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.

Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-10-23 16:33:36 -03:00
William Desportes
ea830e70b3
Try multiple browsers
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:38 +02:00
William Desportes
862788d782
Migrate tests to facebook/webdriver
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:06 +02:00
William Desportes
d9153ae069
Add TESTSUITE_PORT for selenium tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:05 +02:00
William Desportes
e816e45c18 phpstan level 0 (#14405)
* Fix phpdoc @return

- Fixed @return typehint

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix incorrect case on function calls

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Type hint + typo fix

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fixes

- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
-  libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor  libraries/classes/Error.php

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Access to an undefined property

- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Update config

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix bootstrap-phpstan

Signed-off-by: William Desportes <williamdes@wdes.fr>

* Fix typos and phpstan config

Fixes: #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
285e38e931 Fix some PSR-2 coding standard errors
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96 Use short array syntax instead of long array syntax
Replaces array() with [].

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00