gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
126,270 Commits 12 Branches 481 Tags 2.4 GiB
6a2c12bdc8
Commit Graph

1445 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
6a2c12bdc8
Add missing traversable type hints 
Replace array type hint with mixed[] type hint, since it means the same.
This way it's possible to require traversable type hint for new code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-04-02 01:32:12 -03:00
Liviu-Mihail Concioiu
d9e0b9d7e7
Fix move columns (#18271) 
Fix #18232 - Fix issues when moving a column

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Co-authored-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-29 17:23:52 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
52c14a1911
Fix wrong global variable name 
Introduced by 437215cab2

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-27 12:42:13 -03:00
Maurício Meneghini Fauth
e5698c85e9
Require single line for function calls 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 23:10:10 -03:00
Maurício Meneghini Fauth
437215cab2
Rename variables to use camel case format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-26 21:47:50 -03:00
Maurício Meneghini Fauth
802d8f13b6
Merge pull request #18203 from kamil-tekiela/first-class-callable 
Use first class callables
 2023-03-25 15:16:07 -03:00
Maurício Meneghini Fauth
c7855f6e95
Create the PhpMyAdmin\Replication namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-20 14:16:01 -03:00
Kamil Tekiela
8eb023bcce Remove last public use of Tracker::isTracked 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:36:25 +00:00
Kamil Tekiela
924fcc79f9 Refactor logic for getting Tracking status 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:36:21 +00:00
Kamil Tekiela
ebbf2e8d01 Remove unused params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:35:34 +00:00
Kamil Tekiela
c0b367cc57 Create Tracking namespace 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 22:35:32 +00:00
Kamil Tekiela
3ecf14df34 Fixing erroneous params 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:47:43 +00:00
Kamil Tekiela
3774c29604 Fix implicit nulls 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Kamil Tekiela
555c6798eb Add native param types 
Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-17 12:45:18 +00:00
Maurício Meneghini Fauth
e24d2201c5
Merge pull request #18218 from MoonE/gis-visualization-settings 
Refactor GisVisualization settings
 2023-03-15 15:16:57 -03:00
Kamil Tekiela
2597a13c71
Refactor getItemUnhideDialog() (#18244) 
* Refactor getItemUnhideDialog()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove tableName completely

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace escapeString with quoteString

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-15 14:46:31 -03:00
Kamil Tekiela
34ad6b7ac4 Fix useSqlBackquotes in ExportSql 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-14 19:37:16 +00:00
Maurício Meneghini Fauth
10e1a848ed
Add support for theme color modes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-13 23:28:29 -03:00
Maximilian Krög
e8e877b662
Small change to urlParams and errorUrl globals initialization 
Default to emtpy array for urlParams, remove null initialazation for
errorUrl.

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
c24e1674c1
Extract method getVisualizationSettings 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
3891f2bca2
Add and use getters for GisVisualization properties 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
a64fbedb3f
Rename / refactor useBaseLayer option 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
975305398b
Remove settings and userSpecifiedSettings properties 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
2f428e5c93
Extract getRows and getPos methods 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
d2560e793d
Extract getColumnMeta method 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
21b81ad04e
Extrace getSqlQuery method 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:19 +01:00
Maximilian Krög
07388c10a7
Remove default width / height 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:53:17 +01:00
Maximilian Krög
6b9f0d8441
Add pos and rows properties 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:52:49 +01:00
Maximilian Krög
b656f09713
Move db version checks into GisVisualization 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-13 21:52:22 +01:00
Maurício Meneghini Fauth
865c46e320
Move Theme and ThemeManager into the Theme namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-13 10:25:48 -03:00
William Desportes
e8b1437fff
Merge #18225 - Make database and web server info separately configurable on $cfg['ShowServerInfo'] 
Pull-request: #18225

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-03-10 16:22:15 +01:00
William Desportes
ab5fc856ad
Merge branch 'QA_5_2' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2023-03-10 16:18:27 +01:00
Erki Aring
b7ce755f07 Make database and web server info separately configurable 
Signed-off-by: Erki Aring <erki@example.ee>
 2023-03-10 10:12:24 +02:00
Maximilian Krög
fa7ec73dd2
Make sure a spatial column is available 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-05 15:29:19 +01:00
Maximilian Krög
d7003fbbe8
Remove visualization property from controller 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-03-05 15:29:19 +01:00
Maurício Meneghini Fauth
d19ebcf9b8
Add context for date/time related translations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-03-04 10:44:22 -03:00
Kamil Tekiela
20a246203f Clean up is_foreign_key_supported 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-03 21:52:19 -03:00
Kamil Tekiela
525009b2fd Remove localised_date Twig extension 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-03 20:42:27 -03:00
Kamil Tekiela
142f15f373
Use quoteString in controllers (#18191) 
* CreateController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* FindReplaceController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* SetVariableController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* GetVariableController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* UserGroupsFormController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* TablesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-03 17:40:45 -03:00
Kamil Tekiela
e71b8c2030 Use first class callables 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-03-02 23:00:43 +00:00
Kamil Tekiela
7b20f58a0c Bug: IS NULL is shown for non-nullable columns 
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 23:17:53 +00:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] (#18149) 
* Remove $GLOBALS['PMA_PHP_SELF']

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove $GLOBALS['PMA_PHP_SELF'] from tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Moved cleanupPathInfo to Routing

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove parse_url from getRootPath

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove invalid tests

Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix trailing slash in path

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-27 17:56:27 -03:00
Maurício Meneghini Fauth
342ab3f67a
Merge branch 'QA_5_2' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-27 14:36:32 -03:00
Kamil Tekiela
0bdcaba2d2
Add native property types (#18143) 
* Add native property types

Includes TypeHints.UnionTypeHintFormat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Set some default values for properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Format and promote properties

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove redundant asserts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant cast

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $tmanager->theme is never null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix empty on $statementInfo bool

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant issets

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* getPacked() returns nullable string

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Redundant if

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $this->content can be null

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify ThemeManager::getInstance()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use isset for checking if property is initialized

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use nullable instead of uninitialized property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* password is no longer nullable

I can't verify that none of the globals ever tried to set it to null, but the variable should never be nullable.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update baselines

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* $same_wide_width param can be float or int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Update Message.php

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Cast Sub_part to int

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix one line doc comments

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
 2023-02-26 23:30:41 -03:00
Maximilian Krög
4f76f8eb32
Only create one GisVisualization object 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-25 04:40:36 +01:00
Maximilian Krög
3417030100
Remove globals usage in GisDataEditorController 
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
 2023-02-25 04:40:35 +01:00
Maurício Meneghini Fauth
556594b4cd
Fix coding standard spacing issues 
- Fixes one line doc comments
- Fixes parent call spacing
- Fixes constant spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 21:06:17 -03:00
Maurício Meneghini Fauth
77957a69a5
Add trailing comma for multi-line functions 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2023-02-24 20:48:46 -03:00
Maurício Meneghini Fauth
2137664f82
Merge pull request #18116 from kamil-tekiela/Remove-strlen 
Remove strlen when used in a condition
 2023-02-24 20:20:12 -03:00