Commit Graph

280 Commits

Author SHA1 Message Date
Hugues Peccatte
5306fcc9c6 Minor coding style fixes.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2014-05-08 21:51:24 +02:00
Michal Čihař
b8e488354e This variable is not used anywhere
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:34:18 +02:00
Michal Čihař
6061e38e1e Use class attribute instead of passing the value as parameter
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:31:20 +02:00
Michal Čihař
f7c4c28ed2 Store boolean values not 1 or 0 for boolean types
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:29:55 +02:00
Michal Čihař
b3f177ee98 Pass correct parameters to PDF schema methods
All these take string as a parameter not a boolean values (as returned
isset).

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:24:17 +02:00
Michal Čihař
1ce78f82d3 Define property before using it
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:20:06 +02:00
Michal Čihař
0b1029835b Fix parameter type
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:19:12 +02:00
Marc Delisle
b9b013a11b Merge commit 'dcb18ef' 2014-03-25 06:18:41 -04:00
Marc Delisle
cb3929766a Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-03-25 06:18:21 -04:00
Michal Čihař
dcb18efddc Do not offer PDF export if TCPDF is not present
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-25 08:36:01 +01:00
Michal Čihař
186a80939d Allow TCPDF to be removed
We currently require TCPDF to be present, but in most cases this is
feature which users do not need and thus can reduce size of installed
phpMyAdmin.

Also this is helpful for Linux distributions as they can provide soft
dependency on tcpdf package.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-24 16:12:13 +01:00
Michal Čihař
ce11dff6ef Avoid double checks for direct execution of a script
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-24 11:59:14 +01:00
Bimal Yashodha
ae7830985f Correct spelling mistakes
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-03-21 07:11:27 +05:30
Bimal Yashodha
b362d0e8b6 Move getTitle() method to parent class
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-03-20 22:48:22 +05:30
Bimal Yashodha
ccde0e70bd Rename the field to its old value
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-03-19 23:08:22 +05:30
Bimal Yashodha
860aa89510 Update references to new variable names
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-03-19 19:33:24 +05:30
Bimal Yashodha
ac91ba03c5 Refactor - Move duplicate code to a parent class
Signed-off-by: Bimal Yashodha <kb.yashodha@gmail.com>
2014-03-17 20:16:32 +05:30
Marc Delisle
749eba0390 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-03-07 12:47:40 -05:00
Madhura Jayaratne
74aebe629b Spaces around . operator
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 18:06:02 +05:30
Madhura Jayaratne
84e9ce4946 Spaces around . operator
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-01-08 17:26:27 +05:30
Hugues Peccatte
207466d59c Don't use function in for loop test.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-18 22:18:02 +01:00
Madhura Jayaratne
7cf1a744a7 Fix coding style
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2013-12-18 11:22:58 +05:30
Hugues Peccatte
7bd1bf23d3 Fix PHPCS errors.
Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
2013-12-11 22:13:10 +01:00
Hugues Peccatte
2274453717 Minor PHPDoc modifications. 2013-12-07 19:00:53 +01:00
Dieter Adriaenssens
0fe2acc424 Merge branch 'master' into string_width
Conflicts:
	test/classes/schema/Svg_test.php
2013-11-28 16:32:49 +01:00
Hugues Peccatte
473d3cd4a2 PHPDoc update. 2013-11-11 18:12:46 +01:00
Hugues Peccatte
d3601abf96 Global PHPDoc update. 2013-11-10 12:29:55 +01:00
Madhura Jayaratne
20608589c3 Remove trailing white spaces 2013-10-19 14:29:05 +05:30
Dieter Adriaenssens
2569fee671 move duplicate getStringWidth method to seperate class 2013-09-27 21:32:12 +02:00
Dieter Adriaenssens
06a98db530 fix typo 2013-09-27 18:45:47 +02:00
Dieter Adriaenssens
ab5d73a6f6 reformat PMA_SVG::getStringWidth 2013-09-27 18:44:52 +02:00
Dieter Adriaenssens
32fc5933ac wrap long lines 2013-09-27 16:53:39 +02:00
Dieter Adriaenssens
8b77c7c119 cleanup mixed php and html 2013-09-27 13:21:54 +02:00
Dieter Adriaenssens
410c484933 cleanup mixed php and html 2013-09-27 13:08:06 +02:00
Dieter Adriaenssens
e33ce3dcb3 wrap long lines 2013-09-27 13:08:06 +02:00
Michal Čihař
0a3d1d5be8 Better names for URL generating functions 2013-08-07 10:58:17 +02:00
Michal Čihař
6bfecf8e94 Construct filename once 2013-08-06 15:27:25 +02:00
Michal Čihař
7a97781c23 Share code for checking whether to show icons 2013-07-30 14:54:21 +02:00
Marc Delisle
269d0c89fe Fix merge conflicts 2013-07-28 06:17:38 -04:00
Marc Delisle
836529be42 Fix merge conflicts 2013-07-28 05:55:40 -04:00
Marc Delisle
1293e9b6e9 [security] Fix self-XSS in schema export, see PMASA-2013-14 2013-07-23 11:05:10 -04:00
Michal Čihař
175f181968 Add missing parenthesis 2013-07-19 17:01:12 +02:00
Michal Čihař
d5ee852ab9 Better class generating in schema export
- test whether file exists
- use new instead of eval
2013-07-19 08:55:20 +02:00
Michal Čihař
bb92cb2a26 Share schema export code 2013-07-19 08:55:20 +02:00
Marc Delisle
142e465c80 [security] Avoid full path disclosure from some libraries scripts, see PMASA-2013-12 2013-07-17 15:24:24 -04:00
adamgsoc2013
ad726ccb94 split output from constructor for Schema classes
remove "exit" which is unneeded action
2013-07-10 17:10:13 +08:00
adamgsoc2013
bedd8288af fix the class redefine error in sub class of Schema
1. change class Table_Stats to Table_Stats_$type
2. change class Relation_Stats to Relation_Stats_$type
2013-07-10 13:35:47 +08:00
adamgsoc2013
e476fc57c3 space instead of tab 2013-07-10 13:17:01 +08:00
adamgsoc2013
9d8e88bbb1 Add UT to validate that the data is set correctly on the sub class of Schema 2013-07-10 00:26:24 +08:00
Michal Čihař
d7b9ffbb18 Better description of a checkbox
Previous wording lead many translators to using question, which does not
look nice on checkbox.
2013-06-24 16:08:52 +02:00