gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
109,655 Commits 12 Branches 481 Tags 2.4 GiB
7001541837
Commit Graph

4911 Commits

Author SHA1 Message Date
Michal Čihař
9003e3e067 Fixed check all interaction with filtering 
- check all select only filtered rows
- the hidden rows are automatically unselected
- the check all state is updated according to filtering

Fixes #13517

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-30 22:21:06 -05:00
Jakub Stanecki
2192fadc0b Fix selecting multiple rows accidentally selects the next row too 
Fix #13669

Signed-off-by: Jakub Stanecki <staneckijakub@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-09-11 20:58:12 -03:00
Michal Čihař
04add7c918 Better report connection errors 
Provide verbose error description when we can't connect to the server
from client.

Fixes #13183

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-04 16:57:27 +02:00
Michal Čihař
0fcceb9b2f Do not include error code 0 in the message 
It really is not useful information.

Issue #13183

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-04 16:53:56 +02:00
Michal Čihař
2a883f8ba1 Include error detail in the error message 
Issue #13183

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-09-04 16:51:19 +02:00
Michal Čihař
e781cf0c76 Fixed javascript error in server monitor 
Fixes #13628

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-29 15:34:21 +02:00
Madhura Jayaratne
047de9cdf4 Merge branch 'QA_4_7' of github.com:phpmyadmin/phpmyadmin into QA_4_7 2017-08-29 23:27:22 +10:00
Madhura Jayaratne
f4d77f905d Fix #13177 Grid editing repeats action after error 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2017-08-29 23:25:14 +10:00
Michal Čihař
fa2dc971f6 Integrate tooltip into datetime pickers 
The tooltip is now disabled when picker is shown and it's content is
rendered wihtin the picker.

Fixes #13612

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-28 15:05:50 +02:00
Michal Čihař
f7404bce02 Do not use AJAX POST for forms that would normally use GET 
Fixes #13606

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-23 14:44:26 +02:00
Michal Čihař
ef891b2bba Simplify code for copying to clipboard 
Honestly I don't understand the old code, but it breaks on fields with
applied transformations, while using simply text() works fine.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-02 08:18:37 +02:00
Michal Čihař
626c2b3a29 Remove not needed variable 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-02 08:14:12 +02:00
Michal Čihař
12f54fd0cf Fixed copy results to clipboard 
Copy only results table, not all tables on the page.

Fixes #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-02 08:12:41 +02:00
Michal Čihař
33dd51eaf7 Move SQL copy handler to sql.js 
Issue #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-02 08:11:32 +02:00
Michal Čihař
23866a5875 Simplify code by removing not needed variable 
Issue #13550

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-08-02 08:07:36 +02:00
Michal Čihař
4b4403aeef Update to current lint plugin 
Our patch has been integrated.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-18 11:46:43 +02:00
Michal Čihař
0971a91698 Change variable name to match upstream 
See https://github.com/codemirror/CodeMirror/pull/4861

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-18 11:26:11 +02:00
Michal Čihař
639c2b8c4b Fixed rendering SQL lint errors 
- add patch to CodeMirror to render HTML, it's submitted upstream as
  https://github.com/codemirror/CodeMirror/pull/4861
- properly escape html output of Linter, now when we use full HTML

Fixes #13489

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-18 11:05:37 +02:00
Michal Čihař
8841a26788 Fixed size of index edit dialog 
Fixes #13382

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-17 17:09:10 +02:00
Michal Čihař
6a3d51e084 Make hex inline editor accept 0x at the begining 
Issue #13387

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-17 16:52:49 +02:00
Michal Čihař
10b04f175a Fix website URL 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-07-09 11:14:05 +02:00
Michal Čihař
358d2fd1f1 Rewrite export alias defining 
The old code did load all colums for all tables in all databases in
export. This can easily explode for server wide exports or exports on
database with lot of tables.

It has been rewritten in a way to load required data on demand from
server. This will make aliases defining slightly slower, but I think
it's acceptable price for making the export work on larger databases.

Fixes #13008

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-13 17:02:45 +02:00
Michal Čihař
58023e98a8 Fixed loading additional javascripts 
The server side loader does limit to 10 files, but the client side code
happily generates more requests.

Depending on loaded pages, this could lead to some javascript files not
being loaded (eg. if you went to monitor directly from home page).

Fixes #13362

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-06-06 14:51:18 +02:00
Madhura Jayaratne
660123d228 Fix #13177 Grid editing repeats action after error 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2017-05-17 23:41:56 +10:00
Dan Ungureanu
c2761f6135 Fixed tooltip not showing up. 
Fixes #13252.

Signed-off-by: Dan Ungureanu <udan1107@gmail.com>
 2017-05-08 19:45:39 +03:00
Michal Čihař
96b13f46c5 Ensure the xhr attribute is reset on error 
Not really necessary right now, but better be safe than sorry.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-05 09:35:22 +02:00
Michal Čihař
c6c8c970ac Add debug logging to the AJAX error handler 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-05 09:35:22 +02:00
Michal Čihař
799ac0d4a0 Fix condition to ignore aborted requests 
The status=0 happens on network failure as well, so we can't ignore it
completely.

Fixes #13130

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-05 09:35:22 +02:00
Michal Čihař
a079a55282 Remove duplicite error handler 
There is already ajaxError in js/ajax.js, we can do handling there.

Issue #13130

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-05 09:33:10 +02:00
Michal Čihař
f5655f4429 Do not try to parse error response 
Issue #13130

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-04-05 09:33:06 +02:00
Michal Čihař
8602695340 Focus on SQL editor after inserting field name 
Fixes #13125

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-30 13:16:42 +02:00
Piyush Agrawal
f89aafe9bf Fix: Focus back to codemirror editor on selecting column 
Signed-off-by: Piyush Agrawal <poush12@gmail.com>
 2017-03-30 13:13:33 +02:00
Michal Čihař
b98fc393ab Revert "Fixes error in designer #13032" 
This reverts commit dc649d7a29.
 2017-03-21 11:33:51 +01:00
Raghuram
dc649d7a29 Fixes error in designer #13032 
Signed-off-by: Raghuram Vadapalli <raghuram.vadapalli@research.iiit.ac.in>
 2017-03-21 10:00:58 +01:00
Michal Čihař
91a16c90c8 Fixed editing of rows with text primary key 
We do htmlspecialchars in PHP, so we should not URL de/encode here.

Fixes #13088

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-16 15:12:38 +01:00
Michal Čihař
89113241e6 Do keepalive calls for all authentication types 
We want to avoid session expiry in all cases, it makes no sense to limit
this to cookie auth only.

Issue #13022

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-09 16:27:41 +01:00
Michal Čihař
f0485f6460 Add missing server parameter to several javascript requests 
Also use PMA_commonParams where applicable.

Issue #13047

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-03 14:48:11 +01:00
Michal Čihař
dbce3b54d1 Fix query simulating for more servers 
The server parameter was missing.

Fixes #13047

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-03 14:48:11 +01:00
Michal Čihař
248a42af7e Fixed javascript confirmation of dangerous queries 
The confirmations did work properly only in console and not anywhere
else.

- the check function was expecting textarea, while it got text from
  other calls
- the check for empty form was completely outdated, but that seems to
  lead only to dead code and no breakage
- for the inline editor, the form was not properly focused and restored
  on confirmation error

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-03-01 09:33:18 +01:00
Michal Čihař
b05e28a953 Initialize error reporting after load 
Doing that in the code can lead to handler being installed several times
on some pages.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-22 09:55:34 +01:00
Mike Lewis
dcaeb652b0 Also submit inline SQL form when pressing the command key on macOS 
Allows for the natural macOS key combination to submit a form (command
+ enter) to be used in addition to the Windows combination (control +
enter)

Signed-off-by: Mike Lewis <mike@mplew.is>
 2017-02-20 09:03:40 +01:00
Michal Čihař
b42ef4f631 Correctly generate URL when there were not parameters 
Fixes #13014
Fixes #13013

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-20 08:58:00 +01:00
Michal Čihař
df2571e9a3 Clear interval before reload 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-14 17:11:36 +01:00
Michal Čihař
82f13e34d0 Better handle multiple open browser windows 
Calculate session expiry per browser (tracking is based on
sessionStorage which is unique per tab). With this we're able to detect
that there is another window open and actively used and avoid logging it
out by inactive one.

Issue #11231

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-14 17:00:44 +01:00
Michal Čihař
dc3ef3ce7f Try harder to honor LoginCookieValidity setting 
Even when it is lower than session.gc_maxlifetime we try to keepalive
the session by AJAX.

Fixes #11231

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-14 16:29:55 +01:00
Michal Čihař
7667689d65 Use more reasonable timeouts for keepalive 
- always update before session expiry
- shorter interval in the end

Fixes #11231

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-14 15:56:22 +01:00
Michal Čihař
c86aa9b275 Always show error reporting dialog on top 
Fixes #12958

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-14 11:51:23 +01:00
Michal Čihař
889ccb6555 Better defaults when creating multi fields foreign key 
It does not make sense to set all fields to one key.

Fixes #12980

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-14 11:09:57 +01:00
Michal Čihař
58472a97d2 Fixed javascript error on 3NF normalization 
Fixes #12927

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-13 15:30:51 +01:00
Michal Čihař
7da83511ec Do not use deprecated jQuery functionality 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-02-13 15:24:25 +01:00