gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
120,924 Commits 12 Branches 481 Tags 2.4 GiB
708bb9b30b
Commit Graph

128 Commits

Author SHA1 Message Date
William Desportes
2acea7d4c0
Merge branch 'QA_5_1' 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:39:50 +01:00
William Desportes
0a1d09b282
Add tests for #16595 - underscore structure edit 
I removed the escape because it is already escaped afterwards.

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-01-31 01:25:34 +01:00
Maurício Meneghini Fauth
1e5fbd57fc
Create Twig\AssetExtension and image Twig function 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-28 16:09:17 -03:00
Maurício Meneghini Fauth
acd214c9b7
Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:58:18 -03:00
Maurício Meneghini Fauth
0ed9c23c1e
Fix uncaught TypeError when editing partitioning 
When the partition has subpartitions.
https://github.com/phpmyadmin/phpmyadmin/issues/14494

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 22:50:18 -03:00
Maurício Meneghini Fauth
73f21d6950
Extract drop partition action to a new route 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-30 15:01:41 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
36d93cf2f9 Remove Common::table method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
601ed4649e Remove DBI dep from Table\AbstractController 
Moves the DatabaseInterface class dependency to the classes that use it.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-12 12:53:03 -03:00
Maurício Meneghini Fauth
e66be179ca Use camel case naming for class members 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
bb32ba6d9c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-04 12:31:43 -03:00
Maurício Meneghini Fauth
f2e49a92c6 Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 19:23:01 -03:00
Maurício Meneghini Fauth
ea163ffcae Move CentralColumns to the Database namespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-30 10:14:22 -03:00
Maurício Meneghini Fauth
5aa2856f7f Remove Util::buildActionTitles and the titles global 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-12 22:50:08 -03:00
Maurício Meneghini Fauth
37289a57b2 Remove url_query and url_params from Table/StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-07 14:24:41 -03:00
Maurício Meneghini Fauth
c57dda7315 Use DI for Sql class constructor 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-05 15:31:39 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
7936909dbd Move Operations::getMaintenanceActions to the view 
Uses Table\MaintenanceController to handle the maintenance actions in
the table operations page.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-28 15:25:14 -03:00
Maurício Meneghini Fauth
c112bfd6d6 Create a new page for Check Table 
Instead of only showing the query results.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-27 14:22:22 -03:00
Rosheen Naeem
673c194b01 Fixed underscore prefixes 
Signed-off-by: Rosheen Naeem <rosheennaeem4@gmail.com>
 2020-08-06 17:51:34 +05:00
Maurício Meneghini Fauth
858e8dc666 Extract template render from ColumnsDefinition::displayForm 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 17:21:36 -03:00
Maurício Meneghini Fauth
1dccc10493 Extract method for adding script files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:58:33 -03:00
Maurício Meneghini Fauth
f8320956ee Remove Config\PageSettings::showGroup method 
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
a3147c26e1 Extract exit; from Core::previewSQL method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-09 16:20:41 -03:00
Maurício Meneghini Fauth
05c62ad1a8 Fix some PHPStan errors 
Fixes "Cannot access offset on array" errors.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-02 16:12:07 -03:00
Maurício Meneghini Fauth
41d401b95e Extract save action from table structure index method 
Closes #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-08 19:57:28 -03:00
Maurício Meneghini Fauth
2529824c23 Extract change column action from table structure index method 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-08 18:20:48 -03:00
Maurício Meneghini Fauth
5df2c41d67 Extract add-key action from table structure index method 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-06 19:35:52 -03:00
Maurício Meneghini Fauth
4446963b5a Extract partitioning actions from index method 
Extracts from Table/StructureController::index method.

Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-06 17:20:10 -03:00
Maurício Meneghini Fauth
2937e9796d Remove underscore prefix from some method names 
Related to #16149

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-30 17:20:43 -03:00
Maurício Meneghini Fauth
f4582e083e Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
6d123fe452
Some minor codebase fixes and improvements 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-24 15:25:56 +02:00
Maurício Meneghini Fauth
e638ac2104 Extract table structure reserved word check action 
Related to #16136

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-23 15:24:16 -03:00
Maurício Meneghini Fauth
1d17c55f36 Extract table structure move columns action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 20:20:47 -03:00
Maurício Meneghini Fauth
7902e28652 Remove duplicated code in Table\StructureController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:46:26 -03:00
Maurício Meneghini Fauth
3bf3fd5c36 Extract browse action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
a6d9818b3a Extract the change action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 19:36:07 -03:00
Maurício Meneghini Fauth
765059def4 Extract central columns actions from index method 
Extracts the /table/structure/central-columns-add and
/table/structure/central-columns-remove routes from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 17:15:15 -03:00
Maurício Meneghini Fauth
7b5ed8634a Extract the ftext action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 15:43:09 -03:00
Maurício Meneghini Fauth
3551dc3eaa Extract spatial action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 03:22:14 -03:00
Maurício Meneghini Fauth
2eceedb05c Extract unique action from table structure index action 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-22 02:12:36 -03:00
Maurício Meneghini Fauth
4913980970 Extract add index action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-21 15:29:36 -03:00
Maurício Meneghini Fauth
115f79c959 Extract primary action from table structure index method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-20 19:59:55 -03:00
Maurício Meneghini Fauth
04590f5b4f Extract drop fields action from index action 
Extracts the /table/structure/drop route from the /table/structure
route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 13:37:16 -03:00
Maurício Meneghini Fauth
ff86a0b6d6 Extract drop confirmation action from index action 
Extracts the /table/structure/drop-confirm route from the
/table/structure route.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-19 11:21:42 -03:00
William Desportes
a72203c514
Remove some unused code 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 23:51:43 +02:00