gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
111,848 Commits 12 Branches 481 Tags 2.4 GiB
70e9ec0fcd
Commit Graph

17869 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
70e9ec0fcd Use template for _buildValueDisplay 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 23:40:56 -02:00
Maurício Meneghini Fauth
9d79d04af7 Use template for _getCommentForRow 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 23:15:02 -02:00
Maurício Meneghini Fauth
fdf7cd75db Use template for _getFormForMultiRowOperations 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 21:29:02 -02:00
Maurício Meneghini Fauth
f513738e7a Use template for _getOptionsBlock 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
dfa796be07 Use template for _getTableNavigationButton 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
1852c2c4da Use template for _getAdditionalFieldsForTableNavigation 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 20:27:02 -02:00
Maurício Meneghini Fauth
dba5237520 Use template for _getShowAllCheckboxForTableNavigation 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-18 20:27:02 -02:00
Michal Čihař
b6a8589037 Merge branch 'QA_4_7' 2017-11-18 13:44:15 +01:00
Michal Čihař
facc536689 Detect another way MySQL server needs SSL 
Fixes #13436

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-18 13:43:53 +01:00
Michal Čihař
152c4857c2
Merge pull request #13817 from nijel/link-or-button 
Simplify handling of long URLs in Util::linkOrButton
 2017-11-16 18:52:07 +01:00
Michal Čihař
868bb18c98 Better deal with unitialized page 
Fixes #13814

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 16:39:28 +01:00
Michal Čihař
f29640c5d8 Remove $strip_img parameter from Util::linkOrButton 
It did not behave as documented for ages, it only influenced
whether additional text was added to the link.

Callers should use parameters to Util::getIcon to achieve this
(if it is actually needed somewhere)

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:41:27 +01:00
Michal Čihař
ad72aaecc2 Avoid passing default params to Util::linkOrButton 
Do not pass optional parameters with default values.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:41:27 +01:00
Michal Čihař
3cd104a454 Remove not needed $force_button paratemet from Util::linkOrButton 
It was used to force POST for few links with the SQL, but that
is now done automatically.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:41:27 +01:00
Michal Čihař
486ab532f3 Remove magic to add message in Util::linkOrButton 
The passed parameter should be already valid, we should avoid expensive
processing of the data such as calling strip_tags on every text
containing <img.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:41:27 +01:00
Michal Čihař
9c087ccffc Document when POST is used in Util::linkOrButton 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:41:27 +01:00
Michal Čihař
99e9854473 Always use POST for links containing SQL query 
This way the SQL queries will not apper in the web server logs.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:33:53 +01:00
Michal Čihař
657ee671fc Avoid double html encoding of link target 
This is done when printing the attributes as well.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:33:53 +01:00
Michal Čihař
1a0bb3ebd5 Avoid using mb_* function for URL length calculation 
It is handled in bytes on the webserver side, so use limits in bytes not
in chars as mb_strlen does.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:33:53 +01:00
Michal Čihař
50c65bc3fb Remove no longer needed $new_form from Util::linkOrButton 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:33:53 +01:00
Michal Čihař
3b9fb2b664 Simplify handling of long URLs in Util::linkOrButton 
We no longer create form, but rather rather tag the link to be handled
as POST on the client side.

This way the code is way simpler without need on any special case
handling on server side.

Fixes #13649

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 15:33:53 +01:00
Michal Čihař
efe62c9422 Remove special case for JS event handlers in Util::linkOrButton 
This is not used anywhere and makes little sense anyway.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-16 11:37:14 +01:00
Michal Čihař
22efbd263e Fix typo in transformation 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-14 10:48:43 +01:00
Michal Čihař
1fccdb4da0 Fix typo in transformation 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-14 10:47:21 +01:00
Maurício Meneghini Fauth
b996919c47 Move query results logic into MultiTableQuery class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 23:01:31 -02:00
Maurício Meneghini Fauth
fc08cca15b Refactor getFormHTML method 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 21:55:41 -02:00
Maurício Meneghini Fauth
45de599d79 Move columns template into form template 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 18:05:39 -02:00
Maurício Meneghini Fauth
a76fb00ce6 Refactor Database/MultiTableQuery to use DI 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 17:20:27 -02:00
Maurício Meneghini Fauth
41dfe10efe Use template for getFormHTML 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 16:13:53 -02:00
Maurício Meneghini Fauth
c82669ba57 Use template for getColumnsHTML 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 15:57:13 -02:00
Maurício Meneghini Fauth
608242662d Make Multi Table Query strings translatable. 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-13 13:15:56 -02:00
Michal Čihař
cedad5f931 Remove sprites from the themes 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-13 14:12:12 +01:00
Michal Čihař
ec2adf0e56 Merge branch 'QA_4_7' 2017-11-13 12:38:05 +01:00
Michal Čihař
9f3449275e Add SJIS-win to default list of allowed charsets 
Fixes #13803

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-13 12:37:24 +01:00
Michal Čihař
895ee146d6 Fix undefined variable wihout DB connection 
This might be called from path where DB connection is not needed.

Fixes #13805

Signed-off-by: Michal Čihař <michal@cihar.com>
 2017-11-13 12:24:27 +01:00
Maurício Meneghini Fauth
1f98dcf1c2 Fix designer not showing table column information 
Fix #13809

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-12 02:11:47 -02:00
Maurício Meneghini Fauth
3eed95aba0 Use template for _getFootersOptions 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 22:39:03 -02:00
Maurício Meneghini Fauth
3a00dc7d0a Use template for _getSortOrderSelectCell 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 22:11:06 -02:00
Maurício Meneghini Fauth
6c90b384f7 Refactor _getSortSelectCell 
Move 'selected' html to template.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 12:48:17 -02:00
Maurício Meneghini Fauth
7586c2904a Use template for _getSortSelectCell 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-11 12:35:32 -02:00
Maurício Meneghini Fauth
10b8730df5 Use template for _showColumnSelectCell 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 19:57:54 -02:00
Maurício Meneghini Fauth
1f482ff6e7 Use template for displayFormBottom 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
70b592ba61 Usa template for displayTabsBottom 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
ed76f7cffd Remove displayFieldsetBottomSimple method 
Can be replaced by displayFieldsetBottom(false)

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
f64e0e1742 Use template for displayErrors 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 19:19:43 -02:00
Maurício Meneghini Fauth
ce9902b5f5 Use template for displayGroupHeader 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 18:20:32 -02:00
Maurício Meneghini Fauth
729349d326 Use template for displayFieldsetTop 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 16:07:00 -02:00
Maurício Meneghini Fauth
72bcc1336f Use template for displayFieldsetBottom 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 15:08:28 -02:00
Maurício Meneghini Fauth
b041c13a0c Fix CreateAddField methods visibility 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-10 09:06:41 -02:00
Maurício Meneghini Fauth
42cc8ece2c Replace globals with DI in CentralColumns class 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2017-11-09 11:53:28 -02:00