Commit Graph

5267 Commits

Author SHA1 Message Date
Isaac Bennetch
7cb6e69186 Merge remote-tracking branch 'security/security/designer/save-page' into QA_4_8 2019-06-04 12:03:17 -04:00
William Desportes
69e08d8503
Fix #10846 - TypeError: Cannot read property 'substring' of undefined
Fixes: #10846
Pull-request: #15284
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-03 21:00:31 +02:00
Apoorv Khare
499f552794 Fixes #15079 Responsive behaviour of instruction dialog box (#15089)
Signed-off-by: Apoorv Khare <apoorvkhare007@gmail.com>
2019-05-31 13:24:22 -03:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
2019-05-31 18:21:30 +02:00
Maurício Meneghini Fauth
9a6f077975 Fix empty PMA_gotoWhitelist JavaScript array
Related to commit 738f527242

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-29 17:06:19 -03:00
William Desportes
3500da154f
Fix undefined index dialog
Did occur when POST OR GET was sent to have a dialog
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-07 18:45:51 +02:00
William Desportes
191a81c9b6
Fix #15037 - Unexpected behavior of reset button
Fixes: #15037
Pull-request: #15045
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 16:40:55 +02:00
William Desportes
8e20d8cf25
Fix #15043 - Multiple errors printing on Settings page
Fixes: #15043
Pull-request: #15054
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 16:34:31 +02:00
William Desportes
821dce6c80
Fix #14301 - Javascript error when editing a JSON data type column
Fixes: #14699
Fixes: #14301
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 14:34:30 +02:00
William Desportes
69e7e59d9b
Fix #15239 - TypeError - Cannot read property 'textContent' of undefined
Fixes: #15239
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-04 13:35:36 +02:00
William Desportes
07389d12aa
Fixed error reporting (current web page url, JS file name sanitization)
- Added tests on master branch
- Added support for js/*.js files
- Added support for slashes and dots in file paths
- Added back support for 'url' (the current webpage)

All js files where reported as 'index.php' now they are reported as their real name

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 21:31:11 +02:00
William Desportes
3989a1ffe2
Fix #15146 - Error reports can not be sent because too large
Fixes #15146
See: 926a9f47bd

Aligned with php code (that does quite the same truncate on the context stack)

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 16:25:28 +02:00
William Desportes
5a08e12bb6
Fix #15205 - Useless backquotes, sql preview, delete index
Fixes: #15205
Pull-request: #15207
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 20:10:51 +02:00
William Desportes
40fc9a3abc
Improve JSDoc for PMA_confirmPreviewSQL
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 20:09:14 +02:00
William Desportes
926a9f47bd
Fix #15146 - Error reports can not be sent because too large
Fixes: #15146
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 14:31:11 +02:00
Saurabh Srivastava
8175e49b67 remove useless variable declaration
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-28 17:47:28 +05:30
William Desportes
2c1b669c1b
Fix #14401 - insert_rows keypress Enter behavior
Fixes: #14401
Pull-request: #15182
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 13:46:59 +02:00
William Desportes
04f641612c
Fix #14982 - setting "null" keep an "enum" value
Fixes: #14982
Pull-request: #14994
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 13:45:28 +02:00
William Desportes
782d9449a2
Fix #12900 - Designer page saving gives error
Fixes: #12900
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-26 23:45:46 +02:00
Saurabh Srivastava
756c03192c remove useless quotes
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-26 16:17:30 +05:30
William Desportes
dd299c7ceb
Fixed importing the exported config on Server status monitor page
- Missing value 'series' created a javascript error
- Missing series value created an error 'NaN' on the Y axis
- Added variable declaration
- Added check if local storage is supported

Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-25 20:42:51 +02:00
William Desportes
1343cf2b84
Fix lint issues
See: adb2228039
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-25 20:05:04 +02:00
William Desportes
adb2228039
Fix #15219 - 'No Password' Option does not switch automatically to 'Use Text Field' in Add User Account
'No Password' Option does not switch automatically to 'Use Text Field' in Add User Account

Fixes: #15219
Pull-request: #15220
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-25 19:16:54 +02:00
Roel van Duijnhoven
2b6e7a2128 Fix #14460 -Do not submit forms multiple times on CTRL + ENTER
Fixes: #14460

When there are multiple submit buttons, using the CTRL+ENTER shortcut will submit the same form multiple times.

The PMA module adds a lot of duplicate submit buttons. So in that situation it will occur al ot.

Signed-off-by: Roel van Duijnhoven <roel.duijnhoven@gmail.com>
2019-04-25 18:52:52 +02:00
Kartik Kathuria
5813ac3f5b Removed spacing
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-04-23 18:10:06 +05:30
Kartik Kathuria
236ac3d44d Input field ajaxified and will automatically switch to Use Text Area:
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2019-04-23 15:27:45 +05:30
Saurabh Srivastava
5d6f761e08 Fix - #15205 - Useless backquotes, sql preview, delete index
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-16 13:58:41 +05:30
Saurabh Srivastava
28e52f859c fix - #14401 -- insert_rows keypress Enter behavior -- add event to ENTER key on add new field
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-12 23:09:57 +05:30
Maurício Meneghini Fauth
9995754d76 Fix duplicated generate password button
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-09 00:05:38 -03:00
Maurício Meneghini Fauth
e94fe6eed1 Fix generate password button when adding users
Fix #15170

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-04-08 23:39:22 -03:00
William Desportes
bb5f64fe02
Fix #15150 - Generate password hidden on second open of change password modal
Fixes: #15150
Pull-request: #15151
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-04 19:27:40 +02:00
Saurabh Srivastava
309580a34b Fix #15150 - Generate password hidden on second open of change password modal
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2019-04-04 10:56:54 +05:30
William Desportes
038c654ec4
Fixed downloading of monitor parameters for IE11 and Edge
Related-to: 5389a26b92
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-03 22:52:33 +02:00
William Desportes
d10932821d
Fix empty success message when adding new INDEX from left panel
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-03 12:25:16 +02:00
William Desportes
c3ca45bdee
Remove sourceMappingURL from zxcvbn vendor to avoid 404 errors
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-03 11:06:27 +02:00
William Desportes
fa903acfd2
Fix #14334 - Export table structure shows rows fields
Fixes: #14334
Closes: #14710
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 20:29:53 +02:00
Nupur Agrawal
4902d080e7
Fix #12729 - Sticky table header over dropdown menu
Fixes: #12729
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
2019-04-01 16:18:04 +02:00
William Desportes
c1ecafc383
Fix security issue, escape database name when saving page on designer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 12:01:52 +01:00
William Desportes
5389a26b92
Fix downloading of monitor parameters
- Added some delay because some browsers will say they can not find the 'file' (blob) error: 404
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 11:53:54 +01:00
William Desportes
144d53177f
Fix 'RESET SLAVE' button on replication slave
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 11:09:20 +01:00
William Desportes
65deb85c34
Fix normalization
- Add server parameter
- Use post when needed instead of GET since no more _GET are in normalization.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 11:09:20 +01:00
William Desportes
503ef70a06
Fix remove partitioning on multi server setup
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 11:09:20 +01:00
William Desportes
e48d4f376d
Fix query format on multi server setup
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 08:42:23 +01:00
William Desportes
c793b998a7
ESLINT fixes
Make eslint green for CI
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-30 08:30:48 +01:00
William Desportes
2ee9a04079
Fixed new table and database/table listing modal on multi server setup
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-29 21:13:06 +01:00
William Desportes
75b185a701
Fix #14816 - [designer] Cannot read property 'style' of null
Fixes: #14816
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-29 21:01:36 +01:00
apoorv
c0fc4db138 Fix #15043 Multiple printing + Checks missing
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
2019-03-20 03:50:56 +05:30
apoorv
a338d81cfe Fixes #15037 Unexpected behaviour of reset button
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
2019-03-17 20:14:10 +05:30
William Desportes
b5659f09af
Fix error reporting on multi server setup
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-16 21:14:47 +01:00
William Desportes
27f7b7a75f
Fix, prevent multiple error reporting modals
See: fa303ee292
Seee: #14359
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-16 21:05:28 +01:00