Commit Graph

24 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
7312c8eee5
Move AbstractController::checkParameters method to ResponseRenderer
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:32 -03:00
Maurício Meneghini Fauth
c212478ac8
Move AbstractController::redirect method to ResponseRenderer class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:31 -03:00
Maurício Meneghini Fauth
235c61da17
Move addScriptFiles method to ResponseRenderer class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-08 15:59:30 -03:00
Maurício Meneghini Fauth
181f971bc9
Create InvocableController interface
This creates the contract for the controllers.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-04-03 17:03:00 -03:00
Maurício Meneghini Fauth
6188e468ee
Merge branch 'QA_5_2'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-03-15 20:20:26 -03:00
Kamil Tekiela
8e4443b17b
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Import UrlTest

When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Drop redundant return [];

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix object access checks

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use strict comparison

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Int keys should be specified as integers

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use empty string check instead of strlen

Potential null deprecations are replaced with loose condition.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use stripos instead of *substr

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify substr's 3rd param

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary defaults

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace isZeroBasedArray with array_is_list

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify texEscape()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Simplify exportZeroBasedArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for loop with array_diff

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Replace for with foreach

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove nullable param in backquoteCompat

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use null-coalescing operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Inline $result variable

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Turn $event into a constant

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Move selectDb outside the loop

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix code style order of operation

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove unnecessary isset argument

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Remove line break

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Use foreach instead of for

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-27 12:29:02 -03:00
Maurício Meneghini Fauth
c96439d15d
Remove unused CheckUserPrivileges::getPrivileges() calls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2024-02-09 18:26:31 -03:00
Kamil Tekiela
79a68a4349
Add type hints instead of mixed (#18976)
* Remove some empty() statements

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type hint to getHtmlForOneKey()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to buildColumnCreationStatement()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add return type to fetchByMode()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCompatibilities()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getDirContent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getCharLists()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to executeSqlQuery()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to findLineNumberAndColumn

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to lint()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForNewTables3NF()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getViewsAndCreateSqlViewStandIn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPossibleRowFormat()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableAltersArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getValuesForColumn()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getAvailableMimeTypes()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types to TwigLintCommand

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to isRowCountApproximated

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getReplicationStatus()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type in formatVariable()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to fetchSingleRow()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getPages()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to CentralColumns::getParams()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to removeRelation()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getWarnings()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getTableCommentsArray()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Fix docbloc comment

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to sanitizeUrl()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to uploadProgressSetup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to explodeMarkup()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add types in Table

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

* Add type to getHtmlForDataStatements()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-02-07 19:19:12 -03:00
Kamil Tekiela
822ebbfe59 Remove unnecessary parentheses
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2024-01-12 15:26:31 +01:00
Maurício Meneghini Fauth
0307babf27
Replace text_dir global var with LanguageManager::$textDir static
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-26 16:20:58 -03:00
Maurício Meneghini Fauth
31419bc770
Merge pull request #18859 from kamil-tekiela/getDbInfo
Refactor getDbInfo() and getTablesWhenOpen()
2023-12-24 03:47:51 -03:00
Kamil Tekiela
49149b218d Make StructureController final
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-22 13:42:57 +01:00
Kamil Tekiela
c2179c9482 Use count outside of getDbInfo()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-20 23:57:09 +01:00
Maurício Meneghini Fauth
711f6c0f14
Replace db global variable with static class property
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-12-17 14:58:59 -03:00
Kamil Tekiela
702e8e5442 Refactor RecentFavoriteTables
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-13 20:38:49 +01:00
Kamil Tekiela
ff2eb4df59 Rename the class
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-13 18:02:41 +01:00
Kamil Tekiela
be734dd209 Introduce an enum TableType
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-13 18:02:41 +01:00
Kamil Tekiela
fa69c34e63 Move RecentFavoriteTable to its own namespace
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-13 18:02:41 +01:00
Kamil Tekiela
bf9fc416fe Refactor DbTableExists
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-13 18:02:40 +01:00
Kamil Tekiela
4fb335e960 Make in_array strict
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-07 17:11:48 +01:00
Kamil Tekiela
e90cfe584f Change method name
This method doesn't sanitize anything. While it does format the message into HTML, it doesn't remove or clean anything. What it does is replace BB codes into HTML.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-12-02 00:10:16 +01:00
Kamil Tekiela
51f9c749ad Simplify code
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-11-28 14:42:37 +01:00
Maurício Meneghini Fauth
ae7f509820
Remove ExitException from AbstractController::checkParameters()
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-09-02 14:48:02 -03:00
Maurício Meneghini Fauth
c2955cc2b2
Rename the directory libraries/classes/ to src/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-30 15:59:28 -03:00