Kamil Tekiela
|
8e4443b17b
|
Applying suggestions from static analysis tools (#19013)
* Drop array keys from lists
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Import UrlTest
When it doesn't exist in Prod, the code will still work the same.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Drop redundant return [];
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix object access checks
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use strict comparison
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Int keys should be specified as integers
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use empty string check instead of strlen
Potential null deprecations are replaced with loose condition.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use stripos instead of *substr
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify substr's 3rd param
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unnecessary defaults
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace isZeroBasedArray with array_is_list
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify texEscape()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Simplify exportZeroBasedArray()
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace for loop with array_diff
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace for with foreach
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove nullable param in backquoteCompat
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use null-coalescing operator
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Inline $result variable
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Turn $event into a constant
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Move selectDb outside the loop
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix code style order of operation
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove unnecessary isset argument
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove line break
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use foreach instead of for
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
|
2024-02-27 12:29:02 -03:00 |
|