Commit Graph

22 Commits

Author SHA1 Message Date
Michal Čihař
7898060916 Ensure PmaAbsoluteUri ends with /
This was probably most frequest user error we want to fix.

Issue #12374

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-17 15:37:20 +02:00
Michal Čihař
01b9db6b1c Rename getCookiePath() to getRootPath()
It is not used only for cookies, so generic name makes more sense.

Issue #12374

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-08-17 15:35:15 +02:00
Michal Čihař
4072c1d29a Use example.com for sample test urls
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-07-28 09:12:01 +02:00
Michal Čihař
d78e173b34 Do not use dirname for calculating cookie path
It is wrong for this purpose as on Windows this uses \ for both
separating parts and generating result. This fixed calculation of cookie
path on Windows.

Fixes #12249

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-27 11:11:56 +02:00
Michal Čihař
e72c1d4da9 Add more tests for getCookiePath (issue #12249)
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-05-26 18:04:23 +02:00
Michal Čihař
a29f154f37 Merge branch 'MAINT_4_5_5-security' into QA_4_6-security 2016-02-29 10:35:47 +01:00
Michal Čihař
de7181653f Correctly handle paths to exact files when setting cookie
We need to set path to folder not a given file.

Fixes #11916

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-08 09:54:57 +01:00
Michal Čihař
892d09cf74 Add more tests for getting cookie path
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:50:00 +01:00
Michal Čihař
ae1ccf3e6a Remove PmaAbsoluteUri configuration directive
Fixes #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:41:29 +01:00
Michal Čihař
43ca165e9f Remove unused method checkCookiePath
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:34:32 +01:00
Michal Čihař
a569eeca93 Do not use PmaAbsoluteUri for getCookiePath
Issue #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:32:32 +01:00
Michal Čihař
060aaf9c99 Remove detectHttps method
The isHttps method does the same and simpler.

Issue #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:25:58 +01:00
Michal Čihař
a913f99817 Add detection based on REQUEST_URI as well
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:25:13 +01:00
Michal Čihař
49eb80d887 Rewrite tests for https detection
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:19:04 +01:00
Michal Čihař
16a30ae87d Fix documented return values
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 17:15:40 +01:00
Michal Čihař
6da017fcfc Load vendor_config just once at testsuite startup
Signed-off-by: Michal Čihař <michal@cihar.com>
2016-02-03 14:21:57 +01:00
Michal Čihař
e95bb0e361 Remove own code for generating numeric PHP version
Since PHP 5.2.7 there is PHP_VERSION_ID for it.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-28 14:53:58 +01:00
Michal Čihař
b450e58dbb Remove require of libraries included in test bootstrap
There is no need to specify them in every test when we already do it
globally.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-12 16:43:16 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
2016-01-04 16:35:28 +01:00
Madhura Jayaratne
2b7cfb595d Move the rest of the tests related to objects under a common parent test
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-12-18 21:32:34 +11:00
Michal Čihař
3565e4db79 Remove PMA_arrayMergeRecursive
It can be replaced with array_replace_recursive as of PHP 5.3, we
require PHP 5.5.

Signed-off-by: Michal Čihař <michal@cihar.com>
2015-12-09 08:06:00 +01:00
Madhura Jayaratne
ab49273856 Rename test classes
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2015-10-15 20:57:27 +11:00