Commit Graph

226 Commits

Author SHA1 Message Date
Ann + J.M
fea0fe03ef Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-06-04 18:02:44 +02:00
Marc Delisle
bd762244ec Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-06-03 12:27:02 -04:00
Marc Delisle
4627be8968 Clarify message
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-28 08:21:06 -04:00
Marc Delisle
93ce1a69de Merge pull request #1195 from smita786/gsoc_central_columns_list
Gsoc central columns list
2014-05-26 15:14:04 -04:00
Smita Kumari
200737bcce gsoc:central list of columns, added sync and remove column list on db_structure page
Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixing indentation in mult_submits.inc.php

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

naming convention,typos, indentaion fix and removed unnecessory file db_sync_central_columns.php

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

check if central columns storage is configured, if not configured don't show the option to sync/remove

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

add/remove columns to central list of columns from tbl_structure page

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

added icon image for central columns add/delete

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

add/remove of columns option in tbl_structure page in columns rows depending upon if column is already present in central columns or not

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixed php notices, apporiprate message when a non existing column is removed and when a existing column is added to cenral list

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

documentation added for central_columns configuration

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

regenerated sprite

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

changed central_columns table structure + modified functions to add to central column as per new tbl def

updated delete and other function as per new db structure

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

remove notices

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

sprintf for variable message

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fix unit test failure errors

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

fixed whitespace issues plus function definition

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>

refactoring code plus fixing coding style issues

Signed-off-by: Smita Kumari <kumarismita62@gmail.com>
2014-05-26 23:13:03 +05:30
Marc Delisle
0db68db620 Merge branch 'QA_4_2' 2014-05-21 12:51:03 -04:00
Marc Delisle
c2d719b4eb bug #4423 Moving fields not working
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-21 12:49:55 -04:00
Ann + J.M
9207203a56 Code style fixes
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-05-19 22:51:33 +02:00
Chanaka Indrajith
39b5f07dfb Fixed some documentation issues raised by scrutinizer
Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
2014-05-18 00:14:27 +05:30
Marc Delisle
b35e4efee1 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-17 06:10:14 -04:00
Marc Delisle
ebb14cb085 Another case of notice
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-16 07:43:57 -04:00
Marc Delisle
afc755f31c Avoid notice of undefined variable
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-16 07:33:24 -04:00
Marc Delisle
3031996acf Merge commit 'aa2c9cd' 2014-05-15 12:47:50 -04:00
Chirayu Chiripal
aa2c9cd5d6 Bug fix #4414 table display of performance_schema DB structure
Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
2014-05-15 15:09:26 +05:30
Ashutosh Dhundhara
0a5d1ad757 RFE: #1448 Allow clicking an approximate row count to get a correct one.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-05-10 20:23:15 +05:30
Marc Delisle
277c0c57db Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-10 12:58:37 +02:00
Marc Delisle
d12d752c8c Merge pull request #1171 from ashutoshdhundhara/rfe_1445
RFE: #1445 Easy access to "SHOW CREATE".
2014-05-10 12:54:27 +02:00
Madhura Jayaratne
eb96dc7003 This should be an array
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2014-05-10 10:31:51 +02:00
Ashutosh Dhundhara
cc9cef8e15 RFE: #1445 Easy access to "SHOW CREATE".
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-05-10 02:10:21 +05:30
Michal Čihař
a5f338fe2f Fix handling of favorite tables
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-09 16:32:49 +02:00
Michal Čihař
4fe6bf0737 Fix return value types
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-08 10:43:34 +02:00
Michal Čihař
a6726ae170 Remove unused code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:39:04 +02:00
Michal Čihař
7cccfc1b6d Remove unused variable
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:38:27 +02:00
Michal Čihař
b4a11fd98e Move acquiring stats to place where the value is used
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-05-06 19:36:45 +02:00
Marc Delisle
45d020d1bf Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-06 12:46:32 -04:00
Marc Delisle
54254f88bd Refactoring: PMA_synchronizeFavoriteTables()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-06 12:45:51 -04:00
Marc Delisle
c61475ee24 Refactoring: PMA_addRemoveFavoriteTables()
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-06 12:29:04 -04:00
Marvin Wegener
1690c6fa32 Fix number field size and remove incorrect attributes
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-05-02 07:55:50 -04:00
Michal Čihař
94988899c5 Add missing full stop
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-04-22 14:06:44 +02:00
Marc Delisle
9899ac3e93 Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-21 16:36:19 -04:00
Marc Delisle
f310833cb4 Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-21 16:26:27 -04:00
Marc Delisle
75b3820eac Fix merge conflict
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-21 16:15:40 -04:00
Marc Delisle
db6ec58907 bug #4372 Changing browser transformation results in unnecessary table rebuild
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-21 16:07:49 -04:00
Ann + J.M
e7e8b64dd1 HTML5 data attributes for favorite table links
Signed-off-by: Ann + J.M <phpMyAdmin@ZweiSteinSoft.de>
2014-04-17 09:02:28 +02:00
Marc Delisle
a182cca004 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-14 12:26:32 -04:00
Ashutosh Dhundhara
57f8e18e96 Bug Fix: #4362 Adding index to column by button in structure view shows wrong dialog.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-04-12 18:34:47 +05:30
Marc Delisle
f46865c660 Fix coding style
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-04-11 09:34:51 -04:00
Edward Cheng
d74ac17cb4 Improve Navigation
Signed-off-by: Edward Cheng <c4150221@gmail.com>

Fix bugs.

Signed-off-by: Edward Cheng <c4150221@gmail.com>
2014-04-07 23:32:39 +08:00
Marc Delisle
0e13fc74a2 Merge pull request #1115 from ashutoshdhundhara/favorite_table
Favorite tables feature using Ajax.
2014-03-28 14:47:55 -04:00
Ashutosh Dhundhara
e9d59fd7e0 Implemented Favorite tables feature with Ajax.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Minor fixes in Settings->Features page and Navigation Header class.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fixed translation issues in RecentFavoriteTable class.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fixed error in RecentFavoriteTable class.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Another fix in structure.lib.php.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-03-29 00:06:14 +05:30
Michal Čihař
af3bfe6cfb Consistently use comma at the end of notification messages
These are sentences and should be ended as such.

Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-28 09:58:17 +01:00
Marc Delisle
e4224bf18d Merge pull request #1095 from ashutoshdhundhara/favourite_tables_icon_only
Feature request: #1476 Favorite tables select box.
2014-03-26 17:01:18 -04:00
Ashutosh Dhundhara
8bc21b7876 Feature request: #1476 Favourite tables select box.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Changes in "create_tables.sql".

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Minor fix in structure.lib.php.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Ripped Trailing White spaces.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Removed irrelevant comments from "FavouriteTable.class.php".

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fixed Table Summary colspan.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Changed Favourite to Favorite

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fixed failing test.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Feature request: #1476 Favourite tables select box. (Icon only)

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Gray and Golden Icons.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Removed unwanted icon from "img".

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Fixed error in PMA_buildActionTitles_test.php.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Re-positioned star icon and added tooltip to it.

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>

Ripped trailing spaces from "structure.lib.php" and "db_structure.js".

Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-03-26 23:37:19 +05:30
Michal Čihař
c52b5e0a91 Merge pull request #1090 from ashutoshdhundhara/bug_4337
Bug Fix: #4337 "More" in Actions area doesn't collapse to fit available space.
2014-03-26 09:51:00 +01:00
Ashutosh Dhundhara
77cbe2bd59 Bug Fix: #4337 "More" in Actions area doesn't collapse to fit available space.
Signed-off-by: Ashutosh Dhundhara <ashutoshdhundhara@yahoo.com>
2014-03-25 14:24:59 +05:30
Michal Čihař
d559fa6a21 Remove trailing whitespace from the code
Signed-off-by: Michal Čihař <michal@cihar.com>
2014-03-20 09:36:48 +01:00
Dennis1993
bda2da60aa No space between attribute
Signed-off-by: Marvin Wegener <mw197@web.de>
2014-02-28 19:56:53 +01:00
Dennis1993
a9ccbe9021 No space between attributes
Signed-off-by: Marvin Wegener <mw197@web.de>
2014-02-28 18:45:16 +01:00
Marc Delisle
d4c6964ffb Merge branch 'QA_4_1' 2014-02-15 09:35:38 -05:00
minhaz
abe8dbba82 Bug fix 4284
Signed-Off-By: A V Minhaz <minhazav@gmail.com>
Signed-off-by: Marc Delisle <marc@infomarc.info>
2014-02-15 09:33:18 -05:00