Maurício Meneghini Fauth
9e9611d162
Replace config global with Config singleton
...
This is as bad as the global variable, however at least will have better
static analysis of it.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-15 01:11:54 -03:00
Maurício Meneghini Fauth
5f9ba2e1d1
Extract Relation and Template dependencies from UserPreferences
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-09 15:04:34 -03:00
Maurício Meneghini Fauth
63e6410728
Refactor the DbTableExists class
...
- Changes static methods to instance methods
- Extract response handling to the controllers
- Add unit tests for the DbTableExists class
- Remove the AbstractController::hasDatabase() method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-08-06 01:42:06 -03:00
Maurício Meneghini Fauth
ecf1c78ae8
Wrap the Application::run() code with a HTTP handler
...
- Uses laminas-httphandlerrunner to emit the Response object
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-26 21:31:49 -03:00
Maurício Meneghini Fauth
c8a50637f4
Remove Template and ResponseRenderer dep from Routines class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-24 15:04:53 -03:00
Maurício Meneghini Fauth
32b92568f3
Inline the Events::getEditorForm() method
...
Moves the response handling to the controller.
Removes the dependency on ResponseRenderer and Template from the Events
class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-23 18:28:28 -03:00
Maurício Meneghini Fauth
2a0d7e21a9
Inline the Triggers::getEditorForm() method
...
Removes the dependency on ResponseRenderer and Template from the
Triggers class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-23 15:44:28 -03:00
Maurício Meneghini Fauth
b0604623d8
Extract PageSettings dependency from controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-07-06 20:17:34 -03:00
Maurício Meneghini Fauth
1f935e57f7
Move the Import class to the Import namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 12:44:04 -03:00
Maurício Meneghini Fauth
f23ab54ca9
Move the Export class to the Export namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-28 12:28:38 -03:00
Maurício Meneghini Fauth
f6e74de251
Extract some dependencies from the Application class
...
- Extracts the ErrorHandler, Config and Template dependencies from the
Application class.
- Loads HTTP ServerRequest object after loading the user config.
- Requires a Config object for the Template class.
- Disables Twig's cache if an exception is thrown before loading the
user config. This way a possible different cache directory will not be
used.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-16 15:55:20 -03:00
Maurício Meneghini Fauth
951c965d6e
Change Application static methods to instance methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-06-13 16:36:31 -03:00
Maurício Meneghini Fauth
74b1ffbf8c
Merge the DB and table trigger controllers
...
They are equivalent in current form.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-25 15:39:36 -03:00
Maurício Meneghini Fauth
367806a660
Fix coding standard issues related to namespaces
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-15 22:26:38 -03:00
Maurício Meneghini Fauth
8bbb1edbea
Remove ThemeManager::getInstance() method
...
Remove singleton from the Theme\ThemeManager class and uses DI where
possible.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-05-09 21:29:49 -03:00
Maurício Meneghini Fauth
dd885dc7b8
Use single-line arrays when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-27 17:39:17 -03:00
Maurício Meneghini Fauth
c7855f6e95
Create the PhpMyAdmin\Replication namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-20 14:16:01 -03:00
Kamil Tekiela
924fcc79f9
Refactor logic for getting Tracking status
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:36:21 +00:00
Kamil Tekiela
c0b367cc57
Create Tracking namespace
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-03-17 22:35:32 +00:00
Maurício Meneghini Fauth
8123a81235
Remove $GLOBALS['cfg'] from BrowseForeigners class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-03 16:15:40 -03:00
Maurício Meneghini Fauth
e38a46f7ae
Add Config as a constructor param of Template class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-03-03 13:30:32 -03:00
Kamil Tekiela
276577ca2a
Remove $GLOBALS['PMA_PHP_SELF'] ( #18149 )
...
* Remove $GLOBALS['PMA_PHP_SELF']
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove $GLOBALS['PMA_PHP_SELF'] from tests
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Moved cleanupPathInfo to Routing
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove parse_url from getRootPath
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Update baselines
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove invalid tests
Surely, we never expect PATH to be backslash delimited. The code is not designed to handle this and the tests for this don't make much sense.
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix trailing slash in path
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-27 17:56:27 -03:00
Kamil Tekiela
7e5d96b559
Use DI for UserPreferences
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-10 16:23:34 -03:00
Kamil Tekiela
bf601040d4
Use DI for UserPassword's $dbi
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2023-02-10 16:20:14 -03:00
Maurício Meneghini Fauth
c95b64afeb
Remove globals from the Replication class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2023-01-13 17:12:23 -03:00
Maurício Meneghini Fauth
a2a3f6d26d
Create a factory for auth plugin creation
...
Extracts the factory method from the Plugins class into a new class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-16 19:32:10 -03:00
Maurício Meneghini Fauth
b2eb6bf4c9
Extract config load and check from Config's constructor
...
This allows better handling of the user's config loading and validation.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-15 13:20:13 -03:00
Kamil Tekiela
a5a81d159f
Send DBI to Data using DI
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
15915a45e0
Send DBI to SqlQueryForm using DI
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-02 15:15:58 +00:00
Kamil Tekiela
27fad8821e
Make Routines a dependency
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:15 +01:00
Kamil Tekiela
3e5f101d6f
Make Triggers a dependency
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-10-18 13:53:14 +01:00
Maurício Meneghini Fauth
27bdd0d64d
Extract InsertEdit dependencies to constructor params
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-06-01 23:42:47 -03:00
Maurício Meneghini Fauth
acba6ed40f
Move VersionInformation to constructor in VersionCheckController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-31 17:58:37 -03:00
Maurício Meneghini Fauth
c0eb02d7d3
Extract ColumnsDefinition construction from controllers
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-03-02 18:59:27 -03:00
Maurício Meneghini Fauth
81cfa99df4
Move Advisor class to PhpMyAdmin\Advisory namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-02-24 13:16:19 -03:00
Maurício Meneghini Fauth
58ed5bfa9e
Extract Simulate DML action from ImportController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-27 18:37:15 -03:00
Maurício Meneghini Fauth
aaee7961c1
Remove Template dependency from Relation class
...
Related to 2299a62e49 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:14 -03:00
Maurício Meneghini Fauth
c411121fd8
Move Relation classes into the ConfigStorage namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-12-17 12:09:13 -03:00
Maurício Meneghini Fauth
00cb1b3668
Extract IndexesController::doSaveData method
...
Creates the Table\Indexes class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 14:38:44 -03:00
Maurício Meneghini Fauth
38fda677bd
Extract Processes class from ProcessesController
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-10 15:52:48 -03:00
Maurício Meneghini Fauth
78c266d98f
Move partition classes to the Partitioning namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-21 14:01:25 -03:00
Maurício Meneghini Fauth
f7fc4177af
Add support for account locking
...
- https://dev.mysql.com/doc/refman/en/account-locking.html
- https://mariadb.com/kb/en/account-locking/
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-21 00:55:33 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
674bf8f97c
Remove db, table and dbi globals from Tracking class
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-05-26 16:40:05 -03:00
Maurício Meneghini Fauth
4273634c17
Extract getActiveAuthPlugins method to Plugins class
...
Extracts the getActiveAuthPlugins method from the
PhpMyAdmin\Server\Privileges class to the PhpMyAdmin\Server\Plugins
class, rename it to getAuthentication and adds tests.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-04-14 16:07:40 -03:00
Maurício Meneghini Fauth
7e23436533
Add Twig\FlashMessagesExtension class
...
Adds the flash() Twig function that return all flash messages.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-20 18:51:36 -03:00
Maurício Meneghini Fauth
6f4a1c8ab5
Remove some config global in favor of DI
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-03-08 19:58:01 -03:00
Maurício Meneghini Fauth
f8df25487f
Create check table partition page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 21:09:32 -03:00
Maurício Meneghini Fauth
1849be34b3
Fix container services named parameters
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-22 20:29:28 -03:00
Maurício Meneghini Fauth
ea163ffcae
Move CentralColumns to the Database namespace
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-30 10:14:22 -03:00