Commit Graph

495 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
52603d18f9 Use early exit for Server\DatabasesController::destroy
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-07 15:34:42 -03:00
Maurício Meneghini Fauth
10357465de Fix PHPUnit tests
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-06 22:06:08 -03:00
Yash Bothra
bac6f6bb0c
Fix #15447 - disable checkbox of pmadb
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
2020-03-06 23:29:26 +01:00
Maurício Meneghini Fauth
82db7444c3 Extract db_table_exists.inc.php to DbTableExists class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-03-02 17:01:26 -03:00
Maurício Meneghini Fauth
c8c2e9d793 Refactor tbl_columns_definition_form.inc.php
Extracts the tbl_columns_definition_form.inc.php logic to the
PhpMyAdmin\Table\ColumnsDefinition::displayForm static method.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-17 02:55:20 -03:00
Maurício Meneghini Fauth
a63dbfb051 Move SysInfo classes to the Server\SysInfo namespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-16 17:22:44 -03:00
Maurício Meneghini Fauth
a95d9c3e65 Extract the HTML from the subnav of Users page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-16 16:05:51 -03:00
Maurício Meneghini Fauth
a989348986 Extract HTML from QueryByExampleController::index
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-15 01:16:58 -03:00
William Desportes
01cd7dc33b
Some code improvements suggested by Scrutinizer
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-14 22:23:16 +01:00
Maurício Meneghini Fauth
cd009f8ede Use Bootstrap list group for the home page lists
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-14 16:27:30 -03:00
William Desportes
517222ff59
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-13 00:07:11 +01:00
William Desportes
0b2937dd6a
Fix #15781 - Illegal string offset error on structure page of 'information_schema'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-12 23:11:41 +01:00
Maurício Meneghini Fauth
d85cca09b2 Remove database and table from route names
Database and table names may contain the slash char (/) which is the
route separator char.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:26:02 -03:00
Maurício Meneghini Fauth
64723d90da Rename the multi-table query route
Renames the route name from /database/multi_table_query to
/database/multi-table-query.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 17:04:59 -03:00
Maurício Meneghini Fauth
8029ea9875 Move request handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 15:00:02 -03:00
Maurício Meneghini Fauth
f5c970639c Move response handling from routes to controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-12 14:59:42 -03:00
Maurício Meneghini Fauth
3a9b762918 Extract HTML from user settings page header
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-07 00:51:11 -03:00
Maurício Meneghini Fauth
f6bbecc0c2 Create Preferences\ImportController class
Extracts the controller from the FormsController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 18:13:46 -03:00
Maurício Meneghini Fauth
7bfaffa283 Create Preferences\ExportController class
Extracts the controller from the FormsController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 17:52:20 -03:00
Maurício Meneghini Fauth
53cb7f6273 Create Preferences\MainPanelController class
Extracts the controller the from the FormsController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 17:07:53 -03:00
Maurício Meneghini Fauth
73a238e51e Create Preferences\NavigationController class
Extracts the controller from the FormsController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 15:39:20 -03:00
Maurício Meneghini Fauth
3db59bab5b Create Preferences\SqlController class
Extracts the controller from the FormsController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 15:15:29 -03:00
Maurício Meneghini Fauth
95e0c251ae Create Preferences\FeaturesController class
Extracts the controller from the FormController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 13:54:32 -03:00
Maurício Meneghini Fauth
a680af3a46 Simplify Form instatiation in FormsController
Instantiates the Form class directly instead of using a variable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 12:18:11 -03:00
Maurício Meneghini Fauth
adadd49a44 Extract HTML from ViewOperationsController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-02-05 01:40:45 -03:00
William Desportes
ba8946d5f8
Move some code to getFinalFilenameAndMimetypeForFilename and add tests
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:37 +01:00
William Desportes
a7a7b73b55
Support return back from raw export
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-27 21:16:37 +01:00
Saurabh Srivastava
1b56c8e0ed
Fix 15064 - instead of using free_query parameter, now updating export_type to raw -- more modular approach
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
2020-01-27 21:16:31 +01:00
Maurício Meneghini Fauth
30b5fc46d2 Extract HTML from table operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-24 20:00:13 -03:00
William Desportes
b736f0a79f
Merge branch 'QA_5_0'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 22:00:16 +01:00
William Desportes
36e4cf8f88
Fix after pull-request #15846 - add support for unsigned ints
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:24:53 +01:00
William Desportes
afce79c4bd
Merge #15846 - Fix #13326 - added Integer Validations on Search page
Fixes: #13326
Pull-request: #15846
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-24 21:11:54 +01:00
Manthan Surkar
e92e51d42d Added: Integer Validations on Search page
Signed-off-by: Manthan Surkar <manthan.surkar@gmail.com>
2020-01-25 01:21:19 +05:30
Maurício Meneghini Fauth
aa0f8a6efe Extract HTML from the database operations page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 22:56:29 -03:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
6584b01824 Use short versions of scalar types in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 12:20:04 -03:00
Maurício Meneghini Fauth
6b7af13f8f Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 00:33:24 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
5e0f539d2f Fix invalid @var php doc annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 13:19:08 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
c231652c67 Remove useless comments in PHP docs
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 14:38:49 -03:00
Maurício Meneghini Fauth
50bc4ab37f Remove useless PHP docs for functions
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
dcf87edbd1 Fix some coding standard issues
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 03:18:59 -03:00
Maurício Meneghini Fauth
f76499af7f Use Throwable instead of Exception
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 01:16:40 -03:00
Maurício Meneghini Fauth
8ec4209002 Fix some coding standard issues
- Inverts yoda comparisons
- Removes parentheses from return
- Removes useless ternary operators
- Adds paretheses to new instances
- Adds trailing array comma

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 00:38:34 -03:00
Maurício Meneghini Fauth
3c22f5e7b2 Add conding standard rule for useless method overrides
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:56:23 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-19 22:29:54 -03:00
William Desportes
ae0577ab1e
Merge #15820 - Fix #15797 - Relation view broken
Fixes: #15797
Pull-request: #15820
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-19 15:43:59 +01:00
Jayati Shrivastava
5a03410cfa fixes url.
fixes #15797

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
2020-01-19 20:06:03 +05:30