Commit Graph

21379 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
74f142d997
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-23 13:10:38 -03:00
Maurício Meneghini Fauth
6387eaad66
Fix a PHP notice when logging out
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-23 12:47:43 -03:00
Maurício Meneghini Fauth
87983d1cf5
Add PhpMyAdmin\Dbal\TableName value object class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-22 16:31:10 -03:00
Maurício Meneghini Fauth
229d8dfb5e
Extract Console, Debug and SqlQueryBox classes from Settings
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-19 13:17:32 -03:00
Maurício Meneghini Fauth
73034e43e1
Extract setter methods from Config\Settings classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-18 12:44:48 -03:00
Maurício Meneghini Fauth
f00d70cccb
Remove useless whitespaces
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-15 17:05:40 -03:00
Maurício Meneghini Fauth
9f3510d11a
Add bool return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-14 20:11:51 -03:00
Maurício Meneghini Fauth
03b9016b7d
Merge pull request #17103 from shucontech/nav_modal
Replace hidden navigation items dialog with modal
2021-09-14 17:21:09 -03:00
Shucon Tech
c003c3add8
Replace Range Search dialog with a modal (#17073)
* Replace Range Search dialog with a modal

Signed-off-by: Saksham Gupta <shucontech@gmail.com>
2021-09-14 15:53:00 -03:00
Maurício Meneghini Fauth
7f6472b2c2
Add void return type where possible
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-13 15:29:11 -03:00
Maurício Meneghini Fauth
3f87370978
Suppress strftime deprecation messages for PHP 8.1
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-12 12:25:06 -03:00
Maurício Meneghini Fauth
f61d3183fb
Inline some phpcs ignores and remove deprecated annotations
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-12 11:59:39 -03:00
Maurício Meneghini Fauth
3531775b7c
Add type declarations to the controllers contructors
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 17:32:22 -03:00
Maurício Meneghini Fauth
bfaf16f56b
Use only callable controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 15:20:46 -03:00
Maurício Meneghini Fauth
00cb1b3668
Extract IndexesController::doSaveData method
Creates the Table\Indexes class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-11 14:38:44 -03:00
Maurício Meneghini Fauth
3be84cf9b2
Merge pull request #17078 from lrb2/consolidate-nav-groups
Fix #17003: Consolidate nested groups in navigation tree
2021-09-11 09:37:41 -03:00
Maurício Meneghini Fauth
8031072f27
Merge pull request #17076 from lrb2/fix-table-grouping
Fix grouping of tables in navigation tree if `$cfg['NavigationTreeTableLevel'] > 1`
2021-09-11 09:34:01 -03:00
Maurício Meneghini Fauth
83091680cc
Extract actions from controllers to new controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-10 17:55:05 -03:00
Saksham Gupta
8f04e1a26d Replace hidden navigation items dialog with modal
Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Fix line end

Signed-off-by: Saksham Gupta <shucontech@gmail.com>
2021-09-11 01:37:15 +05:30
Maurício Meneghini Fauth
38fda677bd
Extract Processes class from ProcessesController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-10 15:52:48 -03:00
Maurício Meneghini Fauth
94e714a49b
Extract the Server\ShowEngineController class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09 17:58:00 -03:00
Maurício Meneghini Fauth
dd0f63f18c
Add use statements in services_controllers.php
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09 17:34:09 -03:00
Maurício Meneghini Fauth
701acaaddb
Simplify use statements in the routes definition file
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09 16:39:11 -03:00
Maurício Meneghini Fauth
fb257e5922
Extract actions from Table\StructureController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-09 13:48:07 -03:00
Maurício Meneghini Fauth
e3554879ef
Extract actions from controllers to new controllers
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-07 21:19:43 -03:00
Maurício Meneghini Fauth
96adfe37f4
Extract actions from controllers to new ctrls
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-06 18:30:21 -03:00
Maurício Meneghini Fauth
322dc72621
Merge branch 'QA_5_1'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-05 00:51:20 -03:00
Maurício Meneghini Fauth
9adce40034
Extract controllers from HomeController
Extracts CollationConnectionController, GitInfoController and
RecentTablesListController controllers from HomeController.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-05 00:40:18 -03:00
Maurício Meneghini Fauth
5f4fd07483
Remove some assignments to the $_POST global
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-03 15:49:39 -03:00
William Desportes
68206dbac7
Merge #17089 - Fix #16693, Fix #12753 - Show the new column query and the table structure on the same page
Fixes: #16693
Fixes: #12753

Pull-request: #17089

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-09-03 01:01:47 +02:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
e5e7bd2f95
Access POST params from the ServerRequest class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-09-01 12:52:59 -03:00
William Desportes
4c6061a04e
Merge #17075 - Use int as srid type
Pull-request: #17075

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-31 01:36:18 +02:00
William Desportes
2d307ed062
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-31 00:18:17 +02:00
William Desportes
f7a328842d
Fix #16906 - Fix the caching effect on the feature list
Before this fix you needed to click twice on create tables to see a full list of green checks.
As part of the values where fetched by a global and the feature list values by this $cfgRelation passed as a parameter.

This was visible when the pmadb existed but had no tables in it.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-31 00:08:00 +02:00
Maurício Meneghini Fauth
bd2ef2b8ee
Get post params from ServerRequest class
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 17:45:28 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-30 13:16:29 -03:00
Maurício Meneghini Fauth
53dd6f11b0
Refactor setProperties method of Plugin classes
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-28 16:50:08 -03:00
William Desportes
dc5cf4766b
Fix #16906 - Escape the table name that is checked with backquotes on canAccessStorageTable function
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 04:06:18 +02:00
William Desportes
b0ec0fd112
Fix #16906 - Replace table names with the configuration ones while creating the storage tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 03:55:58 +02:00
William Desportes
576decd1f4
Fix coding standard issues
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 01:46:45 +02:00
William Desportes
c01e681c33
Prevent overriding user setting while auto fixing pma storage
Once the table was created it was overriding the setting. It should respect that the user said the table will be named pma__userconfig_table and not pma__userconfig (the default value).
If the database had the default tables in it, the detection would silently mark them as the right tables totally ignoring the user defined settings for the table names.

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-28 00:05:07 +02:00
William Desportes
b527b13e2d
Old typo fix
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 23:23:22 +02:00
William Desportes
bb2c869e4c
Ref #16906 - Clear the relation cache after the control db was created
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 23:10:50 +02:00
William Desportes
9c0dcc2043
Fix #16906 - Use the control connection to create the storage database and tables
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 23:09:16 +02:00
William Desportes
2ea46aa113
Ref #16906 - Return an error message if the pma storage db could not be selected
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 22:32:56 +02:00
William Desportes
806e2740ba
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-08-27 22:09:55 +02:00
Maurício Meneghini Fauth
f0d9da85f2
Improve type check of Plugins::getDefault method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-27 14:56:12 -03:00
Maurício Meneghini Fauth
86798ec45e
Refactor PhpMyAdmin\Plugins::getChoice method
Extracts the getDefault method from the getChoice method and adds a
getName method to the Plugin interface.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-08-27 13:38:01 -03:00