William Desportes
14d73c1da0
Merge branch 'QA_5_0' into master
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-21 13:03:33 +02:00
Isaac Bennetch
8183b5e854
Merge commit '2d558e45bf' into QA_5_0
2019-10-20 23:10:27 -04:00
William Desportes
2254f66aa8
Fix selenium DbProceduresTest as mysql does not truncate if the input does not allow a longer length than the data given
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-10-19 21:17:06 +02:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
dd3753b8f1
Remove namespace in Selenium tests
...
To improve readability.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-25 17:48:56 -03:00
Maurício Meneghini Fauth
277bf0715f
Use the router for check relations page
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-19 20:28:08 -03:00
William Desportes
d9f2428032
Remove unused imports and fix an error reported by Scrutinizer
2019-06-22 17:55:58 +02:00
William Desportes
6cc352ac12
phpstan level 3 fixes
...
21 errors left
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:37:38 +02:00
Maurício Meneghini Fauth
7be0f6bfae
Reference class names in use statements
...
Sort use statements
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
a6e53e2022
Replace get_class($this) and __CLASS__
...
with static::class and class name
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-06-11 22:54:10 -03:00
Maurício Meneghini Fauth
0b3014207d
Use camel case for most of the js/functions.js variables
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-05-27 00:55:10 -03:00
Maurício Meneghini Fauth
84d9e722d8
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 20:10:36 -03:00
Maurício Meneghini Fauth
73427358f4
Fix QBE selenium test
...
Related to #14536
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 20:07:53 -03:00
Maurício Meneghini Fauth
6bd2dbd5f2
Add support for PHPUnit 8
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
92cc67fbf7
Replace assertContains() with assertStringContainsString()
...
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
73a0ddf1c1
Add void return types to selenium tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 22:05:50 -03:00
Maurício Meneghini Fauth
182491a73f
Add void return type declaration for tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-02-22 21:33:55 -03:00
Maurício Meneghini Fauth
25e480666e
Fix doc comments alignment
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 15:09:32 -02:00
Maurício Meneghini Fauth
23c3579804
Format array declarations
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-07 14:31:39 -02:00
Maurício Meneghini Fauth
4cee0cbc12
Adds space after not (!) and type cast
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-05 21:56:34 -02:00
Maurício Meneghini Fauth
3a7e1503ac
Fix some coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2019-01-04 19:42:10 -02:00
Maurício Meneghini Fauth
0e372eac7e
Fix Table\StructureTest Selenium test
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 22:23:23 -02:00
Maurício Meneghini Fauth
fd656a9511
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 21:01:49 -02:00
Maurício Meneghini Fauth
ebab451e56
Fix TableBrowseTest Selenium test
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-12-21 20:30:44 -02:00
William Desportes
f0b51c144f
Remove unused code in tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-29 19:15:41 +01:00
William Desportes
cc2665121d
phpstan level 2 - fixes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:57 +01:00
William Desportes
bcefdd79fa
phpstan level 2 - Fix phpdoc
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-11-25 13:57:55 +01:00
Maurício Meneghini Fauth
56b7432bde
Fix failing Selenium tests
...
"Other element would receive the click"
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-16 14:45:48 -02:00
Maurício Meneghini Fauth
ced8c35468
Rename database and table Selenium tests
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-03 22:21:03 -03:00
Maurício Meneghini Fauth
235dac6667
Merge branch 'QA_4_8'
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 22:13:17 -03:00
Maurício Meneghini Fauth
9fc76f9215
Add secondary tabs for database query
...
Fixes #13621 QBE selenium tests broken since merge of #13342
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-31 21:52:54 -03:00
Lakshay arora
2a07cee164
Automatically add index while editing an existing row and setting auto increment ( #14417 )
...
* Automates the addition of PRIMARY KEY index when user tries to edit an existing row and set AUTO INCREMENT.
* Disables the popup on insert new column page when user sets AUTO INCREMENT and automatically sets the index to PRIMARY KEY.
Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>
2018-10-23 16:33:36 -03:00
William Desportes
ea830e70b3
Try multiple browsers
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:38 +02:00
William Desportes
862788d782
Migrate tests to facebook/webdriver
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:06 +02:00
William Desportes
d9153ae069
Add TESTSUITE_PORT for selenium tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-10-11 11:30:05 +02:00
William Desportes
e816e45c18
phpstan level 0 ( #14405 )
...
* Fix phpdoc @return
- Fixed @return typehint
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix incorrect case on function calls
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Type hint + typo fix
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fixes
- @return fix
- @var fix
- Class names
- Throws fix
- test/classes/Plugins/Export/ExportSqlTest.php any() invoked with 1 parameter, 0 required
- libraries/classes/Controllers/Table/TableStructureController.php Array has 2 duplicate keys with value 'columns_list'
- Call parent constructor libraries/classes/Error.php
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Update config
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Access to an undefined property
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\PdfRelationSchema::$diagram_row
- Access to an undefined property PhpMyAdmin\Plugins\Schema\Pdf\Pdf::$cMargin
- Undefined properties
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Update config
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix bootstrap-phpstan
Signed-off-by: William Desportes <williamdes@wdes.fr>
* Fix typos and phpstan config
Fixes : #14399
Signed-off-by: William Desportes <williamdes@wdes.fr>
2018-06-25 20:34:46 -03:00
Maurício Meneghini Fauth
2005cca77f
Fix methods and properties visibility issues
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 21:02:26 -03:00
Maurício Meneghini Fauth
285e38e931
Fix some PSR-2 coding standard errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 09:07:56 -03:00
Maurício Meneghini Fauth
b9c0463d96
Use short array syntax instead of long array syntax
...
Replaces array() with [].
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-30 01:42:21 -03:00
Maurício Meneghini Fauth
baf0985e5f
Fix phpcs errors
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-18 01:59:38 -03:00
Maurício Meneghini Fauth
dc8c92bfd8
Enable strict mode in test files
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-16 04:36:04 -03:00
Maurício Meneghini Fauth
c34484a739
Fix TableCreateTest::testCreateTable Selenium test
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
(cherry picked from commit e548d0802b )
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-06 22:15:27 -03:00
Maurício Meneghini Fauth
e548d0802b
Fix TableCreateTest::testCreateTable Selenium test
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-30 01:37:48 -03:00
Maurício Meneghini Fauth
8c0637a282
Upgrade Selenium tests to PHPUnit 6.5
...
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-04-13 00:48:19 -03:00
Gabriel Caruso
6ff73257e2
Simplify returns
...
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
2018-01-16 10:16:56 -02:00
Michal Čihař
c9bdd1b268
Fix class name
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 15:34:36 +01:00
Michal Čihař
a5ebbd9e55
Fix exception handling in selenium tests
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 14:52:18 +01:00
Michal Čihař
7a6f85949a
Fix mysqli class name
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 13:42:52 +01:00
Michal Čihař
1957af5663
Remove PmaSelenium prefix from Selenium tests
...
It is good enough to have Selenium in the namespace.
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 13:10:38 +01:00
Michal Čihař
8b8e68c6bf
Use PSR-4 for loading selenium tests and adjust their names
...
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-18 13:09:01 +01:00