gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
127,704 Commits 12 Branches 481 Tags 2.4 GiB
75cb254309
Commit Graph

456 Commits

Author SHA1 Message Date
Dan Wallis
28443f6723
Send Content-Security-Policy headers in setup/ app (#17751) 
This pull request adds Content-Security-Policy and other security-related headers to the setup/ application, as requested in #12359.

Fixes #12359

Signed-off-by: Dan Wallis <mrdanwallis@gmail.com>
(cherry picked from commit 6e14811a05)
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-10-03 19:47:31 -03:00
Maurício Meneghini Fauth
9b3a1f7734
Merge branch 'QA_5_1-security' into master-security 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 17:41:16 -03:00
Maurício Meneghini Fauth
44eb12f15a
Improve query params filtering in Setup pages 
Note: 'action_done' was not used since
c962ee4287.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2022-01-13 15:05:43 -03:00
Maurício Meneghini Fauth
1e542cd621
Replace vendor_config.php constants with an array 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-12-26 16:48:56 -03:00
Maurício Meneghini Fauth
8f2f3eff40
Remove the Core::isValid method 
This improves the type checking and simplifies the code.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-02 13:20:50 -03:00
Maurício Meneghini Fauth
5725516656
Inline Core::ifSetOr method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-09-01 13:29:05 -03:00
Maurício Meneghini Fauth
a2ed4dfe68
Make controllers callable 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-08-30 13:16:29 -03:00
William Desportes
587536b766
Remove non used variables 
Running: composer run psalm -- --alter --issues=UnusedVariable
And removing the false positives I reported upstream

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-07-16 02:13:27 +02:00
Maurício Meneghini Fauth
a0d91ec153
Move common.inc.php to classes/Common.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 14:00:44 -03:00
Maurício Meneghini Fauth
dc37d436cc
Extract common.inc.php logic to Common::run method 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 13:48:11 -03:00
Maurício Meneghini Fauth
17f4e09a6b
Extract some common checks from common.inc.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 13:27:14 -03:00
Maurício Meneghini Fauth
8e4d6229a9
Fix some errors found by Psalm 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-06 00:37:27 -03:00
Maurício Meneghini Fauth
81de66a019
Merge branch 'QA_5_1' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-05 17:26:46 -03:00
Maurício Meneghini Fauth
282fbe76c5
Fix case where $_SERVER['REQUEST_METHOD'] is undefined 
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/16991

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-05 17:23:32 -03:00
Maurício Meneghini Fauth
76aabc9826
Remove PMA_MINIMUM_COMMON constant 
Replaces it with the `$isMinimumCommon` global variable.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-07-02 01:29:07 -03:00
Maurício Meneghini Fauth
9adaa912e1
Rename Response class to ResponseRenderer 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-06-30 12:35:22 -03:00
Maurício Meneghini Fauth
7e33d227f5
Rename the PMA_Config global variable to config 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-08 15:03:12 -03:00
Maurício Meneghini Fauth
d83abf63e7
Use PSR-12 for control structures spacing 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-03-05 15:27:03 -03:00
Maurício Meneghini Fauth
1911ac6289
Remove Config\FormDisplay dep from Setup\HomeController 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2021-01-03 22:38:27 -03:00
Maurício Meneghini Fauth
b9bffe4cae
Nest CSS styles for setup's _custom.scss 
Removes ul.tabs CSS class.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-31 17:52:16 -03:00
Maurício Meneghini Fauth
9a2989f3ac
Add Bootstrap for Setup pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-31 17:52:16 -03:00
Maurício Meneghini Fauth
ac25371c84
Convert setup CSS styles to Sass format 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-31 11:05:11 -03:00
Saksham Gupta
bf9472b249
Replace style image with Linear-gradient 
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
 2020-12-30 19:03:39 +01:00
Maurício Meneghini Fauth
85a59f730e
Remove unneeded CSS vendor prefixes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-12-27 11:22:49 -03:00
William Desportes
35cdaf4356
Fix #16512 - Add some code securities when the themes folder does not exist 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-12-07 15:02:06 +01:00
Maurício Meneghini Fauth
e7c8e20edb Fix some type errors detected by PHPStan 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-02 00:37:23 -03:00
Ivan Kayzer
da832ef5c4 Fix setup tabs alignment 
Signed-off-by: Ivan Kayzer <ivan.kayzer@outlook.com>
 2020-07-16 20:04:08 +02:00
Maurício Meneghini Fauth
3b285ff17e Use identical operator for non-empty strings 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-10 18:06:29 -03:00
Maurício Meneghini Fauth
58eee2e371 Use early exit when possible 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-27 21:46:12 -03:00
Maurício Meneghini Fauth
bd979dd1ff Remove useless elseif with if 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:53:44 -03:00
Maurício Meneghini Fauth
82c2964bb8 Remove useless elses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 22:27:45 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
William Desportes
81a0fab9b3
Fix coding standard on setup/styles.css 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 11:49:39 +02:00
William Desportes
d93efc2eda
Fix Missing vendor-prefixed CSS gradients for Old Webkit (Safari 4+, Chrome). 
Why is this an issue?
CSS gradients in a cross-browser way requires using many different vendor-prefixed versions. There are currently five different vendor-prefixed versions of CSS gradient:

-ms-linear-gradient and -ms-radial-gradient for Internet Explorer 10+
-moz-linear-gradient and -moz-radial-gradient for Firefox 3.6+
-o-linear-gradient and -o-radial-gradient for Opera 11.10+
-webkit-linear-gradient and -webkit-radial-gradient for Safari 5+ and Chrome
-webkit-gradient for Safari 4+ and Chrome (aka "Old WebKit")
Meaning a simple two-color gradient that works across all browsers must look like this:

 background: -moz-linear-gradient(...); /* FF3.6+ */
 background: -webkit-gradient(...); /* Chrome,Safari4+ */
 background: -webkit-linear-gradient(...); /* Chrome10+,Safari5.1+ */
 background: -o-linear-gradient(...); /* Opera 11.10+ */
 background: -ms-linear-gradient(...); /* IE10+ */
It's easy to forget one or more gradient definitions with all of the various vendor prefix gradients available.
[By Codacy]

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-16 10:54:57 +02:00
William Desportes
076a84d259
Run stylelint on setup CSS styles 
Some errors are unfixed:
setup/styles.css
 459:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 459:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 459:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 460:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 460:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 460:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 461:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 461:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 461:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 462:5  ✖  Unexpected duplicate "background"                            declaration-block-no-duplicate-properties        
 462:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 462:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 473:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 473:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 474:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 474:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 475:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 475:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides
 476:5  ✖  Unexpected shorthand "background" after "background-image"   declaration-block-no-shorthand-property-overrides
 476:5  ✖  Unexpected shorthand "background" after "background-size"    declaration-block-no-shorthand-property-overrides

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-15 23:47:48 +02:00
Maurício Meneghini Fauth
585fdaea5a Fix PHP doc spacing and order 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 18:07:37 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
88cfde2bed Remove empty comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 13:33:38 -03:00
Maurício Meneghini Fauth
63dbcd01d9 Remove or ignore side effects in PHP files 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 20:22:37 -03:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
dd2b05330a Remove useless parentheses 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-12 00:18:01 -03:00
Maurício Meneghini Fauth
e222cb8beb Merge branch 'QA_5_0' 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-21 13:02:14 -03:00
Maurício Meneghini Fauth
08696bc55e Merge branch 'QA_4_9' into QA_5_0 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-21 12:51:04 -03:00
Maurício Meneghini Fauth
427fbed55d Require POST method to delete servers in Setup 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-18 22:40:32 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
b762a24238 Fix missing dbi global initialization on Setup 
Fixes #15337

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-17 19:25:51 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
1510ddcb67 Move Setup JavaScript files to js/setup/ directory 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-02 17:39:44 -03:00
Maurício Meneghini Fauth
e20601571b Fix ESLint errors in setup/scripts.js 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-02 17:39:44 -03:00
Maurício Meneghini Fauth
6f8e53cf5c Rename js/config.js variables to use camel case 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-30 00:42:22 -03:00