gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
106,171 Commits 12 Branches 481 Tags 2.4 GiB
76be1eaa45
Commit Graph

430 Commits

Author SHA1 Message Date
Michal Čihař
b52bd77987 Merge branch 'QA_4_6' 2016-05-23 13:49:00 +02:00
Michal Čihař
f9d6c40939 Safer handling of sessions during authentication 
- always generate new session for login form
- always generate new session when authenticated using cookie auth

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-05-23 13:48:25 +02:00
Michal Čihař
49a1db045e Merge branch 'QA_4_6' 2016-05-23 08:43:51 +02:00
Michal Čihař
24bb12793d Fix locking issues when importing SQL 
When running import (or generally any SQL query), some tables might be
locked. This will cause queries to not locked tables to fail. And this
is exacly what we do with control user link.

So let's have separate link for control queries even if we're using same
credentials as for main link.

Fixes #12219

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-05-23 08:42:08 +02:00
Michal Čihař
ca5eb903b0 Make ThemeManager a singleton instead of storing it in the session 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-05-11 15:34:25 +02:00
Michal Čihař
9182a4d3a1 Move error checking to the Config class 
Also fix not working checking error on the defaults.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-11 16:17:02 +02:00
Michal Čihař
3e2029e750 Move MySQL charsets handling to the Charsets class 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-11 12:55:42 +02:00
Michal Čihař
cd4008b3d7 Move MySQL charset maps to separate class 
This allows us to load it only when needed

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-11 10:33:40 +02:00
Michal Čihař
3e8145a4a5 Remove unused variable mysql_collations_flat 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-11 10:21:53 +02:00
Michal Čihař
f4e16addb7 Merge remote-tracking branch 'origin/pull/12147' into tmp 2016-04-07 09:39:21 +02:00
Michal Čihař
f58349481d Avoid destroying already initalized gettext variables 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-06 10:13:40 +02:00
Michal Čihař
a65a4213d7 Load gettext before autoloader 
This fixes possible PHP error in SQL parser as it tries to define __()
if it's not existing. Later loading of gettext just breaks this.

Fixes #12154

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-04-05 09:24:15 +02:00
Madhura Jayaratne
e6a3e76cfb Fix #12143 Cannot login with certain password 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2016-03-31 21:00:59 +11:00
Michal Čihař
f5393eff61 Remove code mentioning register_globals 
This was removed in PHP 5.4.0 so we really do not have to care anymore.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-03-08 15:30:24 +01:00
Michal Čihař
3bda9a03b9 Move Kanji encoding handling to Encoding class 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-03-08 14:55:41 +01:00
Michal Čihař
4ed47fc4b4 Move charset conversion to a class 
Also removes ancient support for AIX iconv.

Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-03-08 14:05:59 +01:00
Michal Čihař
1b9ea10f11 Move logging helpers to class 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-03-08 11:14:28 +01:00
Michal Čihař
912bf964c7 Replace embedded php-gettext library with motranslator 
Fixes #12018

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-24 11:49:43 +01:00
Durgesh
6650f7b07d Refactor text sanitization and javascript escaping, Issue #11989, #11988 
Signed-off-by: Durgesh <007durgesh219@gmail.com>
 2016-02-22 14:45:19 +05:30
Durgesh
0b64827930 Refactored url parmeters generating, Issue #11990 
Signed-off-by: Durgesh <007durgesh219@gmail.com>
 2016-02-22 14:36:41 +05:30
Michal Čihař
cec39a3d77 Do not destroy gettext global variables 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-22 08:05:49 +01:00
Michal Čihař
faa87a31c8 Load gettext earlier 
It's used by SQLParser, so it should be included before autloader.

See #11677

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-22 08:05:49 +01:00
Michal Čihař
38482bfa9f Use Componser autloader for external libraries 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-22 08:03:19 +01:00
Michal Čihař
1894e33753 Merge branch 'QA_4_5' into QA_4_6 2016-02-12 12:44:06 +01:00
Michal Čihař
e50a445d17 Define is_ajax_request earlier 
This fixes PHP warning on configuration errors.

Fixes #11950

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-12 12:43:30 +01:00
Michal Čihař
3ebacb0025 Simplify loading of vendor configuration 
Do it just once and very early, so that all scripts can rely on it being
available.

Fixes autoloading of phpseclib.

Fixes #11914

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-09 11:00:54 +01:00
Michal Čihař
ae1ccf3e6a Remove PmaAbsoluteUri configuration directive 
Fixes #11412

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-03 17:41:29 +01:00
Michal Čihař
1e9e14d23b Remove ForceSSL configuration directive 
In most setups we simply do not have enough information to decide
whether user has come through HTTPS or not leading to infinite
redirects.

Anyway this is better to handle at web server side together with setting
HSTS headers.

Issue #11412, #11883

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-02-03 14:20:11 +01:00
Michal Čihař
ed96969ff9 Merge branch 'QA_4_5' 2016-01-28 09:23:27 +01:00
Michal Čihař
d4b9c22c1f Enable localization before redirect 
This is needed in case of IIS which needs full HTML response.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-27 08:56:24 +01:00
Michal Čihař
f83b52737e Do not process subforms with PMA_MINIMUM_COMMON 
In such case needed infrastructure is not loaded, so related code won't
work anyway.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-26 14:35:08 +01:00
Michal Čihař
85ccdbb5b9 Include common libraries in setup 
We use PMA_fatalError which in turn needs Response and related objects.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-26 14:27:38 +01:00
Michal Čihař
ec0e88e37e Use hash_equals for comparing token 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-19 08:32:07 +01:00
Madhura Jayaratne
f2a60e54f4 canvg.js does not seem to be used anymore 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2016-01-14 14:05:03 +11:00
Michal Čihař
342c9a25b5 Switch languge selection to LanguageManager 
Issue #11847

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-12 14:51:07 +01:00
Michal Čihař
3ecafc5973 Move mysql_charset_map to common.inc.php 
It should be later removed (as it's IMHO not needed), but we move it out
of select_lang.inc.php where it really doesn't belong.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-12 14:50:13 +01:00
Michal Čihař
ff21ad8e0e Remove unused use 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-12 14:49:40 +01:00
Michal Čihař
55b317c699 Remove /*overload*/ prefix from mb_* calls 
I believe this was temporary flagging to see which code is migrated and
can be safely removed now.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2016-01-04 16:35:28 +01:00
Marc Delisle
911f8274c7 Clarify class and variable name 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2015-12-31 08:09:47 -05:00
Michal Čihař
3cc092258f Merge branch 'QA_4_5' 2015-12-28 10:07:23 +01:00
Michal Čihař
1abdeb5741 Set PHP's internal encoding to UTF-8 
Without setting default_charset, user might have set something different
leading to various problems when encoding to html entities.

Fixes #11785

Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-28 10:05:46 +01:00
Michal Čihař
cc07b737dc Remove unused PMA_String class 
The class is no longer used:

- the ctype part is not needed by new SQL parser
- the utf-8 manipulation was replaced by direct usage of mbstring

Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-21 12:09:06 +01:00
Michal Čihař
7de390f26a Move theme initialization to ThemeManager 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-09 08:34:09 +01:00
Michal Čihař
1deac94062 Move PHP extensions check to separate function 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-09 08:24:41 +01:00
Michal Čihař
c4cdd16342 Move PATH_INFO cleanup to function 
Issue #11731

Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-09 08:22:03 +01:00
Michal Čihař
4d9dc457bd Update comment to match current requirements 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-09 07:50:54 +01:00
Michal Čihař
7facd526b1 Remove code for PHP < 5.4 
Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-09 07:50:02 +01:00
Michal Čihař
7181f2d22d Remove magic_quotes_gpc handling 
This has been removed in PHP 5.4.0 and we support 5.5.0 or newer only.

Signed-off-by: Michal Čihař <michal@cihar.com>
 2015-12-09 07:36:34 +01:00
Marc Delisle
ab7942be89 Fix merge conflicts 
Signed-off-by: Marc Delisle <marc@infomarc.info>
 2015-11-29 07:29:32 -05:00
Madhura Jayaratne
0a2b037706 merge db_create.php into ServerDatabasesController 
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
 2015-11-24 20:41:40 +11:00