Commit Graph

757 Commits

Author SHA1 Message Date
Maurício Meneghini Fauth
5194b81e27
Check if PMA_Theme is instanceof Theme
Instead of checking if is not null.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-27 12:11:36 -03:00
William Desportes
011faf3808
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-24 00:59:36 +01:00
William Desportes
ed36df4116
Fix "Uncaught TypeError: Argument 1 passed to PhpMyAdmin\Core::downloadHeader()"
Fatal error: Uncaught TypeError: Argument 1 passed to PhpMyAdmin\Core::downloadHeader() must be of the type string, null given,
called in libraries/classes/Controllers/TransformationWrapperController.php on line 171 and defined in 
libraries/classes/Core.php:617 Stack trace: #0 
libraries/classes/Controllers/TransformationWrapperController.php(171): PhpMyAdmin\Core::downloadHeader(NULL, 'application/oct...') #1 
libraries/classes/Routing.php(92): PhpMyAdmin\Controllers\TransformationWrapperController->index(Array) #2 
index.php(18): PhpMyAdmin\Routing::callControllerForRoute('/transformation...', Object(FastRoute\Dispatcher\GroupCountBased), Object(Symfony\Component\DependencyInjection\ContainerBuilder)) #3 {main} thrown in 
libraries/classes/Core.php on line 617

Signed-off-by: William Desportes <williamdes@wdes.fr>
2021-01-23 00:03:55 +01:00
Florian Schirmer
fec6d65d96
Fix BLOB JPG preview thumbnail
Signed-off-by: Florian Schirmer <jolt@tuxbox.org>
2021-01-22 23:43:50 +01:00
Maurício Meneghini Fauth
c2bec44e23
Fix an error found by PHPStan
Cherry-pick: 89b09159d0

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-13 23:06:14 +01:00
Maurício Meneghini Fauth
4f574e53c3
Replace error report jquery-ui's dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 17:28:23 -03:00
Maurício Meneghini Fauth
d570ad5a38
Replace db structure bulk action dialog with a modal
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 14:50:59 -03:00
Maurício Meneghini Fauth
54afeca51a
Replace jQuery UI dialog with Bootstrap's modal
Replaces "make consistent with central list" confirmation dialog written
with jQuery UI with Bootstrap's modal component.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-12 14:41:53 -03:00
Maurício Meneghini Fauth
a1d1ab85cb
Split rte.js into routines.js, triggers.js and events.js
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-11 17:02:50 -03:00
Maurício Meneghini Fauth
89dba07132
Remove rte.js dependency from navigation.js
Only loads the rte.js file for the RTE pages.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-10 12:43:12 -03:00
Maurício Meneghini Fauth
89b09159d0
Fix an error found by PHPStan
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-06 16:59:04 -03:00
Maurício Meneghini Fauth
53f5247811
Merge FormDisplay::getDisplay templates
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-05 19:25:21 -03:00
Maurício Meneghini Fauth
d042998f6a
Remove FormDisplayTemplate dep from Setup\ConfigController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-04 14:04:32 -03:00
Maurício Meneghini Fauth
1911ac6289
Remove Config\FormDisplay dep from Setup\HomeController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-03 22:38:27 -03:00
Maurício Meneghini Fauth
65dd7e8278
Wrap settings tabs with Bootstrap's cards
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2021-01-02 18:51:11 -03:00
William Desportes
0605f38d9a
Merge branch 'QA_5_1'
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-31 23:31:51 +01:00
Paul Gomez
23e23e3b3b
Added "Build Query" button to Visual Query Builder #16485
There was a ```if not visual_builder ``` that kept it from displaying. I did a search to see if that value is supplied and what it would mean.

Signed-off-by: Paul Gomez <pauldro952@hotmail.com>
2020-12-31 23:22:50 +01:00
Maurício Meneghini Fauth
9a2989f3ac
Add Bootstrap for Setup pages
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-31 17:52:16 -03:00
Maurício Meneghini Fauth
00151b5f1c
Remove some custom CSS utilities
Uses Bootstrap equivalents instead.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-22 13:18:58 -03:00
William Desportes
b826234ebb
Fix #16526 - Fatal error: Uncaught TypeError: preg_replace(): Argument #3 ($subject)
Fatal error: Uncaught TypeError: preg_replace(): Argument #3 ($subject) must be of type array|string, null given in libraries/classes/Controllers/Setup/HomeController.php:30 

Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-11 21:05:06 +01:00
Maurício Meneghini Fauth
dbaa031971
Remove jquery.sortableTable.js from js/vendor dir
It is not a vendor file, but a internal file.
Added by commit 1c6a388ca0.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-08 21:37:11 -03:00
William Desportes
35cdaf4356
Fix #16512 - Add some code securities when the themes folder does not exist
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 15:02:06 +01:00
William Desportes
2141d81e7e
Fix #16520 - $cfg['ShowDatabasesNavigationAsTree'] = false; on select not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-12-07 14:35:05 +01:00
Maurício Meneghini Fauth
3c6955fed5
Move tables export to Database\ExportController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-12-06 14:08:36 -03:00
Maurício Meneghini Fauth
acd214c9b7
Merge branch 'QA_5_0'
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:58:18 -03:00
Maurício Meneghini Fauth
0ed9c23c1e
Fix uncaught TypeError when editing partitioning
When the partition has subpartitions.
https://github.com/phpmyadmin/phpmyadmin/issues/14494

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:50:18 -03:00
Maurício Meneghini Fauth
3a25c96543
Create truncate table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:36:05 -03:00
Maurício Meneghini Fauth
f419ce4f2e
Create repair table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:32:34 -03:00
Maurício Meneghini Fauth
905f48184f
Create rebuild table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:29:01 -03:00
Maurício Meneghini Fauth
42cf71d8aa
Create optimize table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:22:19 -03:00
Maurício Meneghini Fauth
0c38913c15
Create drop table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 22:16:46 -03:00
Maurício Meneghini Fauth
b64be69dd8
Create analyze table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 21:29:27 -03:00
Maurício Meneghini Fauth
f8df25487f
Create check table partition page
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 21:09:32 -03:00
Maurício Meneghini Fauth
73f21d6950
Extract drop partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-30 15:01:41 -03:00
Maurício Meneghini Fauth
194c8372cc
Extract truncate partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-29 17:02:03 -03:00
Maurício Meneghini Fauth
1d4dea8e47
Extract repair partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-29 16:44:32 -03:00
Maurício Meneghini Fauth
1c0218aff7
Extract rebuild partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-29 16:12:34 -03:00
Maurício Meneghini Fauth
5577d9ecb7
Extract optimize partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-29 15:26:37 -03:00
Maurício Meneghini Fauth
6e4a9e82a0
Extract check partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-29 14:20:38 -03:00
Maurício Meneghini Fauth
aeac7177da
Extract analyze partition action to a new route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-29 12:21:21 -03:00
William Desportes
ed0c44a621
Update files to follow new coding standard rules
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-16 19:36:52 +01:00
Maurício Meneghini Fauth
0a4b10ba5e
Remove toggle button generator
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-14 13:17:03 -03:00
William Desportes
3dad3b5e5d
Merge #15912 - Fix #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL
Issue: #14953
Pull-request: #15912
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-13 23:47:33 +01:00
Maurício Meneghini Fauth
b268491bd8 Replace exit with return in GetFieldController
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-13 19:28:21 -03:00
Maurício Meneghini Fauth
71a41c2813 Extract export time out checking route
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-13 18:26:16 -03:00
William Desportes
d860597375
#16418 - Make MariaDBMySQLKBS optional
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-10 12:12:56 +01:00
Kartik Kathuria
b2039444bf
Fixes #14953 - Added Rename Button to use RENAME INDEX syntax of MySQL
Co-Authored-By: William Desportes <williamdes@wdes.fr>

Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
2020-11-05 15:22:16 +01:00
Maurício Meneghini Fauth
c11e8d5f64 Remove Common::database method
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:56:58 -03:00
Maurício Meneghini Fauth
ef62d7a9f5 Remove is_system_schema PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00
Maurício Meneghini Fauth
71c2f2d99a Remove is_show_stats PHP global variable
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-02 18:48:23 -03:00