Maurício Meneghini Fauth
b43e351668
Fix broken tests related to #16486
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-11-16 21:35:04 -03:00
William Desportes
50e900a1bf
Remove all @test annotations
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-11-08 23:01:26 +01:00
Maurício Meneghini Fauth
db3da81056
Remove some useless comments
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
e66be179ca
Use camel case naming for class members
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-10-05 10:37:07 -03:00
Maurício Meneghini Fauth
ceac762e09
Remove pmaThemePath and pmaThemeImage PHP globals
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
ba09c84a05
Fix PHPStan errors for PHPUnit assert methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-08-10 16:20:53 -03:00
William Desportes
cce4bc993c
Fixes #16278 - Fix tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-08-06 15:48:08 +02:00
William Desportes
a80153a633
Add typehints using phpcbf on test/*
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
652c55a5ef
Remove Config\PageSettings::getNaviSettings method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 17:40:19 -03:00
Maurício Meneghini Fauth
f8320956ee
Remove Config\PageSettings::showGroup method
...
Related to https://github.com/phpmyadmin/phpmyadmin/issues/16258 .
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-12 16:01:18 -03:00
Maurício Meneghini Fauth
47f0960dce
Add return type declaration to test methods
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
e81146e4b3
Remove useless return annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-07-07 10:30:27 -03:00
William Desportes
3f0b7390e2
Fix documentation after removing _ from private methods
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-06-02 23:56:48 +02:00
charliewindred
7d792e88f6
Removed underscores from unit test methods
...
Removed underscore prefixes from unit test method calls.
Signed-off-by: charliewindred <charliewindred@gmail.com>
2020-06-02 23:52:32 +02:00
Maurício Meneghini Fauth
e2eac49ad2
Use closures to call private methods as callback
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-30 13:14:06 -03:00
Maurício Meneghini Fauth
f4582e083e
Use early exit when possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-27 00:35:24 -03:00
Maurício Meneghini Fauth
3ae05c785d
Use short list syntax and single line arrays
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4
Fix some coding standard issues
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-05-25 20:22:18 -03:00
William Desportes
4134f34b54
Fix tests for seed 590128958
...
Seed: 590128958
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 09:50:27 +02:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-22 01:45:50 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 16:21:20 +02:00
William Desportes
fe32a359dc
Move PMA_VERSION calls into defineVersionConstants() for tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:26:48 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig();
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:31:13 +02:00
William Desportes
8ef5143901
Use AbstractTestCase on all unit tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:15:06 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order
...
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest
Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-20 12:15:40 +02:00
William Desportes
947f9ad04f
Remove some unused code detected by codacy
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-05-15 23:57:22 +02:00
William Desportes
43aecb2f3b
Fix failing FormDisplayTemplateTest::testDisplayTabsTop after merge of #15915
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-12 02:59:49 +02:00
William Desportes
8a829f0554
Add some comments for a deprecation in phpunit 10
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-04-05 16:05:33 +02:00
William Desportes
7f90a6172a
Fix some broken tests on Windows CI because of line endings
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-02-22 17:52:00 +01:00
William Desportes
3059c99bda
Merge branch 'QA_5_0'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-28 19:47:20 +01:00
Maurício Meneghini Fauth
206199105e
Remove useless return type annotations
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-23 13:03:29 -03:00
William Desportes
6dfa603f0c
Add test for Form::cleanGroupPaths
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2020-01-22 23:07:40 +01:00
Maurício Meneghini Fauth
676f48349a
Reference global funcs and consts via use statement
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4
Remove unnecessary annotations
...
@package, @subpackage and others.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf
Use one line for comments with a single line
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
50bc4ab37f
Remove useless PHP docs for functions
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2020-01-20 13:20:01 -03:00
Maurício Meneghini Fauth
39f42f848b
Remove some useless docblock comments
...
Fixes docblock spacing
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e
Remove unused use statements
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
dd06cd38f8
Defines rules for double quote usage
...
Makes sure that any use of double quotes strings are warranted.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
8a0aa251fe
Replace some custom CSS utilities with Bootstrap equivalents
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-11-12 19:35:37 -03:00
Oleg Abrazhaev
c0a93fadf7
fix test
...
Signed-off-by: Oleg Abrazhaev <seyferseed@gmail.com>
2019-10-27 15:05:34 +01:00
Maurício Meneghini Fauth
1a14b3e4d3
Remove vim modelines
...
These settings are no longer required as they are guaranteed through
other coding standard tools.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
333b68eb45
Fix PageSettingsTest failing test
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-23 14:50:56 -03:00
Maurício Meneghini Fauth
8ab7e28a98
Fix selfurl not containing the route parameter
...
Adds route parameter and removes empty parameters from selfurl.
Fixes #15418
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-08-08 01:59:48 -03:00
Maurício Meneghini Fauth
4537dcc774
Fix failing tests
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-07-20 18:16:08 -03:00
William Desportes
996975262f
Improve ConfigFileTest::tearDown
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 17:41:54 +02:00