gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
121,354 Commits 12 Branches 481 Tags 2.4 GiB
7bcccf7bdc
Commit Graph

67 Commits

Author SHA1 Message Date
William Desportes
7a3978a948
Remove useless htmlspecialchars on URL generation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2021-04-13 17:23:12 +02:00
William Desportes
50e900a1bf
Remove all @test annotations 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-11-08 23:01:26 +01:00
Maurício Meneghini Fauth
db3da81056 Remove some useless comments 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-10-13 19:56:56 -03:00
Maurício Meneghini Fauth
ceac762e09 Remove pmaThemePath and pmaThemeImage PHP globals 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-09-02 10:57:57 -03:00
Maurício Meneghini Fauth
ba09c84a05 Fix PHPStan errors for PHPUnit assert methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-08-10 16:20:53 -03:00
William Desportes
a80153a633
Add typehints using phpcbf on test/* 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-07-17 22:52:42 +02:00
Maurício Meneghini Fauth
47f0960dce Add return type declaration to test methods 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-07-07 11:31:33 -03:00
Maurício Meneghini Fauth
dfa5f92c31 Add return type declaration to fetch row methods 
DatabaseInterface's fetchArray, fetchAssoc, fetchRow and fetchSingleRow
methods.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-06-29 20:32:04 -03:00
William Desportes
3683e4b022
Remove not needed if in NodeViewTest after 7623fed14a 
Ref: 7623fed14a

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-03 00:37:12 +02:00
William Desportes
62baf0b8ea
Change Node::getChild return to ?Node 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 23:10:35 +02:00
William Desportes
82d7328d84
Fix failing test NavigationTreeTest 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-06-02 22:55:03 +02:00
William Desportes
a300a25319
Replace assertEquals({false,true} by assert{false,true} 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-26 13:13:15 +02:00
Maurício Meneghini Fauth
3ae05c785d Use short list syntax and single line arrays 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-26 03:32:59 -03:00
Maurício Meneghini Fauth
3baad2eb1c Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 22:42:37 -03:00
Maurício Meneghini Fauth
9269d75fb4 Fix some coding standard issues 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-05-25 20:22:18 -03:00
William Desportes
49a6d6e8d0
Use AbstractTestCase instead of PmaTestCase for all tests not needing mockResponse 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-22 01:45:50 +02:00
William Desportes
ae575ffb14
Fix running tests in --process-isolation 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 16:21:20 +02:00
William Desportes
0964470643
Use parent::setGlobalConfig(); 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 13:19:23 +02:00
William Desportes
8f7d3d1fa7
Fix test cases after backupGlobals = false 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-21 02:07:45 +02:00
William Desportes
6eaa55e805
Call parent's setUp and tearDown 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:31:13 +02:00
William Desportes
f063c553f2
Fix some tests executed in random order 
Using: ./vendor/bin/phpunit --order-by=random --random-order-seed=1589977275 --exclude=selenium --no-coverage --filter=FormDisplayTest

Seeds: 1590000479, 1589977275, 1589998302, x1590001040, x1590001183

Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 21:10:32 +02:00
William Desportes
0b2c24ee26
Use ::class in tests 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2020-05-20 12:15:40 +02:00
Maurício Meneghini Fauth
206199105e Remove useless return type annotations 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-23 13:03:29 -03:00
Maurício Meneghini Fauth
676f48349a Reference global funcs and consts via use statement 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-21 22:13:36 -03:00
Maurício Meneghini Fauth
f80d3e3bd4 Remove unnecessary annotations 
@package, @subpackage and others.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 17:35:56 -03:00
Maurício Meneghini Fauth
6283caaabf Use one line for comments with a single line 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-20 16:04:09 -03:00
Maurício Meneghini Fauth
285907991e Add coding standard rules for whitespace 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2020-01-19 22:29:54 -03:00
William Desportes
fa01cea3f2
Add phpdoc blocks for phpstan 
Signed-off-by: William Desportes <williamdes@wdes.fr>
 2019-12-29 15:28:18 +01:00
Maurício Meneghini Fauth
39f42f848b Remove some useless docblock comments 
Fixes docblock spacing

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-13 21:15:00 -03:00
Maurício Meneghini Fauth
77518d341e Remove unused use statements 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-11 21:20:58 -03:00
Maurício Meneghini Fauth
f97d957f00 Add PHPStan PHPUnit extensions and rules 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-07 15:32:32 -03:00
Maurício Meneghini Fauth
dd06cd38f8 Defines rules for double quote usage 
Makes sure that any use of double quotes strings are warranted.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-12-01 14:10:07 -03:00
Maurício Meneghini Fauth
1a14b3e4d3 Remove vim modelines 
These settings are no longer required as they are guaranteed through
other coding standard tools.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-09-02 09:43:21 -03:00
Maurício Meneghini Fauth
74ac30fa55 Use the router for navigation.php 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-19 23:04:55 -03:00
Maurício Meneghini Fauth
13fe20c00d Use the router for the table indexes page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-15 23:19:01 -03:00
Maurício Meneghini Fauth
616cc8d901 Use the router for the triggers page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-07 16:08:46 -03:00
Maurício Meneghini Fauth
74f8246fd5 Use the router for the database routines page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-07 01:53:31 -03:00
Maurício Meneghini Fauth
1b39e5e346 Use the router for the database events page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-06 00:57:08 -03:00
Maurício Meneghini Fauth
208b0e25e1 Use the router for the sql pages 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-08-03 21:25:27 -03:00
Maurício Meneghini Fauth
aec0402679 Use the router for table structure page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-19 20:18:06 -03:00
Maurício Meneghini Fauth
682e7a160e Use the router for database structure page 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-07-18 14:33:43 -03:00
Maurício Meneghini Fauth
7be0f6bfae Reference class names in use statements 
Sort use statements

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-12 00:14:26 -03:00
Maurício Meneghini Fauth
990f801123 Use camel case names in Navigation classes 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-06-11 20:55:34 -03:00
Maurício Meneghini Fauth
defd6761ba Add ChangeLog entry for #14890 
Display column details in navigation bar

- Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-05-01 15:20:55 -03:00
Maurício Meneghini Fauth
5254ec1b65 Refactor Navigation\NavigationTree 
- Extract HTML from renderState() and renderDbSelect()
- Use DI for $dbi instead of global
- Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-24 02:25:48 -03:00
Maurício Meneghini Fauth
7d199a7bc2 Fetch dbi from DI instead of global in Navigation class 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-23 16:43:16 -03:00
Maurício Meneghini Fauth
1d0dad5cd6 Extract HTML from Navigation::getItemUnhideDialog() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-23 16:24:55 -03:00
Maurício Meneghini Fauth
c642c29aa4 Extract HTML from Navigation::getDisplay() 
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
 2019-04-22 15:57:16 -03:00
Maurício Meneghini Fauth
92cc67fbf7 Replace assertContains() with assertStringContainsString() 
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-24 16:32:28 -03:00
Maurício Meneghini Fauth
182491a73f Add void return type declaration for tests 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
 2019-02-22 21:33:55 -03:00