Commit Graph

94 Commits

Author SHA1 Message Date
William Desportes
aab50ab37a
Replace $_REQUEST by $_GET and $_POST for GIS visualisation
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:16:42 +02:00
William Desportes
bbac072fb5
Fix #15334 - export of GIS visualisation not working
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-06-22 14:14:52 +02:00
Eugene Kazakov
9edcc5e43a Bug #10846 TypeError: Cannot read property 'substring' of undefined
Signed-off-by: Eugene Kazakov <ekazakov@plesk.com>
2019-05-31 18:21:30 +02:00
William Desportes
d0cb22a819
Fix #13854 - Column options are ignored for GENERATED/VIRTUAL/STORED columns
Fixes: #13854
Pull-request: #15278
Pull-request: #15275
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 20:10:57 +02:00
Michael Voříšek
b09bd204c9 Fix generate field SQL for MySQL virtual columns
Fix issue #13854, based on official syntax:
column_definition: https://dev.mysql.com/doc/refman/5.7/en/create-table.html

Signed-Off-By: Michael Voříšek <mvorisek@mvorisek.cz>
2019-05-19 14:10:52 +02:00
William Desportes
35fcea7df6
Fix #14621 - add "Propose table structure" on MariaDB
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-19 00:33:11 +02:00
William Desportes
89f8b16dcd
Fix #14383 #12865 - Fix GIS functions for mysql 8.0
Fixes: #14383
Fixes: #12865
Pull-request: #15149
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-05-01 17:09:24 +02:00
William Desportes
ca3f027f7e
Fix #13178 - Issues with uppercase table and database names
Fixes: #13178
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-28 21:32:31 +02:00
William Desportes
c745aab360
Fix php notice Undefined index: mysqlVersion
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 13:21:30 +02:00
William Desportes
3399e5babd
Fix spatial functions
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 11:11:28 +02:00
William Desportes
9ed068aacb
Fix #14383 #12865 - Fix GIS functions for mysql 8.0
Fixes: #14383
Fixes: #12865
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-16 11:11:28 +02:00
William Desportes
ab748e2fac
Fix some potential php notices after merge of #15040
[ci skip]
See: 3d3d1a2b08
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-04-01 23:27:15 +02:00
apoorv
bca847f227 Fix #15010 - Sql preview show empty modal
Signed-off-by: apoorv <apoorvkhare007@gmail.com>
2019-03-26 23:48:58 +01:00
Nitish Bahl
2b0a36eb21 Fix #14926 - Filling existing fields form while editing a view
Fix: #14926
See: #14916
Signed-off-by: Nitish Bahl <nitishbahl24@gmail.com>
Signed-off-by: William Desportes <williamdes@wdes.fr>
2019-03-25 22:31:29 +01:00
Maurício Meneghini Fauth
75eb905727 Fix wrong property name on TableStructureController
Introduced by 963ace6ada

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2019-03-19 14:31:10 -03:00
Madhura Jayaratne
e7f1e2697a Retrieve parameters from $_POST in server variables 2018-12-04 19:08:16 +11:00
Maurício Meneghini Fauth
6fd9bfb75b Retrieve parameters from $_POST in table search
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
34972f0132 Retrieve parameters from $_POST in server binlog
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d1d90b59b2 Retrieve parameters from $_POST in table relation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
d01ece698a Retrieve parameters from $_POST in tbl_indexes.php
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:59 -02:00
Maurício Meneghini Fauth
9219b28f47 Retrieve parameters from $_POST in table structure
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-11-10 20:48:58 -02:00
Madhura Jayaratne
5d781422fb Retrieve parameters from $_POST in server_databases page
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-11-10 20:48:58 -02:00
Alessandro Dolci
fd3dde47a6 Fixed condition on the emptiness of enum type criteriaValues array (#14648)
The if condition has a call to the empty function on the criteriaValues array, but in the considered case that array only contains a '0', so this makes it look empty to the function. I added a control on the first element of the array, to avoid this specific situation.
It's my first contribution, so I hope I did well with the branches. Let me know if there's something missing or to do, I'm happy to help.

Signed-off-by: Alessandro Dolci <alessandro.dolci@pm.me>
(cherry picked from commit 3f5fff3f4d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-10-30 21:09:02 -03:00
Lakshay arora
b0ec6b69e9 Fix for #14314, error while naming a database '0'
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
2018-06-29 10:40:54 -04:00
Lakshay arora
0da5857b5d Fix for issues with spatial fields (#14125)
*  Fix for issues with spatial fields

Fixes the following issues:

1.    #14068 SPATIAL fields with no unique index/autoincrement error when clicking
      This error occurs when there is no unique column to uniquely identify a tuple. I've disabled the geomtery view and made view as wkt the default view in such cases.

2.    #14121 View spatial fields as WKT doesn't work

1.    #14067 IS NULL search operator produces no WHERE SQL with spatial fields

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields
This commit fixes view as BINARY not working in the previous commit.
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

* Fix for issues with spatial fields

Fixes typo in previous commits.

Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
(cherry picked from commit 9231620c2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-12 03:54:28 -03:00
Maurício Meneghini Fauth
de250fbae3 Fix MariaDB 10.2 current_timestamp()
Fixes #13968 and fixes #13999. Closes #14177.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-05-08 07:39:53 -03:00
Madhura Jayaratne
7b27484897 Fix #14239 Line and some other charts ignore result set order of values chosen for the x-axis
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
2018-05-06 08:59:06 +10:00
Maurício Meneghini Fauth
d98658187a Replace PhpMyAdmin\Relation static calls
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-03-25 19:32:13 -03:00
Xinyu Liu
7391d872a9 Fix improperly escaped HTML code in database structure page #14071
Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
2018-03-19 08:06:33 +00:00
Maurício Meneghini Fauth
741a50a905 Merge branch 'QA_4_7' 2018-03-12 19:24:44 -03:00
Maurício Meneghini Fauth
0889b52c36 Replace static methods with instance methods
Replace PhpMyAdmin\Sql static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-27 17:39:16 -03:00
Maurício Meneghini Fauth
79ab4f4a50 Use DI for DatabaseInterface instance
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 15:04:37 -02:00
Maurício Meneghini Fauth
dc04987a68 Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-15 12:31:04 -02:00
Maurício Meneghini Fauth
4c661bd1fd Move current server user global to constructor
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
e2a648881c Move DatabaseInterface object to constructor
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
dc2b2d4f6c Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2018-02-04 16:37:27 -02:00
Maurício Meneghini Fauth
39198725fe Use CSS to hide table structure action buttons
Fix #13694

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-12-31 18:25:21 -02:00
Michal Čihař
c162a75b9b Improve javascript loading
- jquery-ui-timepicker-addon.js is loaded in Header, no need to load it
  elsewhere
- jquery.validate.js is needed on way to many pages to benefit of
  loading only on some of them

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-12-15 08:36:23 +01:00
Michal Čihař
77f0d50bea Add missing dependency on jquery.validate.js
Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-29 15:09:43 +01:00
Michal Čihař
bed6fb4ebd Avois passing extension to Util::getImage
We do not use it anyway for quite some time and this way it's less
processing to generate the img tag.

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-27 14:24:42 +01:00
Michal Čihař
868bb18c98 Better deal with unitialized page
Fixes #13814

Signed-off-by: Michal Čihař <michal@cihar.com>
2017-11-16 16:39:28 +01:00
Maurício Meneghini Fauth
cc2c4fc36d Replace globals with DI in Charsets class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-09 11:31:42 -02:00
Maurício Meneghini Fauth
5a70c1d895 Replace globals with DI in CentralColumns class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-05 22:21:58 -02:00
Maurício Meneghini Fauth
e631affbf3 Remove unnecessary include_once
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 16:10:22 -02:00
Maurício Meneghini Fauth
452b624dc4 Move dependencies to outside of abstract controllers
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-04 12:41:57 -02:00
Maurício Meneghini Fauth
2ae2b8b54e Use template for server databases table
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-03 11:31:01 -02:00
Maurício Meneghini Fauth
ff38d5c5eb Move sub page header to index template
Move server/sub_page_header template from ServerDatabasesController
to server/databases/index template

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
79f6f88bff Use template for server sub page header
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
6672d4f2ea Use template for server databases index
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-02 22:26:47 -02:00
Maurício Meneghini Fauth
569ee91f2a Merge branch 'master' into templates
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
2017-11-01 12:06:09 -02:00