Maurício Meneghini Fauth
83e8ed59cc
Remove Config object from the Window global object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-30 22:00:29 -03:00
Maurício Meneghini Fauth
5f7ab155fd
Update Psalm and PHPStan baselines
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-30 15:46:06 -03:00
MoonE
4e529ae399
Refactor gis color ( #17895 )
...
* Use int srid in gis tests
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
* Typecheck gis color
Only use array<int> as color
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
2022-11-30 14:49:06 -03:00
ru-asdx
eff7e23b60
Ref #17769 - Replace superglobals with ServerRequest in Server/Status ( #17912 )
...
* Replace superglobals with ServerRequest in Server/Status
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2022-11-30 14:30:46 -03:00
Maurício Meneghini Fauth
e6f8623e1f
Merge pull request #17921 from kamil-tekiela/like
...
Clean up LIKE escaping
2022-11-30 14:27:14 -03:00
Maurício Meneghini Fauth
95c9fa430c
Merge pull request #17889 from kamil-tekiela/Index-controllers
...
Refactor Index controllers
2022-11-30 13:58:56 -03:00
Maurício Meneghini Fauth
49865fe647
Remove Indexes object from the Window global object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-29 14:39:16 -03:00
Maurício Meneghini Fauth
b7a710e83f
Remove common.js from Header::addDefaultScripts()
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-29 14:17:04 -03:00
Maurício Meneghini Fauth
caf19897ac
Remove crossFramingProtection from the Window global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-28 23:43:35 -03:00
Maurício Meneghini Fauth
332e27ad39
Remove KeyHandlerEvents from the Window global object
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-28 23:11:13 -03:00
Maurício Meneghini Fauth
479f10289f
Remove the Navigation object from the Window global
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-28 22:29:13 -03:00
William Desportes
69768f15e1
Fix #17632 - Login Page: Tab keypress to Text Fields
...
Closes : #17633
Fixes : #17632
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-25 22:17:26 +01:00
William Desportes
e4b0e6bf81
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-25 21:39:21 +01:00
Scott Mcgowan
6fc1401ee2
Fix column names option for CSV Export
...
Previously work was done to enable column names in CSV exports by
default. This change actually ended up overwriting the column name value
so that column names were included in all exports regardless of whether
or not the property was disabled. This commit changes the default for
column names to enabled as the original change intended, and removes
the property overwrite.
Signed-off-by: Scott McGowan mcgowanscott16@gmail.com
2022-11-25 21:15:49 +01:00
Maurício Meneghini Fauth
2e001c186a
Remove PageSettings from the window object
...
Imports PageSettings in the main.js file instead of relying on the
global window object.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 22:00:56 -03:00
Kamil Tekiela
dd699f348d
Clean up LIKE escaping
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-25 00:06:52 +00:00
Maurício Meneghini Fauth
b2971d618f
Import the AJAX object where possible
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 15:21:18 -03:00
Maurício Meneghini Fauth
3ce84326f2
Import the Functions object where possible
...
Instead of using from the Window global object.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:43:25 -03:00
Maurício Meneghini Fauth
6f54621b41
Create a shared.js file for common JS dependencies
...
Instead of using the Webpack's dependOn setting, uses the splitChunks
setting to automatically generate the shared.js file.
As the contents of these shared dependencies are being moved to the
shared.js file, the generated file for each dependency is now empty.
Is probably safe to not generate them, but some adjustments are needed
for that first. For example, the AJAX's onload and teardown functions
expects that some of these files exists.
For now, only dependencies that are loaded for all pages should be added
in this shared.js file.
This will facilitate the refactoring of the JS files, but the trade off,
at least for now, is that will be a single large file instead of a few
medium ones.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:43:24 -03:00
Maurício Meneghini Fauth
80b5358bc0
Add an unit test for Header::addDefaultScripts()
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-24 14:34:10 -03:00
Maurício Meneghini Fauth
aabdbe7357
Update PHPStan and Psalm baselines
...
- Fix coding standard error
- Remove strict option from composer validate because the sql-parser is
pointing to a commit-ref
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-23 17:28:31 -03:00
ru-asdx
f883d9021f
Replace POST vars with ServerRequest ( #17903 )
...
* Replace POST vars with ServerRequest in UserPasswordController
* Replace POST vars with ServerRequest in Normalization
Signed-off-by: Evgeny Skorlov <eugene@skorlov.name>
2022-11-23 17:14:14 -03:00
Maurício Meneghini Fauth
5ab7640bc7
Remove force_file_* global vars and param
...
Uses a HTML data attribute instead.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 17:30:55 -03:00
Maurício Meneghini Fauth
e194eb3961
Improve type DatabaseInterface's $link params
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 14:50:52 -03:00
Maurício Meneghini Fauth
d2809ca096
Merge branch 'QA_5_2'
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-21 13:50:30 -03:00
William Desportes
182cb205a7
Fix coding standard mistakes
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 21:55:52 +01:00
William Desportes
420485a41b
Fix tests after e28bc2d8f6
...
Ref: e28bc2d8f6
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-20 18:29:07 +01:00
Maurício Meneghini Fauth
ca489f3b41
Improve type of DatabaseInterface::getLowerCaseNames()
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-19 15:50:14 -03:00
William Desportes
a60437f04a
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-19 19:09:44 +01:00
Maurício Meneghini Fauth
3c26a938cb
Add better type inference for DatabaseInterface::$links
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-18 21:36:38 -03:00
iifawzi
706c08a419
Adding PMA_TOKEN to the session
...
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 18:14:35 +02:00
iifawzi
669e30a9ce
Adding PMA_TOKEN to the session
...
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 18:02:05 +02:00
iifawzi
5207fcdb68
phpcbf fixing trailing whitespaces
...
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 17:07:46 +02:00
iifawzi
b7bf83c24c
Default to "Full texts" when running ANALYZE
...
Signed-off-by: iifawzi <iifawzie@gmail.com>
2022-11-18 17:00:10 +02:00
Maurício Meneghini Fauth
a2a3f6d26d
Create a factory for auth plugin creation
...
Extracts the factory method from the Plugins class into a new class.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-16 19:32:10 -03:00
Maurício Meneghini Fauth
8228122cdb
Merge pull request #17897 from MauricioFauth/config-load
...
Extract config load and check from Config's constructor
2022-11-15 14:51:39 -03:00
Maurício Meneghini Fauth
e5cbbcadb2
Fix Console toolbar blocking click events when collapsed
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-15 14:48:22 -03:00
Maurício Meneghini Fauth
b2eb6bf4c9
Extract config load and check from Config's constructor
...
This allows better handling of the user's config loading and validation.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-15 13:20:13 -03:00
Maurício Meneghini Fauth
40e44c0001
Merge pull request #17894 from MauricioFauth/dblist-global-removal
...
Remove the `dblist` global variable
2022-11-14 13:32:47 -03:00
William Desportes
c08b4a78f3
Merge branch 'QA_5_2'
...
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-14 14:26:16 +01:00
William Desportes
f89cb7050a
Add sodium to the extension list on the main page
...
It has a polyfill and would be nice to know that it is installed
Signed-off-by: William Desportes <williamdes@wdes.fr>
2022-11-14 14:24:44 +01:00
Maurício Meneghini Fauth
d0d90551c3
Remove the dblist global variable
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-13 21:08:00 -03:00
Maurício Meneghini Fauth
32d06ae22e
Extract schema export from schema plugins
...
Moves the response handling to the SchemaExportController.
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-12 12:56:48 -03:00
Kamil Tekiela
ff2e7f6334
Move methods to Indexes.php
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-11 22:24:27 +00:00
Maurício Meneghini Fauth
aeb237f629
Fix TypeError in Server\ReplicationController class
...
Fixes https://github.com/phpmyadmin/phpmyadmin/issues/17875
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-10 21:44:25 -03:00
Maurício Meneghini Fauth
5df50f6a11
Refactor Tracking export download to remove exit
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-10 16:18:26 -03:00
Maurício Meneghini Fauth
10a998bc8f
Wait for plugins_options to be visible in Selenium\ExportTest
...
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
2022-11-09 16:42:41 -03:00
Maurício Meneghini Fauth
7e3dcdb29d
Merge pull request #17874 from MoonE/phpunit-compat
...
Simpler PHPUnit 8 compatibility
2022-11-09 12:10:01 -03:00
Maurício Meneghini Fauth
1be99c9e31
Merge pull request #17882 from kamil-tekiela/Refactor-index-controllers
...
Refactor index controllers
2022-11-08 22:28:12 -03:00
Kamil Tekiela
656ddda704
Refactor BinlogController.php
...
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
2022-11-08 11:59:05 +00:00